Skip to content

Cleanup IRQ type definitions

Damien Le Moal linux-pci 4 versions – Applied

Status from this message: Applied to irq-clean-up, thanks! It might take a while before

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest16 patches 31 repliesApplied
  2. v32 patches 5 repliesSuperseded
  3. v22 patches 4 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches2 repliesSuperseded

Changes in v4 from the cover letter

- Added tags to patch 2
- Added patch 3 to 16

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/16PCI: Rename PCI_IRQ_LEGACY to PCI_IRQ_INTXinclude/linux/pci.h+3 -11 reply
2/16PCI: endpoint: Drop PCI_EPC_IRQ_XXX definitionsdrivers/pci/controller/cadence/pcie-cadence-ep.c drivers/pci/controller/dwc/pci-dra7xx.c drivers/pci/controller/dwc/pci-imx6.c +19 more+65 -851 reply
3/16PCI: endpoint: Use INTX instead of legacydrivers/pci/endpoint/pci-epc-core.c+2 -21 reply
4/16PCI: endpoint: Rename LEGACY to INTX in test function driverdrivers/pci/endpoint/functions/pci-epf-test.c+4 -41 reply
5/16misc: pci_endpoint_test: Use INTX instead of LEGACYdrivers/misc/pci_endpoint_test.c include/uapi/linux/pcitest.h+17 -161 reply
6/16PCI: portdrv: Use PCI_IRQ_INTXdrivers/pci/pcie/portdrv.c+4 -410 replies
7/16PCI: dra7xx: Rename dra7xx_pcie_raise_legacy_irq()drivers/pci/controller/dwc/pci-dra7xx.c+2 -21 reply
8/16PCI: cadence: Use INTX instead of legacydrivers/pci/controller/cadence/pcie-cadence-ep.c drivers/pci/controller/cadence/pcie-cadence.h+11 -111 reply
9/16PCI: dwc: Rename dw_pcie_ep_raise_legacy_irq()drivers/pci/controller/dwc/pci-imx6.c drivers/pci/controller/dwc/pci-layerscape-ep.c drivers/pci/controller/dwc/pcie-designware-ep.c +4 more+10 -102 replies
10/16PCI: keystone: Use INTX instead of legacydrivers/pci/controller/dwc/pci-keystone.c+37 -401 reply
11/16PCI: dw-rockchip: Rename rockchip_pcie_legacy_int_handler()drivers/pci/controller/dwc/pcie-dw-rockchip.c+2 -21 reply
12/16PCI: tegra194: Use INTX instead of legacydrivers/pci/controller/dwc/pcie-tegra194.c+5 -51 reply
13/16PCI: uniphier: Use INTX instead of legacydrivers/pci/controller/dwc/pcie-uniphier-ep.c drivers/pci/controller/dwc/pcie-uniphier.c+8 -81 reply
14/16PCI: rockchip-ep: Use INTX instead of legacydrivers/pci/controller/pcie-rockchip-ep.c+8 -81 reply
15/16PCI: rockchip-host: Rename rockchip_pcie_legacy_int_handler()drivers/pci/controller/pcie-rockchip-host.c+2 -21 reply
16/16PCI: xilinx-nwl: Use INTX instead of legacydrivers/pci/controller/pcie-xilinx-nwl.c+26 -261 reply

Reviews trailers per patch

15 of 16 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchYoshihiro ShimodaSerge SeminManivannan SadhasivamChristoph Hellwig
SeriesA-b
1/16R-b R-b A-b R-b
2/16R-b A-b R-b
3/16R-b
4/16R-b
5/16R-b
6/16
7/16R-b
8/16R-b
9/16R-b R-b
10/16R-b
11/16R-b
12/16R-b
13/16R-b
14/16R-b
15/16R-b
16/16R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/16] Cleanup IRQ type definitions

The first patch renames PCI_IRQ_LEGACY to PCI_IRQ_INTX as suggested by Bjorn (hence the patch authorship is given to him). The second patch removes the redundant IRQ type definitions PCI_EPC_IRQ_XXX and replace these with a direct use of the PCI_IRQ_XXX definitions. These 2 patches have been sent and reviewed previously but were never applied. Hence the resend with this new series version.

The remaining patches rename functions and correct comments etc to refer to "intx" instead of "legacy".

Changes from v3:
- Added tags to patch 2
- Added patch 3 to 16

Changes from v2:
- Modified PCI_IRQ_LEGACY comment in patch 1 as suggested by Serge
- Fixed forgotten rename in patch 2

Changes from v1:
- Updated first patch Signed-of tag and commit message as suggested by Bjorn.
- Added review tags.

Bjorn Helgaas (1):
PCI: Rename PCI_IRQ_LEGACY to PCI_IRQ_INTX

Damien Le Moal (15):
PCI: endpoint: Drop PCI_EPC_IRQ_XXX definitions
PCI: endpoint: Use INTX instead of legacy
PCI: endpoint: Rename LEGACY to INTX in test function driver
misc: pci_endpoint_test: Use INTX instead of LEGACY
PCI: portdrv: Use PCI_IRQ_INTX
PCI: dra7xx: Rename dra7xx_pcie_raise_legacy_irq()
PCI: cadence: Use INTX instead of legacy
PCI: dwc: Rename dw_pcie_ep_raise_legacy_irq()
PCI: keystone: Use INTX instead of legacy
PCI: dw-rockchip: Rename rockchip_pcie_legacy_int_handler()
PCI: tegra194: Use INTX instead of legacy
PCI: uniphier: Use INTX instead of legacy
PCI: rockchip-ep: Use INTX instead of legacy
PCI: rockchip-host: Rename rockchip_pcie_legacy_int_handler()
PCI: xilinx-nwl: Use INTX instead of legacy

 drivers/misc/pci_endpoint_test.c              | 30 +++----
 .../pci/controller/cadence/pcie-cadence-ep.c  | 19 ++--
 drivers/pci/controller/cadence/pcie-cadence.h | 12 +--
 drivers/pci/controller/dwc/pci-dra7xx.c       | 10 +--
 drivers/pci/controller/dwc/pci-imx6.c         | 11 ++-
 drivers/pci/controller/dwc/pci-keystone.c     | 86 +++++++++----------
 .../pci/controller/dwc/pci-layerscape-ep.c    | 10 +--
 drivers/pci/controller/dwc/pcie-artpec6.c     |  8 +-
 .../pci/controller/dwc/pcie-designware-ep.c   |  8 +-
 .../pci/controller/dwc/pcie-designware-plat.c | 11 ++-
 drivers/pci/controller/dwc/pcie-designware.h  |  6 +-
 drivers/pci/controller/dwc/pcie-dw-rockchip.c |  4 +-
 drivers/pci/controller/dwc/pcie-keembay.c     | 13 ++-
 drivers/pci/controller/dwc/pcie-qcom-ep.c     |  8 +-
 drivers/pci/controller/dwc/pcie-rcar-gen4.c   |  9 +-
 drivers/pci/controller/dwc/pcie-tegra194.c    | 19 ++--
 drivers/pci/controller/dwc/pcie-uniphier-ep.c | 11 ++-
 drivers/pci/controller/dwc/pcie-uniphier.c    | 12 +--
 drivers/pci/controller/pcie-rcar-ep.c         |  7 +-
 drivers/pci/controller/pcie-rockchip-ep.c     | 23 +++--
 drivers/pci/controller/pcie-rockchip-host.c   |  4 +-
 drivers/pci/controller/pcie-xilinx-nwl.c      | 52 +++++------
 drivers/pci/endpoint/functions/pci-epf-mhi.c  |  2 +-
 drivers/pci/endpoint/functions/pci-epf-ntb.c  |  4 +-
 drivers/pci/endpoint/functions/pci-epf-test.c | 14 +--
 drivers/pci/endpoint/functions/pci-epf-vntb.c |  7 +-
 drivers/pci/endpoint/pci-epc-core.c           |  6 +-
 drivers/pci/pcie/portdrv.c                    |  8 +-
 include/linux/pci-epc.h                       | 11 +--
 include/linux/pci.h                           |  4 +-
 include/uapi/linux/pcitest.h                  |  3 +-
 31 files changed, 206 insertions(+), 226 deletions(-)
Signature · 1 line
2.42.0