Skip to content

ALSA: Generic PCM copy ops using sockptr_t

Takashi Iwai alsa-devel linux-media xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest24 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/24ALSA: pcm: Add copy ops with universal sockptr_tinclude/sound/pcm.h sound/core/pcm_lib.c sound/core/pcm_native.c+57 -450 replies
2/24ALSA: core: Add memory copy helpers between sockptr and iomeminclude/sound/pcm.h sound/core/memory.c+43 -00 replies
3/24ALSA: dummy: Convert to generic PCM copy opssound/drivers/dummy.c+2 -100 replies
4/24ALSA: gus: Convert to generic PCM copy opssound/isa/gus/gus_pcm.c+3 -200 replies
5/24ALSA: emu8000: Convert to generic PCM copy opssound/isa/sb/emu8000_pcm.c+21 -580 replies
6/24ALSA: es1938: Convert to generic PCM copy opssound/pci/es1938.c+6 -250 replies
7/24ALSA: korg1212: Convert to generic PCM copy opssound/pci/korg1212/korg1212.c+10 -360 replies
8/24ALSA: nm256: Convert to generic PCM copy opssound/pci/nm256/nm256.c+6 -360 replies
9/24ALSA: rme32: Convert to generic PCM copy opssound/pci/rme32.c+11 -390 replies
10/24ALSA: rme96: Convert to generic PCM copy opssound/pci/rme96.c+11 -370 replies
11/24ALSA: hdsp: Convert to generic PCM copy opssound/pci/rme9652/hdsp.c+6 -360 replies
12/24ALSA: rme9652: Convert to generic PCM copy opssound/pci/rme9652/rme9652.c+6 -400 replies
13/24ALSA: sh: Convert to generic PCM copy opssound/sh/sh_dac_audio.c+3 -220 replies
14/24ALSA: xen: Convert to generic PCM copy opssound/xen/xen_snd_front_alsa.c+10 -450 replies
15/24ALSA: pcmtest: Update comment about PCM copy opssound/drivers/pcmtest.c+1 -10 replies
16/24media: solo6x10: Convert to generic PCM copy opsdrivers/media/pci/solo6x10/solo6x10-g723.c+8 -330 replies
17/24ASoC: component: Add generic PCM copy opsinclude/sound/soc-component.h sound/soc/soc-component.c sound/soc/soc-pcm.c+30 -10 replies
18/24ASoC: mediatek: Convert to generic PCM copy opssound/soc/mediatek/common/mtk-btcvsd.c+11 -110 replies
19/24ASoC: qcom: Convert to generic PCM copy opssound/soc/qcom/lpass-platform.c+6 -60 replies
20/24ASoC: dmaengine: Convert to generic PCM copy opssound/soc/soc-generic-dmaengine-pcm.c+8 -80 replies
21/24ASoC: dmaengine: Use sockptr_t for process callback, tooinclude/sound/dmaengine_pcm.h sound/soc/atmel/mchp-pdmc.c sound/soc/soc-generic-dmaengine-pcm.c +1 more+5 -50 replies
22/24ALSA: doc: Update description for the new PCM copy opsDocumentation/sound/kernel-api/writing-an-alsa-driver.rst+20 -390 replies
23/24ASoC: pcm: Drop obsoleted PCM copy_user opsinclude/sound/soc-component.h sound/soc/soc-component.c sound/soc/soc-pcm.c+0 -290 replies
24/24ALSA: pcm: Drop obsoleted PCM copy_user and copy_kernel opsinclude/sound/pcm.h sound/core/pcm_lib.c sound/core/pcm_native.c+1 -220 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/24] ALSA: Generic PCM copy ops using sockptr_t

Hi,

this is a patch set to clean up the PCM copy ops using sockptr_t as a "universal" pointer, inspired by the recent patch from Andy Shevchenko:
https://lore.kernel.org/r/[email protected]

Even though it sounds a bit weird, sockptr_t is a generic type that is used already in wide ranges, and it can fit our purpose, too. With sockptr_t, the former split of copy_user and copy_kernel PCM ops can be unified again gracefully.

The patch set introduces the new PCM ops, converting users, and drops the old PCM ops. Most of conversions are straightforward, simply replacing copy_*_user() with copy_*_sockptr() variants.

Note that the conversion in ASoC will fix a potential problem of ASoC PCM that has been for long time. Since ASoC component takes care of only copy_user, the conversion form/to kernel space might have been missing. With this patch set, both cases are handled with sockptr_t by a single callback.

The patches are lightly tested (with a faked PCM copy implementation on HD-audio), while most of patches are only compile-tested.

Takashi

===

Cc Andy Shevchenko <[email protected]>
Cc Andrey Utkin <[email protected]>
Cc Anton Sviridenko <[email protected]>
Cc Arnaud Pouliquen <[email protected]>
Cc Banajit Goswami <[email protected]>
Cc Bluecherry Maintainers <[email protected]>
Cc Claudiu Beznea <[email protected]>
Cc Ismael Luceno <[email protected]>
Cc Lars-Peter Clausen <[email protected]>
Cc Mark Brown <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Cc Oleksandr Andrushchenko <[email protected]>
Cc Olivier Moysan <[email protected]>
Cc Srinivas Kandagatla <[email protected]>

===

Takashi Iwai (24):
ALSA: pcm: Add copy ops with universal sockptr_t
ALSA: core: Add memory copy helpers between sockptr and iomem
ALSA: dummy: Convert to generic PCM copy ops
ALSA: gus: Convert to generic PCM copy ops
ALSA: emu8000: Convert to generic PCM copy ops
ALSA: es1938: Convert to generic PCM copy ops
ALSA: korg1212: Convert to generic PCM copy ops
ALSA: nm256: Convert to generic PCM copy ops
ALSA: rme32: Convert to generic PCM copy ops
ALSA: rme96: Convert to generic PCM copy ops
ALSA: hdsp: Convert to generic PCM copy ops
ALSA: rme9652: Convert to generic PCM copy ops
ALSA: sh: Convert to generic PCM copy ops
ALSA: xen: Convert to generic PCM copy ops
ALSA: pcmtest: Update comment about PCM copy ops
media: solo6x10: Convert to generic PCM copy ops
ASoC: component: Add generic PCM copy ops
ASoC: mediatek: Convert to generic PCM copy ops
ASoC: qcom: Convert to generic PCM copy ops
ASoC: dmaengine: Convert to generic PCM copy ops
ASoC: dmaengine: Use sockptr_t for process callback, too
ALSA: doc: Update description for the new PCM copy ops
ASoC: pcm: Drop obsoleted PCM copy_user ops
ALSA: pcm: Drop obsoleted PCM copy_user and copy_kernel ops

 .../kernel-api/writing-an-alsa-driver.rst     | 59 +++++---------
 drivers/media/pci/solo6x10/solo6x10-g723.c    | 41 ++--------
 include/sound/dmaengine_pcm.h                 |  2 +-
 include/sound/pcm.h                           | 12 +--
 include/sound/soc-component.h                 | 14 ++--
 sound/core/memory.c                           | 39 +++++++++
 sound/core/pcm_lib.c                          | 81 +++++++++----------
 sound/core/pcm_native.c                       |  2 +-
 sound/drivers/dummy.c                         | 12 +--
 sound/drivers/pcmtest.c                       |  2 +-
 sound/isa/gus/gus_pcm.c                       | 23 +-----
 sound/isa/sb/emu8000_pcm.c                    | 79 +++++-------------
 sound/pci/es1938.c                            | 31 ++-----
 sound/pci/korg1212/korg1212.c                 | 46 +++--------
 sound/pci/nm256/nm256.c                       | 42 ++--------
 sound/pci/rme32.c                             | 50 +++---------
 sound/pci/rme96.c                             | 48 +++--------
 sound/pci/rme9652/hdsp.c                      | 42 ++--------
 sound/pci/rme9652/rme9652.c                   | 46 ++---------
 sound/sh/sh_dac_audio.c                       | 25 +-----
 sound/soc/atmel/mchp-pdmc.c                   |  2 +-
 sound/soc/mediatek/common/mtk-btcvsd.c        | 22 ++---
 sound/soc/qcom/lpass-platform.c               | 12 +--
 sound/soc/soc-component.c                     | 10 +--
 sound/soc/soc-generic-dmaengine-pcm.c         | 18 ++---
 sound/soc/soc-pcm.c                           |  4 +-
 sound/soc/stm/stm32_sai_sub.c                 |  2 +-
 sound/xen/xen_snd_front_alsa.c                | 55 +++----------
 28 files changed, 251 insertions(+), 570 deletions(-)
Signature · 1 line
2.35.3