Skip to content

hp-bioscfg: Overall fixes and code cleanup

Jorge Lopez lkml platform-driver-x86 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8hp-bioscfg: Fix memory leaks in attribute packagesdrivers/platform/x86/hp/hp-bioscfg/enum-attributes.c drivers/platform/x86/hp/hp-bioscfg/int-attributes.c drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c +2 more+28 -00 replies
2/8hp-bioscfg: Fix uninitialized variable errorsdrivers/platform/x86/hp/hp-bioscfg/enum-attributes.c drivers/platform/x86/hp/hp-bioscfg/int-attributes.c drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c +2 more+6 -60 replies
3/8hp-bioscfg: Replace the word HACK from source codedrivers/platform/x86/hp/hp-bioscfg/enum-attributes.c drivers/platform/x86/hp/hp-bioscfg/int-attributes.c drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c +2 more+8 -80 replies
4/8hp-bioscfg: Change how prerequisites size is evaluateddrivers/platform/x86/hp/hp-bioscfg/enum-attributes.c drivers/platform/x86/hp/hp-bioscfg/int-attributes.c drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c +2 more+21 -90 replies
5/8hp-bioscfg: Change how order list size is evaluateddrivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c+5 -20 replies
6/8hp-bioscfg: Change how enum possible values size is evaluateddrivers/platform/x86/hp/hp-bioscfg/enum-attributes.c+4 -20 replies
7/8hp-bioscfg: Change how password encoding size is evaluateddrivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c+5 -20 replies
8/8hp-bioscfg: Remove duplicate use of variable in inner loopdrivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c+5 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] hp-bioscfg: Overall fixes and code cleanup

Submit individual patches to address memory leaks and uninitialized variable errors.
Addressed several review comments making the source code more readable. Removed duplicate use of variable in inner loop.

Changes were tested with a HP EliteBook x360 1030 G3

Jorge Lopez (8):
hp-bioscfg: Fix memory leaks in attribute packages
hp-bioscfg: Fix uninitialized variable errors
hp-bioscfg: Replace the word HACK from source code
hp-bioscfg: Change how prerequisites size is evaluated
hp-bioscfg: Change how order list size is evaluated
hp-bioscfg: Change how enum possible values size is evaluated
hp-bioscfg: Change how password encoding size is evaluated
hp-bioscfg: Remove duplicate use of variable in inner loop

 .../x86/hp/hp-bioscfg/enum-attributes.c       | 24 ++++++++----
 .../x86/hp/hp-bioscfg/int-attributes.c        | 15 +++++--
 .../x86/hp/hp-bioscfg/order-list-attributes.c | 39 ++++++++++++-------
 .../x86/hp/hp-bioscfg/passwdobj-attributes.c  | 27 +++++++++----
 .../x86/hp/hp-bioscfg/string-attributes.c     | 13 +++++--
 5 files changed, 82 insertions(+), 36 deletions(-)

--
2.34.1