Skip to content

tracing: Remove eventfs_files by use of callbacks

Steven Rostedt linux-trace-kernel lkml oe-lkp 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tracefs: Add show_events_dentriesfs/tracefs/Makefile fs/tracefs/event_inode.c fs/tracefs/event_show.c +3 more+169 -350 replies
2/2eventfs: Remove eventfs_file and just use eventfs_inodefs/tracefs/event_inode.c fs/tracefs/event_show.c fs/tracefs/inode.c +5 more+683 -5160 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] tracing: Remove eventfs_files by use of callbacks

This patch set is on top of:

https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git/
trace/core

The first patch adds a file to tracefs that shows all the event_files that have been allocated for the dynamic eventfs file system. It also shows the dentries that were created and their current ref counts. This is useful for debugging and knowing when a dentry has been created and freed.

I plan on adding the first patch to the next merge window. The second patch I plan on adding to the merge window after that.

The second patch is a bit of a redesign of the way the eventfs is created. It no longer creates a descriptor representing every file but instead just the directories. These descriptors get an array of entries that represent the files within it (but not for sub directories). Each entry has a name and a callback, where the name is the name of the file (used for lookup) and a callback that is used to create the dentry and inode for the file. This saves more memory, this approach may be possible to create a dynamic way of doing this for other pseudo file systems.

Steven Rostedt (Google) (2):
tracefs: Add show_events_dentries
eventfs: Remove eventfs_file and just use eventfs_inode

----

 fs/tracefs/Makefile          |   1 +
 fs/tracefs/event_inode.c     | 781 ++++++++++++++++++++++---------------------
 fs/tracefs/event_show.c      | 125 +++++++
 fs/tracefs/inode.c           |   2 +-
 fs/tracefs/internal.h        |  34 +-
 include/linux/trace_events.h |   2 +-
 include/linux/tracefs.h      |  31 +-
 kernel/trace/trace.h         |   4 +-
 kernel/trace/trace_events.c  | 309 ++++++++++++-----
 9 files changed, 795 insertions(+), 494 deletions(-)
 create mode 100644 fs/tracefs/event_show.c