Skip to content

Invalidate TLB cache for all GT's

Andi Shyti dri-devel intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/i915/gt: Move TLB invalidation to its own filedrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/gem/i915_gem_pages.c drivers/gpu/drm/i915/gt/intel_gt.c +5 more+197 -1520 replies
2/4i915/drm/gt: Move the gt defines in the gt directorydrivers/gpu/drm/i915/gt/intel_gt_defines.h drivers/gpu/drm/i915/i915_drv.h+12 -10 replies
3/4drm/i915: Invalidate the TLBs on each GTdrivers/gpu/drm/i915/gem/i915_gem_object_types.h drivers/gpu/drm/i915/gem/i915_gem_pages.c drivers/gpu/drm/i915/gt/intel_ppgtt.c +1 more+24 -110 replies
4/4drm/i915: Remove unnecessary includedrivers/gpu/drm/i915/i915_drv.h+0 -10 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndi ShytiMauro Carvalho Chehab
SeriesR-b
1/4R-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] Invalidate TLB cache for all GT's

Hi,

This series revisits a once-trendy topic: TLB invalidation support for multi-gt. It's a theme that's been passed around and reshaped by several of us.

I've filtered out most of the original changes from this series, initially sent by Mauro [1]. His ideas were inspired by some changes from Chris, who in turn was inspired by a change from me[2], all of which stemmed from offline talks by Chris (it's like a game of inspiration tag!).

What I've done is simply rebase and refactor the patches, focusing solely on the changes needed for multi-gt TLB invalidation in MMIO memory. The result is a leaner, more targeted proposal.

Other patches from the original series might follow.

Thanks,
Andi

[1] https://patchwork.freedesktop.org/series/106293/
[2] https://patchwork.freedesktop.org/series/103831/

Andi Shyti (2):
i915/drm/gt: Move the gt defines in the gt directory drm/i915: Remove unnecessary include

Chris Wilson (2):
drm/i915/gt: Move TLB invalidation to its own file drm/i915: Invalidate the TLBs on each GT

 drivers/gpu/drm/i915/Makefile                 |   1 +
 .../gpu/drm/i915/gem/i915_gem_object_types.h  |   4 +-
 drivers/gpu/drm/i915/gem/i915_gem_pages.c     |  15 +-
 drivers/gpu/drm/i915/gt/intel_gt.c            | 140 +--------------
 drivers/gpu/drm/i915/gt/intel_gt.h            |  12 --
 drivers/gpu/drm/i915/gt/intel_gt_defines.h    |  11 ++
 drivers/gpu/drm/i915/gt/intel_ppgtt.c         |   4 +-
 drivers/gpu/drm/i915/gt/intel_tlb.c           | 159 ++++++++++++++++++
 drivers/gpu/drm/i915/gt/intel_tlb.h           |  29 ++++
 drivers/gpu/drm/i915/gt/selftest_tlb.c        |   3 +-
 drivers/gpu/drm/i915/i915_drv.h               |   1 -
 drivers/gpu/drm/i915/i915_vma.c               |  15 +-
 12 files changed, 231 insertions(+), 163 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/gt/intel_gt_defines.h
 create mode 100644 drivers/gpu/drm/i915/gt/intel_tlb.c
 create mode 100644 drivers/gpu/drm/i915/gt/intel_tlb.h
Signature · 1 line
2.40.1