Skip to content

DRM scheduler changes for Xe

Matthew Brost dri-devel intel-xe 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest5 patches 5 repliesIn review
  2. v76 patches 7 repliesSuperseded
  3. v67 patches 14 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v57 patches25 repliesSuperseded
v410 patches32 repliesSuperseded
v313 patches36 repliesSuperseded
v29 patches70 repliesSuperseded
v18 patches15 repliesSuperseded

Changes in v8 from the cover letter

- Rebase on drm-tip which includes Luben's patch for dynamic run queues
- Don't adjust comments, change variable names, function names twice in series
- Don't move existing code to different places in a file to preserve git history

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/sched: Add drm_sched_wqueue_* helpersdrivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +3 more+59 -180 replies
2/5drm/sched: Convert drm scheduler to use a work queue rather than kthreaddrivers/gpu/drm/amd/amdgpu/amdgpu_device.c drivers/gpu/drm/etnaviv/etnaviv_sched.c drivers/gpu/drm/lima/lima_sched.c +6 more+86 -810 replies
3/5drm/sched: Split free_job into own work itemdrivers/gpu/drm/scheduler/sched_main.c include/drm/gpu_scheduler.h+101 -4922 replies
4/5drm/sched: Add drm_sched_start_timeout_unlocked helperdrivers/gpu/drm/scheduler/sched_main.c+13 -100 replies
5/5drm/sched: Add a helper to queue TDR immediatelydrivers/gpu/drm/scheduler/sched_main.c include/drm/gpu_scheduler.h+18 -10 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchLuben TuikovDanilo KrummrichMatthew Brost
1/5R-b
2/5R-b
3/5R-b R-b R-b R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v8 thread

Cover letter [PATCH v8 0/5] DRM scheduler changes for Xe

As a prerequisite to merging the new Intel Xe DRM driver [1] [2], we
have been asked to merge our common DRM scheduler patches first.

This a continuation of a RFC [3] with all comments addressed, ready for a full review, and hopefully in state which can merged in the near future. More details of this series can found in the cover letter of the RFC [3].

These changes have been tested with the Xe driver. Based on drm-tip branch.

A follow up series will be posted to address some of dakr requets for kernel doc changes.

v2:
- Break run job, free job, and process message in own work items
- This might break other drivers as run job and free job now can run in parallel, can fix up if needed

v3:
- Include missing patch 'drm/sched: Add drm_sched_submit_* helpers'
- Fix issue with setting timestamp to early
- Don't dequeue jobs for single entity after calling entity fini
- Flush pending jobs on entity fini
- Add documentation for entity teardown
- Add Matthew Brost to maintainers of DRM scheduler

v4:
- Drop message interface
- Drop 'Flush pending jobs on entity fini'
- Drop 'Add documentation for entity teardown'
- Address all feedback

v5:
- Address Luben's feedback
- Drop starting TDR after calling run_job()
- Drop adding Matthew Brost to maintainers of DRM scheduler

v6:
- Address Luben's feedback
- Include base commit

v7:
- Drop SINGLE_ENTITY mode rather pull in Luben's patch for dynamic run queues
- Address Luben's feedback for free_job work item patch

v8:
- Rebase on drm-tip which includes Luben's patch for dynamic run queues
- Don't adjust comments, change variable names, function names twice in series
- Don't move existing code to different places in a file to preserve git history

Matt

[1] https://gitlab.freedesktop.org/drm/xe/kernel
[2] https://patchwork.freedesktop.org/series/112188/
[3] https://patchwork.freedesktop.org/series/116055/

Matthew Brost (5):
drm/sched: Add drm_sched_wqueue_* helpers
drm/sched: Convert drm scheduler to use a work queue rather than
kthread
drm/sched: Split free_job into own work item drm/sched: Add drm_sched_start_timeout_unlocked helper drm/sched: Add a helper to queue TDR immediately

 .../drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c   |   2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c   |  15 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |  14 +-
 drivers/gpu/drm/etnaviv/etnaviv_sched.c       |   2 +-
 drivers/gpu/drm/lima/lima_sched.c             |   2 +-
 drivers/gpu/drm/msm/adreno/adreno_device.c    |   6 +-
 drivers/gpu/drm/msm/msm_ringbuffer.c          |   2 +-
 drivers/gpu/drm/nouveau/nouveau_sched.c       |   2 +-
 drivers/gpu/drm/panfrost/panfrost_job.c       |   2 +-
 drivers/gpu/drm/scheduler/sched_main.c        | 301 ++++++++++++------
 drivers/gpu/drm/v3d/v3d_sched.c               |  10 +-
 include/drm/gpu_scheduler.h                   |  20 +-
 12 files changed, 248 insertions(+), 130 deletions(-)

base-commit: b560681c6bf623db41064ac486dd148d6c103e53

Signature · 1 line
2.34.1