Skip to content

Make atomisp driver to be generic

Kate Hsuan linux-media linux-staging 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12media: atomisp: ia_css_raw.host: Remove #ifdef ISP2401 to make the driver genericdrivers/staging/media/atomisp/pci/isp/kernels/raw/raw_1.0/ia_css_raw.host.c+7 -140 replies
2/12media: atomisp: binary: Removed #ifdef ISP2401 to make driver genericdrivers/staging/media/atomisp/pci/runtime/binary/src/binary.c+8 -70 replies
3/12media: atomisp: hive_isp_css_include: Removed #ifdef ISP2401 to make driver genericdrivers/staging/media/atomisp/pci/hive_isp_css_include/host/csi_rx_public.h drivers/staging/media/atomisp/pci/hive_isp_css_include/host/pixelgen_public.h+0 -40 replies
4/12media: atomisp: atomisp_compat_css20: Removed #ifdef ISP2401 to make driver genericdrivers/staging/media/atomisp/pci/atomisp_compat_css20.c+6 -80 replies
5/12media: atomisp: sh_css_mipi: Removed unused code ia_css_mipi_frame_enable_check_on_size()drivers/staging/media/atomisp/pci/ia_css_mipi.h drivers/staging/media/atomisp/pci/sh_css_mipi.c+0 -450 replies
6/12media: atomisp: sh_css: Removed #ifdef ISP2401 to make the driver genericdrivers/staging/media/atomisp/pci/sh_css.c+5 -70 replies
7/12media: atomisp: sh_css_sp: Remove #ifdef ISP2401 to make driver genericdrivers/staging/media/atomisp/pci/sh_css_sp.c drivers/staging/media/atomisp/pci/sh_css_sp.h+21 -410 replies
8/12media: atomisp: sh_css: Removed #ifdef ISP2401 to make driver genericdrivers/staging/media/atomisp/pci/sh_css.c+22 -320 replies
9/12media: atomisp: sh_css: Renamed sh_css_config_input_network()drivers/staging/media/atomisp/pci/sh_css.c+21 -310 replies
10/12media: atomisp: sh_css: Removed #ifdef ISP2401 to make code genericdrivers/staging/media/atomisp/pci/sh_css.c+36 -360 replies
11/12media: atomisp: sh_css: Removed #ifdef ISP2401 to make the driver genericdrivers/staging/media/atomisp/pci/sh_css.c+17 -250 replies
12/12media: atomisp: atomisp_v4l2: Removed unnecessary codedrivers/staging/media/atomisp/pci/atomisp_v4l2.c+0 -190 replies

Reviews trailers per patch

None of the 12 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHans de Goede
SeriesR-b
1/12
2/12
3/12
4/12
5/12
6/12
7/12
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/12] Make atomisp driver to be generic

This batch of work removed all the #ifdef and made the driver able to drive both ISP2400 and ISP2401. The changes include:

1. #ifdef were removed and the driver execution flow is determined in runtime.
2. ia_css_mipi_frame_enable_check_on_size() wasn't used so it also removed.
3. sh_css_config_input_network() for ISP2400 and ISP2401 was determined in compiler time. This was also renamed to sh_css_config_input_network_2400() and sh_css_config_input_network_2401() for both types of atomisp.
4. The atomisp type test at the begining of the driver was removed so this driver can drive both types of atomisp.

Kate Hsuan (12):
media: atomisp: ia_css_raw.host: Remove #ifdef ISP2401 to make the
driver generic
media: atomisp: binary: Removed #ifdef ISP2401 to make driver generic
media: atomisp: hive_isp_css_include: Removed #ifdef ISP2401 to make
driver generic
media: atomisp: atomisp_compat_css20: Removed #ifdef ISP2401 to make
driver generic
media: atomisp: sh_css_mipi: Removed unused code
ia_css_mipi_frame_enable_check_on_size()
media: atomisp: sh_css: Removed #ifdef ISP2401 to make the driver
generic
media: atomisp: sh_css_sp: Remove #ifdef ISP2401 to make driver
generic
media: atomisp: sh_css: Removed #ifdef ISP2401 to make driver generic
media: atomisp: sh_css: Renamed sh_css_config_input_network()
media: atomisp: sh_css: Removed #ifdef ISP2401 to make code generic
media: atomisp: sh_css: Removed #ifdef ISP2401 to make the driver
generic
media: atomisp: atomisp_v4l2: Removed unnecessary code

 .../media/atomisp/pci/atomisp_compat_css20.c  |  14 +-
 .../staging/media/atomisp/pci/atomisp_v4l2.c  |  19 --
 .../hive_isp_css_include/host/csi_rx_public.h |   2 -
 .../host/pixelgen_public.h                    |   2 -
 .../staging/media/atomisp/pci/ia_css_mipi.h   |  16 --
 .../isp/kernels/raw/raw_1.0/ia_css_raw.host.c |  21 +-
 .../atomisp/pci/runtime/binary/src/binary.c   |  15 +-
 drivers/staging/media/atomisp/pci/sh_css.c    | 232 ++++++++----------
 .../staging/media/atomisp/pci/sh_css_mipi.c   |  29 ---
 drivers/staging/media/atomisp/pci/sh_css_sp.c |  60 ++---
 drivers/staging/media/atomisp/pci/sh_css_sp.h |   2 -
 11 files changed, 143 insertions(+), 269 deletions(-)
Signature · 1 line
2.41.0