Skip to content

target/m68k: Fix a few semihosting bugs

Keith Packard via qemu-devel 1 version Applied

Status from this message: Queued patch 1 to m68k-next. Patch 2 has already been committed, and I've just sent a replacement for patch 3.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3target/m68k: Pass semihosting arg to exittarget/m68k/m68k-semi.c+2 -21 reply
2/3target/m68k: Fix semihost lseek offset computationtarget/m68k/m68k-semi.c+1 -10 replies
3/3target/m68k: Support semihosting on non-ColdFire targetstarget/m68k/cpu.h target/m68k/op_helper.c target/m68k/translate.c+21 -01 reply

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchPeter Maydell
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] target/m68k: Fix a few semihosting bugs

The first two patches mirror similar patches I recently sent for nios2.

1. Use correct parameter for EXIT (d1 instead of d0)
2. Fix use of deposit64 in LSEEK (argument order was incorrect)

The second patch has also been submitted by Peter Maydell, it's included here because it was required to get things working.

The final patch adds semihosting support for non-ColdFire processors (which don't support the HALT instruction) by using BKPT #0 instead (as per the m68k semihosting docs).

All of these have been tested using picolibc (patches for m68k support there are moving upstream as well).