Skip to content

Fix xfs/179 for 5.10 stable

Guoqing Jiang linux-xfs stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2xfs: hoist refcount record merge predicatesfs/xfs/libxfs/xfs_refcount.c+113 -160 replies
2/2xfs: estimate post-merge refcounts correctlyfs/xfs/libxfs/xfs_refcount.c+21 -40 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDave ChinnerXiao Yang
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 5.10 0/2] Fix xfs/179 for 5.10 stable

Hi,

With the two patches applied, xfs/179 can pass in 5.10.188. Otherwise I got

[root@localhost xfstests]# ./check xfs/179

FSTYP         -- xfs (non-debug)
PLATFORM      -- Linux/x86_64 localhost 5.10.188-default #14 SMP Thu Aug 3 15:23:19 CST 2023
MKFS_OPTIONS  -- -f /dev/loop1

MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/loop1 /mnt/scratch

xfs/179 1s ... [failed, exit status 1]- output mismatch (see /root/xfstests/results//xfs/179.out.bad)
--- tests/xfs/179.out 2023-07-13 16:12:27.000000000 +0800
+++ /root/xfstests/results//xfs/179.out.bad 2023-08-03 16:55:38.173787911 +0800
@@ -8,3 +8,5 @@
Check scratch fs
Remove reflinked files
Check scratch fs
+xfs_repair fails
+(see /root/xfstests/results//xfs/179.full for details)
...
(Run 'diff -u /root/xfstests/tests/xfs/179.out /root/xfstests/results//xfs/179.out.bad' to see the entire diff)

HINT: You _MAY_ be missing kernel fix:
b25d1984aa88 xfs: estimate post-merge refcounts correctly

Ran: xfs/179
Failures: xfs/179
Failed 1 of 1 tests

Please review if they are approriate for 5.10 stable.

Thanks,
Guoqing

Darrick J. Wong (2):
xfs: hoist refcount record merge predicates
xfs: estimate post-merge refcounts correctly

 fs/xfs/libxfs/xfs_refcount.c | 146 +++++++++++++++++++++++++++++++----
 1 file changed, 130 insertions(+), 16 deletions(-)
Signature · 1 line
2.33.0