Skip to content

lib/xe_spin: introduced fixed duration xe_spin

Marcin Bernatowicz igt-dev 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest4 patches 4 repliesIn review
  2. v44 patches 3 repliesSuperseded
  3. v3 posting 2/23 patches 7 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v3 posting 1/23 patches0 repliesSuperseded
v22 patches0 repliesSuperseded
v12 patches6 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4lib/xe_spin: xe_spin_opts for xe_spin initializationlib/xe/xe_spin.c lib/xe/xe_spin.h tests/intel/xe_dma_buf_sync.c +4 more+57 -430 replies
2/4lib/xe_spin: fixed duration xe_spin capabilitylib/xe/xe_spin.c lib/xe/xe_spin.h+103 -20 replies
3/4tests/xe_spin_batch: spin-fixed-durationtests/intel/xe_spin_batch.c+73 -00 replies
4/4lib/xe_spin.c: fixed code stylelib/xe/xe_spin.c+2 -10 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchZbigniew KempczyńskiKamil Konieczny
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [igt-dev] [PATCH i-g-t v5 0/4] lib/xe_spin: introduced fixed duration xe_spin

Introduced struct xe_spin_opts for xe_spin initialization, adjusted tests to new xe_spin_init signature.

Extended spinner with fixed duration capability. It allows to prepare fixed duration (ex. 10ms) workloads and take workloads/second measurements, a handy utility for scheduling tests.

Basic test for xe_spin with fixed duration.

v2: - added asserts in div64_u64_round_up, duration_to_ctx_ticks,
simplified loop_addr (Zbyszek)
- added xe_spin_init_opts macro (Zbyszek)
- corrected patch title (Kamil)
- Added assert for expected spinner duration. (Zbyszek) A median of 5x100ms spins duration is computed, which should satisfy CI runs, although better accuracy is achieved with disabled logging (echo 0 > /sys/module/drm/parameters/debug).

v3: - extracted xe_spin_opts to separate patch (Kamil)
- div64_u64_round_up assert on overflow (Kamil)
- enum indentation cleanup in xe_spin.c (Kamil)

v4: - checkpatch fixes (Kamil)
- corrected variables readability in xe_spin_fixed_duration (Zbyszek)

v5: - fixed subject line to describe the change
not the tool that found it (Kamil)
- fixed too long line warning

Marcin Bernatowicz (4):
lib/xe_spin: xe_spin_opts for xe_spin initialization lib/xe_spin: fixed duration xe_spin capability tests/xe_spin_batch: spin-fixed-duration lib/xe_spin.c: fixed code style

 lib/xe/xe_spin.c               | 126 ++++++++++++++++++++++++++++-----
 lib/xe/xe_spin.h               |  27 ++++++-
 tests/intel/xe_dma_buf_sync.c  |   6 +-
 tests/intel/xe_exec_balancer.c |   9 ++-
 tests/intel/xe_exec_reset.c    |  24 ++++---
 tests/intel/xe_exec_threads.c  |   7 +-
 tests/intel/xe_spin_batch.c    |  73 +++++++++++++++++++
 tests/intel/xe_vm.c            |   7 +-
 8 files changed, 234 insertions(+), 45 deletions(-)
Signature · 1 line
2.30.2