kunit: Add dynamically-extending log
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest10 patches 1 replyIn review
- v510 patches 18 repliesSuperseded
- v410 patches 20 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 7 patches | 14 replies | Superseded | |
| v2 | 6 patches | 6 replies | Superseded | |
| v1 | 1 patch | 2 replies | Superseded |
Changes in v6 from the cover letter
Patch 2:
- Avoid cast warning when using KUNIT_EXPECT_EQ() on a gfp_t. Instead pass the result of the comparison to KUNIT_EXPECT_TRUE(). While it would be nice to use KUNIT_EXPECT_EQ(), it's probably better to avoid introducing build or sparse warnings.
- In string_stream_append_test() rename original_content to stream1_content_before_append.
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | kunit: string-stream: Don't create a fragment for empty stringslib/ | +8 | 0 replies | |
| 2/10 | kunit: string-stream: Improve testing of string_streamlib/ | +217 | 0 replies | |
| 3/10 | kunit: string-stream: Add option to make all lines end with newlinelib/ lib/ | +28 | 0 replies | |
| 4/10 | kunit: string-stream-test: Add cases for string_stream newline appendinglib/ | +93 | 0 replies | |
| 5/10 | kunit: Don't use a managed alloc in is_literal()lib/ | +6 | 0 replies | |
| 6/10 | kunit: string-stream: Add kunit_alloc_string_stream()lib/ lib/ lib/ +1 more | +29 | 0 replies | |
| 7/10 | kunit: string-stream: Decouple string_stream from kunitlib/ lib/ lib/ +1 more | +53 | 0 replies | |
| 8/10 | kunit: string-stream: Add tests for freeing resource-managed string_streamlib/ lib/ | +145 | 1 reply | |
| 9/10 | kunit: Use string_stream for test loginclude/ lib/ lib/ +1 more | +81 | 0 replies | |
| 10/10 | kunit: string-stream: Test performance of string_streamlib/ | +54 | 0 replies |
Reviews trailers per patch
All 10 patches have a Reviewed-by or Acked-by.
| Patch | Rae Moar | David Gow |
|---|---|---|
| 1/10 | R-b | R-b |
| 2/10 | R-b | R-b |
| 3/10 | R-b | R-b |
| 4/10 | R-b | R-b |
| 5/10 | R-b | |
| 6/10 | R-b | |
| 7/10 | R-b | |
| 8/10 | R-b | |
| 9/10 | R-b | |
| 10/10 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 00/10] kunit: Add dynamically-extending log
This patch chain changes the logging implementation to use string_stream so that the log will grow dynamically.
The first 8 patches add test code for string_stream, and make some changes to string_stream needed to be able to use it for the log.
The final patch adds a performance report of string_stream.
CHANGES SINCE V5:
Patch 2:
- Avoid cast warning when using KUNIT_EXPECT_EQ() on a gfp_t. Instead pass the result of the comparison to KUNIT_EXPECT_TRUE(). While it would be nice to use KUNIT_EXPECT_EQ(), it's probably better to avoid introducing build or sparse warnings.
- In string_stream_append_test() rename original_content to stream1_content_before_append.
Patch 7:
- Make string_stream_clear() public (in v5 this was done in patch #8).
- In string-stream-test.c add a wrapper for kfree() to prevent a cast warning when calling kunit_add_action().
Patch 8:
- Fix memory leak when calling the redirected string_stream_destroy_stub().
Patch 9:
- In kunit-test.c: add wrapper function around kfree() to prevent cast warning when calling kunit_add_action().
- Fix unused variable warning in kunit_log_test() when built as a module.
Richard Fitzgerald (10):
kunit: string-stream: Don't create a fragment for empty strings
kunit: string-stream: Improve testing of string_stream
kunit: string-stream: Add option to make all lines end with newline
kunit: string-stream-test: Add cases for string_stream newline
appending
kunit: Don't use a managed alloc in is_literal()
kunit: string-stream: Add kunit_alloc_string_stream()
kunit: string-stream: Decouple string_stream from kunit
kunit: string-stream: Add tests for freeing resource-managed
string_stream
kunit: Use string_stream for test log
kunit: string-stream: Test performance of string_stream
include/kunit/test.h | 14 +- lib/kunit/assert.c | 14 +- lib/kunit/debugfs.c | 36 ++- lib/kunit/kunit-test.c | 56 +++- lib/kunit/string-stream-test.c | 525 +++++++++++++++++++++++++++++++-- lib/kunit/string-stream.c | 100 +++++-- lib/kunit/string-stream.h | 16 +- lib/kunit/test.c | 50 +--- 8 files changed, 688 insertions(+), 123 deletions(-)
Signature · 1 line
2.30.2