Skip to content

kunit: Add dynamically-extending log

Richard Fitzgerald linux-kselftest lkml 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest10 patches 1 replyIn review
  2. v510 patches 18 repliesSuperseded
  3. v410 patches 20 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v37 patches14 repliesSuperseded
v26 patches6 repliesSuperseded
v11 patch2 repliesSuperseded

Changes in v6 from the cover letter

Patch 2:
- Avoid cast warning when using KUNIT_EXPECT_EQ() on a gfp_t. Instead pass the result of the comparison to KUNIT_EXPECT_TRUE(). While it would be nice to use KUNIT_EXPECT_EQ(), it's probably better to avoid introducing build or sparse warnings.

- In string_stream_append_test() rename original_content to stream1_content_before_append.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10kunit: string-stream: Don't create a fragment for empty stringslib/kunit/string-stream.c+8 -20 replies
2/10kunit: string-stream: Improve testing of string_streamlib/kunit/string-stream-test.c+217 -160 replies
3/10kunit: string-stream: Add option to make all lines end with newlinelib/kunit/string-stream.c lib/kunit/string-stream.h+28 -70 replies
4/10kunit: string-stream-test: Add cases for string_stream newline appendinglib/kunit/string-stream-test.c+93 -00 replies
5/10kunit: Don't use a managed alloc in is_literal()lib/kunit/assert.c+6 -80 replies
6/10kunit: string-stream: Add kunit_alloc_string_stream()lib/kunit/string-stream-test.c lib/kunit/string-stream.c lib/kunit/string-stream.h +1 more+29 -180 replies
7/10kunit: string-stream: Decouple string_stream from kunitlib/kunit/string-stream-test.c lib/kunit/string-stream.c lib/kunit/string-stream.h +1 more+53 -240 replies
8/10kunit: string-stream: Add tests for freeing resource-managed string_streamlib/kunit/string-stream-test.c lib/kunit/string-stream.c+145 -51 reply
9/10kunit: Use string_stream for test loginclude/kunit/test.h lib/kunit/debugfs.c lib/kunit/kunit-test.c +1 more+81 -690 replies
10/10kunit: string-stream: Test performance of string_streamlib/kunit/string-stream-test.c+54 -00 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchRae MoarDavid Gow
1/10R-b R-b
2/10R-b R-b
3/10R-b R-b
4/10R-b R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 00/10] kunit: Add dynamically-extending log

This patch chain changes the logging implementation to use string_stream so that the log will grow dynamically.

The first 8 patches add test code for string_stream, and make some changes to string_stream needed to be able to use it for the log.

The final patch adds a performance report of string_stream.

CHANGES SINCE V5:
Patch 2:
- Avoid cast warning when using KUNIT_EXPECT_EQ() on a gfp_t. Instead pass the result of the comparison to KUNIT_EXPECT_TRUE(). While it would be nice to use KUNIT_EXPECT_EQ(), it's probably better to avoid introducing build or sparse warnings.

- In string_stream_append_test() rename original_content to stream1_content_before_append.

Patch 7:
- Make string_stream_clear() public (in v5 this was done in patch #8).
- In string-stream-test.c add a wrapper for kfree() to prevent a cast warning when calling kunit_add_action().

Patch 8:
- Fix memory leak when calling the redirected string_stream_destroy_stub().

Patch 9:
- In kunit-test.c: add wrapper function around kfree() to prevent cast warning when calling kunit_add_action().
- Fix unused variable warning in kunit_log_test() when built as a module.

Richard Fitzgerald (10):
kunit: string-stream: Don't create a fragment for empty strings
kunit: string-stream: Improve testing of string_stream
kunit: string-stream: Add option to make all lines end with newline
kunit: string-stream-test: Add cases for string_stream newline
appending
kunit: Don't use a managed alloc in is_literal()
kunit: string-stream: Add kunit_alloc_string_stream()
kunit: string-stream: Decouple string_stream from kunit
kunit: string-stream: Add tests for freeing resource-managed
string_stream
kunit: Use string_stream for test log
kunit: string-stream: Test performance of string_stream

 include/kunit/test.h           |  14 +-
 lib/kunit/assert.c             |  14 +-
 lib/kunit/debugfs.c            |  36 ++-
 lib/kunit/kunit-test.c         |  56 +++-
 lib/kunit/string-stream-test.c | 525 +++++++++++++++++++++++++++++++--
 lib/kunit/string-stream.c      | 100 +++++--
 lib/kunit/string-stream.h      |  16 +-
 lib/kunit/test.c               |  50 +---
 8 files changed, 688 insertions(+), 123 deletions(-)
Signature · 1 line
2.30.2