drm/panel: Remove most store/double-check of prepared/enabled state
Status from this message: Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest24 patches 2 repliesApplied
- v248 patches 26 repliesSuperseded
- v1 RFC10 patches 23 repliesSuperseded
Changes in v3 from the cover letter
- drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdown
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/24 | drm/panel: boe-himax8279d: Stop tracking prepared/enableddrivers/ | +4 | 0 replies | |
| 2/24 | drm/panel: boe-himax8279d: Don't call unprepare+disable at shutdown/removedrivers/ | +0 | 0 replies | |
| 3/24 | drm/panel: khadas-ts050: Stop tracking prepared/enableddrivers/ | +0 | 0 replies | |
| 4/24 | drm/panel: khadas-ts050: Don't call unprepare+disable at shutdown/removedrivers/ | +0 | 0 replies | |
| 5/24 | drm/panel: olimex-lcd-olinuxino: Stop tracking prepared/enableddrivers/ | +0 | 0 replies | |
| 6/24 | drm/panel: olimex-lcd-olinuxino: Don't call unprepare+disable at removedrivers/ | +0 | 0 replies | |
| 7/24 | drm/panel: osd-osd101t2587-53ts: Stop tracking prepared/enableddrivers/ | +1 | 0 replies | |
| 8/24 | drm/panel: osd-osd101t2587-53ts: Don't call unprepare+disable at shutdown/removedrivers/ | +0 | 0 replies | |
| 9/24 | drm/panel: tdo-tl070wsh30: Stop tracking prepareddrivers/ | +0 | 0 replies | |
| 10/24 | drm/panel: tdo-tl070wsh30: Don't call unprepare+disable at shutdown/removedrivers/ | +0 | 0 replies | |
| 11/24 | drm/panel: jdi-lt070me05000: Stop tracking prepared/enableddrivers/ | +2 | 0 replies | |
| 12/24 | drm/panel: jdi-lt070me05000: Don't call disable at shutdown/removedrivers/ | +0 | 0 replies | |
| 13/24 | drm/panel: panasonic-vvx10f034n00: Stop tracking prepared/enableddrivers/ | +1 | 0 replies | |
| 14/24 | drm/panel: panasonic-vvx10f034n00: Don't call disable at shutdown/removedrivers/ | +0 | 0 replies | |
| 15/24 | drm/panel: seiko-43wvf1g: Stop tracking prepared/enableddrivers/ | +0 | 0 replies | |
| 16/24 | drm/panel: seiko-43wvf1g: Don't call disable at shutdown/removedrivers/ | +0 | 0 replies | |
| 17/24 | drm/panel: sharp-lq101r1sx01: Stop tracking prepared/enableddrivers/ | +0 | 0 replies | |
| 18/24 | drm/panel: sharp-lq101r1sx01: Don't call disable at shutdown/removedrivers/ | +2 | 0 replies | |
| 19/24 | drm/panel: sharp-ls043t1le01: Stop tracking prepareddrivers/ | +0 | 0 replies | |
| 20/24 | drm/panel: sharp-ls043t1le01: Don't call disable at shutdown/removedrivers/ | +0 | 0 replies | |
| 21/24 | drm/panel: raydium-rm67191: Stop tracking enableddrivers/ | +2 | 0 replies | |
| 22/24 | drm/panel: raydium-rm67191: Don't call unprepare+disable at shutdowndrivers/ | +0 | 0 replies | |
| 23/24 | drm/panel: Update TODO list item for cleaning up prepared/enabled trackingDocumentation/ | +26 | 0 replies | |
| 24/24 | drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdowndrivers/ drivers/ drivers/ +1 more | +169 | 0 replies |
Reviews trailers per patch
23 of 24 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Linus Walleij | Maxime Ripard | Neil Armstrong |
|---|---|---|---|
| Series | R-b | ||
| 1/24 | A-b | A-b | |
| 2/24 | A-b | A-b | |
| 3/24 | A-b | A-b | |
| 4/24 | A-b | A-b | |
| 5/24 | A-b | A-b | |
| 6/24 | A-b | A-b | |
| 7/24 | A-b | A-b | |
| 8/24 | A-b | A-b | |
| 9/24 | A-b | A-b | |
| 10/24 | A-b | A-b | |
| 11/24 | A-b | A-b | |
| 12/24 | A-b | A-b | |
| 13/24 | A-b | A-b | |
| 14/24 | A-b | A-b | |
| 15/24 | A-b | A-b | |
| 16/24 | A-b | A-b | |
| 17/24 | A-b | A-b | |
| 18/24 | A-b | A-b | |
| 19/24 | A-b | A-b | |
| 20/24 | A-b | A-b | |
| 21/24 | A-b | A-b | |
| 22/24 | A-b | A-b | |
| 23/24 | A-b | A-b | |
| 24/24 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v3 00/24] drm/panel: Remove most store/double-check of prepared/enabled state
As talked about in commit d2aacaf07395 ("drm/panel: Check for already prepared/enabled in drm_panel"), we want to remove needless code from panel drivers that was storing and double-checking the prepared/enabled state. Even if someone was relying on the double-check before, that double-check is now in the core and not needed in individual drivers.
This series attempts to do just that. While the original grep, AKA:
git grep 'if.*>prepared' -- drivers/gpu/drm/panel
git grep 'if.*>enabled' -- drivers/gpu/drm/panel
...still produces a few hits after my series, they are _mostly_ all gone. The ones that are left are less trivial to fix.
One of the main reasons that many panels probably needed to store and double-check their prepared/enabled appears to have been to handle shutdown and/or remove. Panels drivers often wanted to force the power off for panels in these cases and this was a good reason for the double-check.
In response to my V1 series [1] we had much discussion of what to do. The conclusion was that as long as DRM modeset drivers properly called drm_atomic_helper_shutdown() that we should be able to remove the explicit shutdown/remove handling in the panel drivers. Most of the patches to improve DRM modeset drivers [2] [3] [4] have now landed.
In contrast to my V1 series, I broke the V2 series up a lot more. Since a few of the panel drivers in V1 already landed, we had fewer total drivers and so we could devote a patch to each panel. Also, since we were now relying on DRM modeset drivers I felt like we should split the patches for each panel into two: one that's definitely safe and one that could be reverted if we found a problematic DRM modeset driver that we couldn't fix.
Many of the patches in the V2 series [5] landed, so this V3 series is the patches that are left plus one new bonus patch. At this point, we may want to just land the patches that are left since it seems like nobody is going to test/review them and they've all been Acked by Linus and Maxime.
NOTE: this touches _a lot_ of drivers, is repetitive, and is not really possible to generate automatically. That means it's entirely possible that my eyes glazed over and I did something wrong. Please double-check me and don't assume that I got everything perfect, though I did my best. I have at least confirmed that "allmodconfig" for arm64 doesn't fall on its face with this series. I haven't done a ton of other testing.
[1] https://lore.kernel.org/r/20230804140605.RFC.4.I930069a32baab6faf46d6b234f89613b5cec0f14@changeid
[2] https://lore.kernel.org/r/[email protected]
[3] https://lore.kernel.org/r/[email protected]
[4] https://lore.kernel.org/r/[email protected]
[5] https://lore.kernel.org/r/[email protected]/
Changes in v3:
- drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdown
Changes in v2:
- Only handle 1 panel per patch.
- Split removal of prepared/enabled from handling of remove/shutdown.
Douglas Anderson (24):
drm/panel: boe-himax8279d: Stop tracking prepared/enabled drm/panel: boe-himax8279d: Don't call unprepare+disable at
shutdown/remove
drm/panel: khadas-ts050: Stop tracking prepared/enabled drm/panel: khadas-ts050: Don't call unprepare+disable at
shutdown/remove
drm/panel: olimex-lcd-olinuxino: Stop tracking prepared/enabled drm/panel: olimex-lcd-olinuxino: Don't call unprepare+disable at
remove
drm/panel: osd-osd101t2587-53ts: Stop tracking prepared/enabled drm/panel: osd-osd101t2587-53ts: Don't call unprepare+disable at
shutdown/remove
drm/panel: tdo-tl070wsh30: Stop tracking prepared drm/panel: tdo-tl070wsh30: Don't call unprepare+disable at
shutdown/remove
drm/panel: jdi-lt070me05000: Stop tracking prepared/enabled drm/panel: jdi-lt070me05000: Don't call disable at shutdown/remove drm/panel: panasonic-vvx10f034n00: Stop tracking prepared/enabled drm/panel: panasonic-vvx10f034n00: Don't call disable at
shutdown/remove
drm/panel: seiko-43wvf1g: Stop tracking prepared/enabled drm/panel: seiko-43wvf1g: Don't call disable at shutdown/remove drm/panel: sharp-lq101r1sx01: Stop tracking prepared/enabled drm/panel: sharp-lq101r1sx01: Don't call disable at shutdown/remove drm/panel: sharp-ls043t1le01: Stop tracking prepared drm/panel: sharp-ls043t1le01: Don't call disable at shutdown/remove drm/panel: raydium-rm67191: Stop tracking enabled drm/panel: raydium-rm67191: Don't call unprepare+disable at shutdown drm/panel: Update TODO list item for cleaning up prepared/enabled
tracking
drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdown
Documentation/gpu/todo.rst | 47 +++--- drivers/gpu/drm/drm_panel.c | 12 ++ drivers/gpu/drm/panel/panel-boe-himax8279d.c | 40 ----- .../gpu/drm/panel/panel-drm-shutdown-check.h | 151 ++++++++++++++++++ drivers/gpu/drm/panel/panel-edp.c | 19 +-- .../gpu/drm/panel/panel-jdi-lt070me05000.c | 35 ---- drivers/gpu/drm/panel/panel-khadas-ts050.c | 39 ----- .../drm/panel/panel-olimex-lcd-olinuxino.c | 44 ----- .../drm/panel/panel-osd-osd101t2587-53ts.c | 41 +---- .../drm/panel/panel-panasonic-vvx10f034n00.c | 47 +----- drivers/gpu/drm/panel/panel-raydium-rm67191.c | 26 --- drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 49 ------ .../gpu/drm/panel/panel-sharp-lq101r1sx01.c | 63 +------- .../gpu/drm/panel/panel-sharp-ls043t1le01.c | 24 --- drivers/gpu/drm/panel/panel-simple.c | 19 +-- drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c | 23 --- 16 files changed, 199 insertions(+), 480 deletions(-) create mode 100644 drivers/gpu/drm/panel/panel-drm-shutdown-check.h
Signature · 1 line
2.45.1.288.g0e0cd299f1-goog