Skip to content

Populate kaslr seed with RNG

[email protected] u-boot 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest5 patches 9 repliesIn review
  2. v45 patches 6 repliesSuperseded
  3. v35 patches 6 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v2 posting 2/24 patches6 repliesSuperseded
v2 posting 1/24 patches0 repliesSuperseded
v13 patches13 repliesSuperseded

Changes in v5 from the cover letter

- Always enable OFNODE_MULTI_TREE
- include dm/ofnode-decl.h instead of dm/ofnode.h
- cast buffer to (u8 *) in kaslrseed.c

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5fdt: common API to populate kaslr seedarch/arm/cpu/armv8/sec_firmware.c boot/fdt_support.c drivers/core/ofnode.c +2 more+71 -251 reply
2/5fdt: kaslr seed from RNG deviceboot/fdt_support.c lib/Kconfig+43 -05 replies
3/5cmd: kaslrseed: Use common API to fixup FDTcmd/kaslrseed.c+8 -141 reply
4/5dm: core: Modify default for OFNODE_MULTI_TREEdrivers/core/Kconfig+2 -11 reply
5/5fdt: Fix compile error for !OFNODE_MULTI_TREEdrivers/core/ofnode.c+6 -61 reply

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchSimon GlassIlias Apalodimas
1/5
2/5R-b R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/5] Populate kaslr seed with RNG

From: Sean Edmond <[email protected]>

This patch series creates a common API (fdt_fixup_kaslr_seed()) for populating the kaslr seed in the DTB. Existing users (kaslrseed, and ARMv8 sec firmware) have been updated to use this common API.

New functionality has been introduced to populate the kaslr using the RNG. This can be enabled with CONFIG_RNG_TPM_SEED.

changes in v5:
- Always enable OFNODE_MULTI_TREE
- include dm/ofnode-decl.h instead of dm/ofnode.h
- cast buffer to (u8 *) in kaslrseed.c

changes in v4:
- Fix compile issue when CONFIG_OF_CONTROL not set

changes in v3:
- Populate with RNG device instead of TPM device (this is a more generic solution)
- Use event spy to do the FDT fixup
- fix compile error for sandbox for !OFNODE_MULTI_TREE

changes in v2:
- fdt_fixup_kaslr_seed() uses the ofnode API
- Add root_ofnode_from_fdt() to get the root node from an FDT and perform error checking on the oftree
- add comments to exported functions
- Add error checking in image_setup_libfdt() for return from fdt_tpm_kaslr_seed()
- uclass_get_device() -> uclass_first_device_err()
- Change default config for OFNODE_MULTI_TREE (y if !OF_LIVE)

Dhananjay Phadke (2):
fdt: common API to populate kaslr seed
fdt: kaslr seed from RNG device

Sean Edmond (3):
cmd: kaslrseed: Use common API to fixup FDT
dm: core: Modify default for OFNODE_MULTI_TREE
fdt: Fix compile error for !OFNODE_MULTI_TREE

 arch/arm/cpu/armv8/sec_firmware.c | 39 ++++++++--------------
 boot/fdt_support.c                | 55 +++++++++++++++++++++++++++++++
 cmd/kaslrseed.c                   | 22 +++++--------
 drivers/core/Kconfig              |  3 +-
 drivers/core/ofnode.c             | 29 ++++++++++++----
 include/dm/ofnode.h               | 12 +++++++
 include/fdt_support.h             |  9 +++++
 lib/Kconfig                       |  7 ++++
 8 files changed, 130 insertions(+), 46 deletions(-)
Signature · 1 line
2.42.0