Skip to content

target/s390x: Fix the "ignored match" case in VSTRS

Ilya Leoshkevich qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3linux-user/elfload: Enable vxe2 on s390xlinux-user/elfload.c+1 -03 replies
2/3target/s390x: Fix the "ignored match" case in VSTRStarget/s390x/tcg/vec_string_helper.c+17 -374 replies
3/3tests/tcg/s390x: Test VSTRStests/tcg/s390x/Makefile.target tests/tcg/s390x/vxeh2_vstrs.c+89 -05 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchRichard HendersonDavid HildenbrandClaudio Fontana
1/3R-b R-b R-b
2/3A-b T-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/3] target/s390x: Fix the "ignored match" case in VSTRS

Hi,

this series should hopefully fix the issue with __strstr_arch13(), which Claudio reported. I have to admit I did not manage to fully reproduce it, but at least with this change the traces of a simple test from TCG and real hardware match.

I've also fuzzed the changed helper and strstr() itself; not sure whether anything generic may come out of it, but here are the links anyway [1] [2].

Patch 1 makes glibc pick __strstr_arch13() in qemu-user, patch 2 is the fix and patch 3 is the test (generated from Claudio's strings and further fuzzer's findings).

[1] https://gist.github.com/iii-i/5adad06d911c46079d4388001b22ab61
[2] https://gist.github.com/iii-i/c425800e75796eae65660491ac511356

Ilya Leoshkevich (3):
linux-user/elfload: Enable vxe2 on s390x target/s390x: Fix the "ignored match" case in VSTRS tests/tcg/s390x: Test VSTRS

 linux-user/elfload.c                 |  1 +
 target/s390x/tcg/vec_string_helper.c | 54 ++++++-----------
 tests/tcg/s390x/Makefile.target      |  1 +
 tests/tcg/s390x/vxeh2_vstrs.c        | 88 ++++++++++++++++++++++++++++
 4 files changed, 107 insertions(+), 37 deletions(-)
 create mode 100644 tests/tcg/s390x/vxeh2_vstrs.c
Signature · 1 line
2.41.0