Skip to content

fbdev/sbus: Initializers for struct fb_ops

Thomas Zimmermann dri-devel linux-fbdev sparclinux 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11fbdev/sbus: Build sbuslib.o if CONFIG_FB_SBUS has been selecteddrivers/video/fbdev/Makefile+9 -80 replies
2/11fbdev/sbus: Forward declare all necessary structures in headerdrivers/video/fbdev/sbuslib.h+5 -10 replies
3/11fbdev/sbus: Add initializer macros and Kconfig tokens for SBUS supportdrivers/video/fbdev/Kconfig drivers/video/fbdev/sbuslib.h+37 -00 replies
4/11fbdev/bw2: Use initializer macro for struct fb_opsdrivers/video/fbdev/Kconfig drivers/video/fbdev/bw2.c+6 -150 replies
5/11fbdev/cg14: Use initializer macro for struct fb_opsdrivers/video/fbdev/Kconfig drivers/video/fbdev/cg14.c+7 -160 replies
6/11fbdev/cg3: Use initializer macro for struct fb_opsdrivers/video/fbdev/Kconfig drivers/video/fbdev/cg3.c+6 -150 replies
7/11fbdev/cg6: Use initializer macro for struct fb_opsdrivers/video/fbdev/cg6.c+8 -90 replies
8/11fbdev/ffb: Use initializer macro for struct fb_opsdrivers/video/fbdev/ffb.c+8 -90 replies
9/11fbdev/leo: Use initializer macro for struct fb_opsdrivers/video/fbdev/Kconfig drivers/video/fbdev/leo.c+7 -160 replies
10/11fbdev/p9100: Use initializer macro for struct fb_opsdrivers/video/fbdev/Kconfig drivers/video/fbdev/p9100.c+6 -160 replies
11/11fbdev/tcx: Use initializer macro for struct fb_opsdrivers/video/fbdev/Kconfig drivers/video/fbdev/tcx.c+7 -170 replies

Reviews trailers per patch

None of the 11 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSam Ravnborg
SeriesR-b
1/11
2/11
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] fbdev/sbus: Initializers for struct fb_ops

Add initializer macros for struct fb_ops of drivers that operate on SBUS-based framebuffers. Also add a Kconfig token to select the correct dependencies.

All drivers for SBUS-based framebuffers use the regular helpers for framebuffers in I/O memory (fb_io_*() and cfb_*()). Each driver provides its own implementation of mmap and ioctls around common helpers from sbuslib.o. Patches 1 to 3 clean up the code a bit and add a initializer macros that set up struct fb_ops correctly.

Patches 4 to 11 convert the drivers. Each patch slightly renames the driver's mmap and ioctl functions so that it matches the name pattern of sbuslib.o.

Like the other fbdev initializer macros, the SBUS helpers are easily grep-able. In a later patch, they can be left to empty values if the rsp. functionality, such as file I/O or console, has been disabled.

There are no functional changes. The helpers set the defaults that the drivers already use. The fb_io_*() functions that the initializer macro sets are the defaults if struct fb_ops.fb_read or .fb_write are NULL. After all drivers have been updated to set them explicitly, the defaults can be dropped and the functions can be made optional.

Build-tested on sparc64.

Thomas Zimmermann (11):
fbdev/sbus: Build sbuslib.o if CONFIG_FB_SBUS has been selected fbdev/sbus: Forward declare all necessary structures in header fbdev/sbus: Add initializer macros and Kconfig tokens for SBUS support fbdev/bw2: Use initializer macro for struct fb_ops fbdev/cg14: Use initializer macro for struct fb_ops fbdev/cg3: Use initializer macro for struct fb_ops fbdev/cg6: Use initializer macro for struct fb_ops fbdev/ffb: Use initializer macro for struct fb_ops fbdev/leo: Use initializer macro for struct fb_ops fbdev/p9100: Use initializer macro for struct fb_ops fbdev/tcx: Use initializer macro for struct fb_ops

 drivers/video/fbdev/Kconfig   | 30 ++++++++++++----------------
 drivers/video/fbdev/Makefile  | 17 ++++++++--------
 drivers/video/fbdev/bw2.c     | 17 +++++-----------
 drivers/video/fbdev/cg14.c    | 19 ++++++------------
 drivers/video/fbdev/cg3.c     | 17 +++++-----------
 drivers/video/fbdev/cg6.c     | 17 ++++++++--------
 drivers/video/fbdev/ffb.c     | 17 ++++++++--------
 drivers/video/fbdev/leo.c     | 19 ++++++------------
 drivers/video/fbdev/p9100.c   | 18 +++++------------
 drivers/video/fbdev/sbuslib.h | 37 ++++++++++++++++++++++++++++++++++-
 drivers/video/fbdev/tcx.c     | 20 ++++++-------------
 11 files changed, 106 insertions(+), 122 deletions(-)
Signature · 1 line
2.41.0