Skip to content

softmmu/physmem: file_ram_open() readonly improvements

David Hildenbrand qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 46 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3softmmu/physmem: fallback to opening guest RAM file as readonly in a MAP_PRIVATE mappingsoftmmu/physmem.c+18 -843 replies
2/3softmmu/physmem: fail creation of new files in file_ram_open() with readonly=truesoftmmu/physmem.c+7 -00 replies
3/3softmmu/physmem: never return directories from file_ram_open()softmmu/physmem.c+19 -00 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchThiner Logoer
SeriesT-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v1 0/3] softmmu/physmem: file_ram_open() readonly improvements

Patch #1 is the result of the discussion of:
"[PATCH v2] softmmu/physmem: try opening file readonly before failure
in file_ram_open" [1]

Instead of handling it inside file_ram_open(), handle it in the caller and only fallback to readonly in a MAP_PRIVATE mapping.

Patch #2 refuses to create readonly files instead of creating a new file and opening it writable. Patch #3 no longer returns directories from file_ram_open(), resulting in a better error message when trying to open a readonly file but specifying a directory.

[1] https://lkml.kernel.org/r/[email protected]

Cc Paolo Bonzini <[email protected]>
Cc Peter Xu <[email protected]>
Cc Igor Mammedov <[email protected]>
Cc Thiner Logoer <[email protected]>
Cc "Philippe Mathieu-Daudé" <[email protected]>

David Hildenbrand (2):
softmmu/physmem: fail creation of new files in file_ram_open() with
readonly=true
softmmu/physmem: never return directories from file_ram_open()

Thiner Logoer (1):
softmmu/physmem: fallback to opening guest RAM file as readonly in a
MAP_PRIVATE mapping

 softmmu/physmem.c | 52 +++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 44 insertions(+), 8 deletions(-)
Signature · 1 line
2.41.0