Skip to content

ppc: debug facility improvements

Nicholas Piggin qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6target/ppc: Remove single-step suppression inside 0x100-0xf00target/ppc/translate.c+1 -20 replies
2/6target/ppc: Improve book3s branch trace interrupt for v2.07Starget/ppc/excp_helper.c target/ppc/helper.h target/ppc/translate.c+27 -110 replies
3/6target/ppc: Suppress single step interrupts on rfi-type instructionstarget/ppc/translate.c+17 -60 replies
4/6target/ppc: Implement breakpoint debug facility for v2.07Starget/ppc/cpu.c target/ppc/cpu.h target/ppc/cpu_init.c +7 more+98 -20 replies
5/6target/ppc: Implement watchpoint debug facility for v2.07Starget/ppc/cpu.c target/ppc/cpu.h target/ppc/cpu_init.c +7 more+147 -30 replies
6/6spapr: implement H_SET_MODE debug facilitieshw/ppc/spapr_hcall.c+57 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH for-8.2 0/6] ppc: debug facility improvements

I started out looking at this to reduce divergence of TCG and KVM machines with 2nd DAWR. The divergence already exists with first DAWR, so I don't want to tie the KVM 2nd DAWR enablement to this, but it would be nice to ensure the caps and such for the 2nd DAWR will also work for TCG.

I don't know that we have great test cases for this, it does work with some of the Linux selftests ptrace debug tests (although those tests seem to have a few issues in upstream kernels), some basic Linux xmon and gdb tests by hand, and I've started working on some kvm unit tests.

Thanks,
Nick

Nicholas Piggin (6):
target/ppc: Remove single-step suppression inside 0x100-0xf00 target/ppc: Improve book3s branch trace interrupt for v2.07S target/ppc: Suppress single step interrupts on rfi-type instructions target/ppc: Implement breakpoint debug facility for v2.07S target/ppc: Implement watchpoint debug facility for v2.07S
spapr: implement H_SET_MODE debug facilities

 hw/ppc/spapr_hcall.c     |  57 +++++++++++++++++++++
 target/ppc/cpu.c         |  86 +++++++++++++++++++++++++++++++
 target/ppc/cpu.h         |   7 +++
 target/ppc/cpu_init.c    |  11 ++--
 target/ppc/excp_helper.c | 108 ++++++++++++++++++++++++++++++++++++++-
 target/ppc/helper.h      |   4 ++
 target/ppc/internal.h    |   3 ++
 target/ppc/machine.c     |   5 ++
 target/ppc/misc_helper.c |  15 ++++++
 target/ppc/spr_common.h  |   3 ++
 target/ppc/translate.c   |  60 +++++++++++++++++-----
 11 files changed, 341 insertions(+), 18 deletions(-)
Signature · 1 line
2.40.1