Skip to content

Add tests for solid fill planes

Jessica Zhang igt-dev 3 versions – In review

Get series with b4
b4 am [email protected] change-id 20230810-solid-fill-5acd9b2d42fc

Versions newest first

  1. v3 Latest5 patches 4 repliesIn review
  2. v26 patches 8 repliesSuperseded
  3. v14 patches 13 repliesSuperseded

Changes in v3 from the cover letter

- Reset solid_fill and pixel_source properties in igt_display_reset() (Bhanu)
- Added check for Cairo fb float->u8 conversion (Pekka)
- Dropped drm-uapi header update
- Link to v2: https://lore.kernel.org/r/[email protected]

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5tests/kms_atomic: Free pipe_crc objecttests/kms_atomic.c+2 -00 replies
2/5drm-uapi: Add drm_mode_solid_fillinclude/drm-uapi/drm_mode.h+24 -00 replies
3/5lib: Add support for solid_fill and pixel_source plane propertieslib/igt_kms.c lib/igt_kms.h+49 -32 replies
4/5tests/kms_atomic: Add solid fill plane subtesttests/kms_atomic.c+191 -182 replies
5/5tests/kms_atomic: Add subtest for solid fill cursor planestests/kms_atomic.c+31 -40 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchPekka Paalanen
1/5
2/5A-b
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH i-g-t v3 0/5] Add tests for solid fill planes

Add corresponding IGT tests for solid fill planes [1] in kms_atomic.

This series does the following:
- Fix a dangling pipe_crc_t object in the plane_immutable_zpos test
- Add solid_fill and pixel_source to IGT plane property enum
- Add solid fill drm-uapi struct
- Change IGT commit behavior to support solid fill planes
- Add dynamic subtests for solid fill planes in kms_atomic

[1] https://patchwork.freedesktop.org/series/110283/

---
Changes in v3:
- Reset solid_fill and pixel_source properties in igt_display_reset() (Bhanu)
- Added check for Cairo fb float->u8 conversion (Pekka)
- Dropped drm-uapi header update
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Updated drm-uapi headers
- Added documentation for new igt_kms public function (Kamil)
- Added documentation for new kms_atomic subtests (Kamil)
- Dropped stray newline (Kamil)
- Use pre-existing helpers to calculate rect height and width
- Add more test cases (Pekka)
- Fixed incorrect UNORM values (Pekka)

---
Jessica Zhang (5):
tests/kms_atomic: Free pipe_crc object
drm-uapi: Add drm_mode_solid_fill
lib: Add support for solid_fill and pixel_source plane properties tests/kms_atomic: Add solid fill plane subtest tests/kms_atomic: Add subtest for solid fill cursor planes

 include/drm-uapi/drm_mode.h |  24 +++++
 lib/igt_kms.c               |  48 ++++++++-
 lib/igt_kms.h               |   4 +
 tests/kms_atomic.c          | 238 ++++++++++++++++++++++++++++++++++++++++----
 4 files changed, 293 insertions(+), 21 deletions(-)

---
base-commit: 40ed74461d8a44657a0f4799ade86116722d3ea2
change-id: 20230810-solid-fill-5acd9b2d42fc

Best regards,

Signature · 1 line
Jessica Zhang <[email protected]>