Skip to content

cifs: Release folio lock on fscache read hit.

Russell Harmon linux-cifs 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1cifs: Release folio lock on fscache read hit.fs/smb/client/file.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 0/1] cifs: Release folio lock on fscache read hit.

Here's a patch that fixes what seems to be a showstopping bug in cifs-fscache. *Any time* that a fscache read hit occurs on a mounted cifs filesystem (and therefore cifs_readpage_worker is called), the page lock on the read page is leaked, causing subsequent accesses to the page to deadlock.

I've been running my machine for the past week with this change and it seems to work, but I'm a little concerned that this may mean cifs-fscache has no users (besides me). Up to you (maintainers) whether that means you should accept this patch... or delete the fscache support.

Russell Harmon (1):
cifs: Release folio lock on fscache read hit.

 fs/smb/client/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.34.1