Skip to content

-Wmissing-prototype warning fixes

Arnd Bergmann linux-alpha linux-arm-kernel linux-block linux-csky linux-hexagon linux-ia64 linux-kbuild linux-m68k linux-mips linux-mtd linux-next linux-parisc linux-pci linux-riscv linux-s390 linux-scsi linux-sh linux-snps-arc linux-trace-kernel linuxppc-dev lkml loongarch openrisc sparclinux 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 34 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/17jffs2: mark __jffs2_dbg_superblock_counts() staticfs/jffs2/debug.c+1 -10 replies
2/17irq_work: consolidate arch_irq_work_raise prototypesarch/arm/include/asm/irq_work.h arch/arm64/include/asm/irq_work.h arch/csky/include/asm/irq_work.h +5 more+5 -102 replies
3/17ida: make 'ida_dump' staticlib/test_ida.c+1 -10 replies
4/17pci: sysfs: move declarations to linux/pci.harch/alpha/include/asm/pci.h include/linux/pci.h+5 -31 reply
5/17swim3: mark swim3_init() staticdrivers/block/swim3.c+1 -12 replies
6/17macintosh/ams: mark ams_init() staticdrivers/macintosh/ams/ams-core.c+1 -11 reply
7/17scsi: qlogicpti: mark qlogicpti_info() staticdrivers/scsi/qlogicpti.c+1 -12 replies
8/17microblaze: mark flush_dcache_folio() inlinearch/microblaze/include/asm/cacheflush.h+1 -11 reply
9/17parport: gsc: mark init function staticdrivers/parport/parport_gsc.c+1 -12 replies
10/17zorro: include zorro.h in names.cdrivers/zorro/names.c+1 -01 reply
11/17scsi: gvp11: remove unused gvp11_setup() functiondrivers/scsi/gvp11.c+0 -52 replies
12/17time: make sysfs_get_uname() function visible in headerkernel/time/tick-internal.h+2 -10 replies
13/17stackleak: add declarations for global functionsinclude/linux/stackleak.h+6 -00 replies
14/17kprobes: unify kprobes_exceptions_nofify() prototypesarch/arc/include/asm/kprobes.h arch/arm/include/asm/kprobes.h arch/arm64/include/asm/kprobes.h +8 more+4 -211 reply
15/17arch: fix asm-offsets.c building with -Wmissing-prototypesarch/alpha/kernel/asm-offsets.c arch/ia64/kernel/asm-offsets.c arch/loongarch/kernel/asm-offsets.c +1 more+16 -132 replies
16/17arch: turn -Wmissing-prototypes off conditionallyarch/alpha/Kbuild arch/alpha/lib/Makefile arch/arc/Kbuild +23 more+52 -18 replies
17/17Makefile.extrawarn: turn on missing-prototypes againscripts/Makefile.extrawarn+3 -21 reply

Reviews trailers per patch

11 of 17 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchTudor AmbarusCatalin MarinasPalmer DabbeltGuo RenAlexander GordeevJack WangHelge DellerChristophe LeroyKees CookMasami Hiramatsu (Google)Geert UytterhoevenMichal SimekSudip Mukherjee
SeriesA-b
1/17R-b
2/17A-b A-b A-b R-b
3/17
4/17
5/17R-b
6/17R-b
7/17R-b
8/17A-b
9/17A-b A-b
10/17R-b
11/17R-b
12/17
13/17
14/17A-b
15/17
16/17
17/17R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 13 reviewers.

Read the v1 thread

Cover letter [PATCH 00/17] -Wmissing-prototype warning fixes

From: Arnd Bergmann <[email protected]>

Most of the patches I sent so far for the -Wmissing-prototype warnings have made it into linux-next now. There are a few that I'm resending now as nobody has picked them up, and then a number of fixes that I found while test-building across all architectures rather than just the ones I usually test.

The first 15 patches in this series should be uncontroversial, so I expect that either a subsystem maintainer or Andrew Morton can apply these directly.

For the last two patches, these might still need some debate about how to handle them. I added a Kconfig option to turn off most of the missing prototype warnings in the architectures that nobody has fixed yet, see patch 16 for those. The last patch does cause some known warnings and likely unknown ones for architectures other than x86 and arm, so applying it now will bring new problems, but not applying it also means that new warnings creep in, so I think this is mainly a question of what the best timing is for having this in linux-next.

Arnd Bergmann (17):
[RESEND] jffs2: mark __jffs2_dbg_superblock_counts() static [RESEND] irq_work: consolidate arch_irq_work_raise prototypes [RESEND] ida: make 'ida_dump' static
pci: sysfs: move declarations to linux/pci.h
swim3: mark swim3_init() static
macintosh/ams: mark ams_init() static
scsi: qlogicpti: mark qlogicpti_info() static
microblaze: mark flush_dcache_folio() inline
parport: gsc: mark init function static
zorro: include zorro.h in names.c
scsi: gvp11: remove unused gvp11_setup() function
time: make sysfs_get_uname() function visible in header
stackleak: add declarations for global functions
kprobes: unify kprobes_exceptions_nofify() prototypes
arch: fix asm-offsets.c building with -Wmissing-prototypes [RFC] arch: turn -Wmissing-prototypes off conditionally [RFC] Makefile.extrawarn: turn on missing-prototypes again

 arch/alpha/Kbuild                        |  2 ++
 arch/alpha/include/asm/pci.h             |  3 ---
 arch/alpha/kernel/asm-offsets.c          |  2 +-
 arch/alpha/lib/Makefile                  |  1 +
 arch/arc/Kbuild                          |  2 ++
 arch/arc/include/asm/kprobes.h           |  3 ---
 arch/arm/include/asm/irq_work.h          |  2 --
 arch/arm/include/asm/kprobes.h           |  2 --
 arch/arm64/include/asm/irq_work.h        |  2 --
 arch/arm64/include/asm/kprobes.h         |  2 --
 arch/csky/Kbuild                         |  2 ++
 arch/csky/include/asm/irq_work.h         |  2 +-
 arch/hexagon/Kbuild                      |  2 ++
 arch/ia64/Kbuild                         |  2 ++
 arch/ia64/include/asm/kprobes.h          |  2 --
 arch/ia64/kernel/asm-offsets.c           |  2 +-
 arch/ia64/lib/Makefile                   |  1 +
 arch/loongarch/Kbuild                    |  2 ++
 arch/loongarch/kernel/asm-offsets.c      | 12 ++++++++++++
 arch/m68k/Kbuild                         |  2 ++
 arch/m68k/lib/Makefile                   |  1 +
 arch/microblaze/Kbuild                   |  2 ++
 arch/microblaze/include/asm/cacheflush.h |  2 +-
 arch/mips/Kbuild                         |  2 ++
 arch/mips/boot/compressed/Makefile       |  3 ++-
 arch/mips/include/asm/kprobes.h          |  2 --
 arch/nios2/Kbuild                        |  2 ++
 arch/nios2/lib/Makefile                  |  1 +
 arch/openrisc/Kbuild                     |  2 ++
 arch/parisc/Kbuild                       |  2 ++
 arch/parisc/lib/Makefile                 |  1 +
 arch/powerpc/include/asm/irq_work.h      |  1 -
 arch/powerpc/include/asm/kprobes.h       |  2 --
 arch/riscv/include/asm/irq_work.h        |  2 +-
 arch/s390/include/asm/irq_work.h         |  2 --
 arch/s390/include/asm/kprobes.h          |  2 --
 arch/sh/Kbuild                           |  2 ++
 arch/sh/boot/compressed/Makefile         |  1 +
 arch/sh/include/asm/kprobes.h            |  2 --
 arch/sparc/Kbuild                        |  2 ++
 arch/sparc/include/asm/kprobes.h         |  2 --
 arch/sparc/kernel/asm-offsets.c          | 13 ++-----------
 arch/sparc/lib/Makefile                  |  1 +
 arch/sparc/prom/Makefile                 |  1 +
 arch/x86/include/asm/irq_work.h          |  1 -
 arch/x86/include/asm/kprobes.h           |  2 --
 arch/xtensa/Kbuild                       |  2 ++
 arch/xtensa/boot/lib/Makefile            |  2 ++
 drivers/block/swim3.c                    |  2 +-
 drivers/macintosh/ams/ams-core.c         |  2 +-
 drivers/parport/parport_gsc.c            |  2 +-
 drivers/scsi/gvp11.c                     |  5 -----
 drivers/scsi/qlogicpti.c                 |  2 +-
 drivers/zorro/names.c                    |  1 +
 fs/jffs2/debug.c                         |  2 +-
 include/linux/irq_work.h                 |  3 +++
 include/linux/kprobes.h                  |  4 ++++
 include/linux/pci.h                      |  5 +++++
 include/linux/stackleak.h                |  6 ++++++
 init/Kconfig                             | 10 ++++++++++
 kernel/time/tick-internal.h              |  3 ++-
 lib/test_ida.c                           |  2 +-
 scripts/Makefile.extrawarn               |  5 +++--
 63 files changed, 101 insertions(+), 63 deletions(-)
Signature · 63 lines
2.39.2
Cc: Matt Turner <[email protected]>
Cc: Vineet Gupta <[email protected]>
Cc: Russell King <[email protected]>
Cc: Catalin Marinas <[email protected]>
Cc: Will Deacon <[email protected]>
Cc: Guo Ren <[email protected]>
Cc: Brian Cain <[email protected]>
Cc: Huacai Chen <[email protected]>
Cc: WANG Xuerui <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Michal Simek <[email protected]>
Cc: Thomas Bogendoerfer <[email protected]>
Cc: Dinh Nguyen <[email protected]>
Cc: Jonas Bonn <[email protected]>
Cc: Stefan Kristiansson <[email protected]>
Cc: Stafford Horne <[email protected]>
Cc: "James E.J. Bottomley" <[email protected]>
Cc: Helge Deller <[email protected]>
Cc: Michael Ellerman <[email protected]>
Cc: Christophe Leroy <[email protected]>
Cc: Palmer Dabbelt <[email protected]>
Cc: Heiko Carstens <[email protected]>
Cc: John Paul Adrian Glaubitz <[email protected]>
Cc: [email protected]
Cc: Borislav Petkov <[email protected]>
Cc: Max Filippov <[email protected]>
Cc: Jens Axboe <[email protected]>
Cc: Sudip Mukherjee <[email protected]>
Cc: "Martin K. Petersen" <[email protected]>
Cc: Richard Weinberger <[email protected]>
Cc: Bjorn Helgaas <[email protected]>
Cc: Masahiro Yamada <[email protected]>
Cc: Nathan Chancellor <[email protected]>
Cc: Nick Desaulniers <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: Stephen Rothwell <[email protected]>
Cc: [email protected]
Cc: Andrew Morton <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]