x86/microcode: Cleanup and late loading enhancements
Status from this message: The following commit has been merged into the x86/microcode branch of tip:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest37 patches 11 repliesApplied
- v130 patches 22 repliesSuperseded
Changes in v2 from the cover letter
- Reordered the queue - Nikolay
- Fixed the bogus condition - Borislav
- Moved more structs and defines into the source - Arjan
- Consolidated the exported functions
- Cleaned up the core initialization
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/37 | x86/mm: Remove unused microcode.h includearch/ | +0 | 0 replies | |
| 2/37 | x86/microcode: Hide the config knobarch/ arch/ arch/ +2 more | +8 | 4 replies | |
| 3/37 | x86/microcode/intel: Move microcode functions out of cpu/intel.carch/ arch/ arch/ | +204 | 2 replies | |
| 4/37 | x86/microcode: Include vendor headers into microcode.harch/ arch/ arch/ +6 more | +7 | 0 replies | |
| 5/37 | x86/microcode: Make reload_early_microcode() staticarch/ arch/ | +1 | 0 replies | |
| 6/37 | x86/microcode/intel: Rename get_datasize() since its used externallyarch/ arch/ drivers/ | +11 | 0 replies | |
| 7/37 | x86/microcode: Move core specific defines to local headerarch/ arch/ arch/ +4 more | +223 | 0 replies | |
| 8/37 | x86/microcode/intel: Remove debug codearch/ | +0 | 0 replies | |
| 9/37 | x86/microcode/intel: Remove pointless mutexarch/ | +2 | 2 replies | |
| 10/37 | x86/microcode/intel: Rip out mixed stepping support for Intel CPUsarch/ arch/ arch/ +1 more | +36 | 0 replies | |
| 11/37 | x86/microcode/intel: Simplify scan_microcode()arch/ | +7 | 0 replies | |
| 12/37 | x86/microcode/intel: Simplify and rename generic_load_microcode()arch/ | +17 | 2 replies | |
| 13/37 | x86/microcode/intel: Cleanup code furtherarch/ | +33 | 0 replies | |
| 14/37 | x86/microcode/intel: Simplify early loadingarch/ arch/ arch/ | +86 | 0 replies | |
| 15/37 | x86/microcode/intel: Save the microcode only after a successful late-loadarch/ arch/ arch/ | +20 | 0 replies | |
| 16/37 | x86/microcode/intel: Switch to kvmalloc()arch/ | +32 | 0 replies | |
| 17/37 | x86/microcode/intel: Unify microcode apply() functionsarch/ | +36 | 0 replies | |
| 18/37 | x86/microcode/intel: Rework intel_cpu_collect_info()arch/ arch/ drivers/ | +17 | 0 replies | |
| 19/37 | x86/microcode/intel: Reuse intel_cpu_collect_info()arch/ | +1 | 0 replies | |
| 20/37 | x86/microcode/intel: Rework intel_find_matching_signature()arch/ arch/ drivers/ | +21 | 0 replies | |
| 21/37 | x86/microcode/amd: Read revision from hardware in collect_cpu_info_amd()arch/ | +2 | 0 replies | |
| 22/37 | x86/microcode: Remove pointless apply() invocationarch/ include/ | +6 | 0 replies | |
| 23/37 | x86/microcode: Get rid of the schedule work indirectionarch/ | +9 | 0 replies | |
| 24/37 | x86/microcode: Clean up mc_cpu_down_prep()arch/ | +1 | 0 replies | |
| 25/37 | x86/microcode: Handle "nosmt" correctlyarch/ arch/ arch/ +1 more | +44 | 0 replies | |
| 26/37 | x86/microcode: Clarify the late load logicarch/ | +17 | 1 reply | |
| 27/37 | x86/microcode: Sanitize __wait_for_cpus()arch/ | +17 | 0 replies | |
| 28/37 | x86/microcode: Add per CPU result statearch/ arch/ | +65 | 0 replies | |
| 29/37 | x86/microcode: Add per CPU control fieldarch/ | +18 | 0 replies | |
| 30/37 | x86/microcode: Provide new control functionsarch/ | +86 | 0 replies | |
| 31/37 | x86/microcode: Replace the all in one rendevouz handlerarch/ | +9 | 0 replies | |
| 32/37 | x86/microcode: Rendezvous and load in NMIarch/ arch/ arch/ +2 more | +57 | 0 replies | |
| 33/37 | x86/microcode: Protect against instrumentationarch/ | +84 | 0 replies | |
| 34/37 | x86/apic: Provide apic_force_nmi_on_cpu()arch/ arch/ arch/ +2 more | +17 | 0 replies | |
| 35/37 | x86/microcode: Handle "offline" CPUs correctlyarch/ arch/ arch/ +1 more | +113 | 0 replies | |
| 36/37 | x86/microcode: Prepare for minimal revision checkDocumentation/ arch/ arch/ +3 more | +58 | 0 replies | |
| 37/37 | x86/microcode/intel: Add a minimum required revision for late-loadsarch/ arch/ | +35 | 0 replies |
Reviews trailers per patch
1 of 37 patches has a Reviewed-by or Acked-by.
| Patch | Borislav Petkov | Thomas Gleixner | Nikolay Borisov |
|---|---|---|---|
| 1/37 | |||
| 2/37 | Requested-by | ||
| 3/37 | |||
| 4/37 | |||
| 5/37 | |||
| 6/37 | |||
| 7/37 | |||
| 8/37 | |||
| 9/37 | |||
| 10/37 | Originally-by | ||
| 11/37 | |||
| 12/37 | |||
| 13/37 | |||
| 14/37 | |||
| 15/37 | |||
| 16/37 | |||
| 17/37 | |||
| 18/37 | |||
| 19/37 | |||
| 20/37 | |||
| 21/37 | |||
| 22/37 | |||
| 23/37 | |||
| 24/37 | |||
| 25/37 | |||
| 26/37 | R-b | ||
| 27/37 | |||
| 28/37 | |||
| 29/37 | |||
| 30/37 | |||
| 31/37 | |||
| 32/37 | |||
| 33/37 | |||
| 34/37 | |||
| 35/37 | |||
| 36/37 | |||
| 37/37 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [patch V2 00/37] x86/microcode: Cleanup and late loading enhancements
This is a follow up on:
https://lore.kernel.org/lkml/[email protected]
Late microcode loading is desired by enterprise users. Late loading is problematic as it requires detailed knowledge about the change and an analysis whether this change modifies something which is already in use by the kernel. Large enterprise customers have engineering teams and access to deep technical vendor support. The regular admin does not have such resources, so the kernel has always tainted the kernel after late loading.
Intel recently added a new previously reserved field to the microcode header which contains the minimal microcode revision which must be running on the CPU to make the load safe. This field is 0 in all older microcode revisions, which the kernel assumes to be unsafe. Minimal revision checking can be enforced via Kconfig or kernel command line. It then refuses to load an unsafe revision. The default loads unsafe revisions like before and taints the kernel. If a safe revision is loaded the kernel is not tainted.
But that does not solve all other known problems with late loading:
- Late loading on current Intel CPUs is unsafe vs. NMI when hyperthreading is enabled. If a NMI hits the secondary sibling while the primary loads the microcode, the machine can crash.
- Soft offline SMT siblings which are playing dead with MWAIT can cause damage too when the microcode update modifies MWAIT. That's a realistic scenario in the context of 'nosmt' mitigations. :(
Neither the core code nor the Intel specific code handles any of this at all.
While trying to implement this, I stumbled over disfunctional, horribly complex and redundant code, which I decided to clean up first so the new functionality can be added on a clean slate.
So the series has several sections:
1) Cleanup core code, header files and Kconfig
2) Cleanup of the Intel specific code
3) Implementation of proper core control logic to handle the NMI safe requirements
4) Support for minimal revision check in the core and the Intel specific parts.
Thanks to Borislav for discussing this with me and helping out with testing. Thanks also to Ashok who contributed a few patches and helped with testing on the Intel side especially with the new minimal revision mechanism.
Changes vs. V1:
- Reordered the queue - Nikolay
- Fixed the bogus condition - Borislav
- Moved more structs and defines into the source - Arjan
- Consolidated the exported functions
- Cleaned up the core initialization
The series applies on:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/microcode
and is also available from git:
git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git ucode-v2
Thanks,
tglx
--- arch/x86/include/asm/microcode_amd.h | 56 - arch/x86/include/asm/microcode_intel.h | 88 -- b/Documentation/admin-guide/kernel-parameters.txt | 5 b/arch/x86/Kconfig | 63 - b/arch/x86/include/asm/apic.h | 5 b/arch/x86/include/asm/cpu.h | 20 b/arch/x86/include/asm/microcode.h | 160 +--- b/arch/x86/kernel/apic/apic_flat_64.c | 2 b/arch/x86/kernel/apic/ipi.c | 9 b/arch/x86/kernel/apic/x2apic_cluster.c | 1 b/arch/x86/kernel/apic/x2apic_phys.c | 1 b/arch/x86/kernel/cpu/common.c | 1 b/arch/x86/kernel/cpu/intel.c | 176 ---- b/arch/x86/kernel/cpu/microcode/Makefile | 4 b/arch/x86/kernel/cpu/microcode/amd.c | 68 + b/arch/x86/kernel/cpu/microcode/core.c | 576 ++++++++++---- b/arch/x86/kernel/cpu/microcode/intel.c | 847 ++++++++++------------ b/arch/x86/kernel/cpu/microcode/internal.h | 125 +++ b/arch/x86/kernel/nmi.c | 9 b/arch/x86/mm/init.c | 1 b/drivers/platform/x86/intel/ifs/load.c | 15 b/include/linux/cpuhotplug.h | 1 22 files changed, 1124 insertions(+), 1109 deletions(-)