Skip to content

mmc: sdhci-pltfm: Minor clean up

Adrian Hunter linux-arm-kernel linux-mmc lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16mmc: sdhci-pltfm: Add sdhci_pltfm_remove()drivers/mmc/host/sdhci-pltfm.c drivers/mmc/host/sdhci-pltfm.h+11 -00 replies
2/16mmc: sdhci-bcm-kona: Use sdhci_pltfm_remove()drivers/mmc/host/sdhci-bcm-kona.c+11 -10 replies
3/16mmc: sdhci-brcmstb: Use sdhci_pltfm_remove()drivers/mmc/host/sdhci-brcmstb.c+5 -131 reply
4/16mmc: sdhci-cadence: Use sdhci_pltfm_remove()drivers/mmc/host/sdhci-cadence.c+4 -130 replies
5/16mmc: sdhci-dove: Use sdhci_pltfm_remove()drivers/mmc/host/sdhci-dove.c+2 -60 replies
6/16mmc: sdhci_f_sdh30: Use sdhci_pltfm_remove()drivers/mmc/host/sdhci_f_sdh30.c+1 -10 replies
7/16mmc: sdhci-iproc: Use sdhci_pltfm_remove()drivers/mmc/host/sdhci-iproc.c+3 -110 replies
8/16mmc: sdhci-of-arasan: Use sdhci_pltfm_remove()drivers/mmc/host/sdhci-of-arasan.c+3 -10 replies
9/16mmc: sdhci-of-at91: Use sdhci_pltfm_remove()drivers/mmc/host/sdhci-of-at91.c+1 -10 replies
10/16mmc: sdhci-of-esdhc: Use sdhci_pltfm_remove()drivers/mmc/host/sdhci-of-esdhc.c+1 -10 replies
11/16mmc: sdhci-of-hlwd: Use sdhci_pltfm_remove()drivers/mmc/host/sdhci-of-hlwd.c+1 -10 replies
12/16mmc: sdhci-of-sparx5: Use sdhci_pltfm_remove()drivers/mmc/host/sdhci-of-sparx5.c+6 -110 replies
13/16mmc: sdhci-pxav2: Use sdhci_pltfm_remove()drivers/mmc/host/sdhci-pxav2.c+6 -130 replies
14/16mmc: sdhci-st: Use sdhci_pltfm_remove()drivers/mmc/host/sdhci-st.c+3 -10 replies
15/16mmc: sdhci-pltfm: Remove sdhci_pltfm_unregister()drivers/mmc/host/sdhci-pltfm.c drivers/mmc/host/sdhci-pltfm.h+0 -130 replies
16/16mmc: sdhci-pltfm: Rename sdhci_pltfm_register()drivers/mmc/host/sdhci-of-hlwd.c drivers/mmc/host/sdhci-pltfm.c drivers/mmc/host/sdhci-pltfm.h+8 -80 replies

Reviews trailers per patch

1 of 16 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndy ShevchenkoKamal Dasu
SeriesR-b
1/16
2/16
3/16R-b
4/16
5/16
6/16
7/16
8/16
9/16
10/16
11/16
12/16
13/16
14/16
15/16
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/16] mmc: sdhci-pltfm: Minor clean up

Hi

sdhci_pltfm_unregister() does:

	clk_disable_unprepare(pltfm_host->clk)

which prevents drivers from using devm_clk_get_enabled() or similar.

Move it out, and where drivers are doing devm_clk_get*() immediately followed by clk_prepare_enable(), combine them into devm_clk_get_*enabled().

sdhci_pltfm_register() and sdhci_pltfm_unregister() are not paired functions. That are just helpers and effectively get renamed:

	sdhci_pltfm_register() -> sdhci_pltfm_init_and_add_host()
	sdhci_pltfm_unregister() -> sdhci_pltfm_remove()

Please note, the patches are based on top of some "Convert to platform remove callback returning void" patches by Yangtao Li, which were posted here:

	https://lore.kernel.org/linux-mmc/[email protected]/

Patches can also be found here:

https://github.com/ahunter6/linux/commits/sdhci-pltfm-cleanup-1

Adrian Hunter (16):
mmc: sdhci-pltfm: Add sdhci_pltfm_remove()
mmc: sdhci-bcm-kona: Use sdhci_pltfm_remove()
mmc: sdhci-brcmstb: Use sdhci_pltfm_remove()
mmc: sdhci-cadence: Use sdhci_pltfm_remove()
mmc: sdhci-dove: Use sdhci_pltfm_remove()
mmc: sdhci_f_sdh30: Use sdhci_pltfm_remove()
mmc: sdhci-iproc: Use sdhci_pltfm_remove()
mmc: sdhci-of-arasan: Use sdhci_pltfm_remove()
mmc: sdhci-of-at91: Use sdhci_pltfm_remove()
mmc: sdhci-of-esdhc: Use sdhci_pltfm_remove()
mmc: sdhci-of-hlwd: Use sdhci_pltfm_remove()
mmc: sdhci-of-sparx5: Use sdhci_pltfm_remove()
mmc: sdhci-pxav2: Use sdhci_pltfm_remove()
mmc: sdhci-st: Use sdhci_pltfm_remove()
mmc: sdhci-pltfm: Remove sdhci_pltfm_unregister()
mmc: sdhci-pltfm: Rename sdhci_pltfm_register()

 drivers/mmc/host/sdhci-bcm-kona.c  | 12 +++++++++++-
 drivers/mmc/host/sdhci-brcmstb.c   | 18 +++++-------------
 drivers/mmc/host/sdhci-cadence.c   | 17 ++++-------------
 drivers/mmc/host/sdhci-dove.c      |  8 ++------
 drivers/mmc/host/sdhci-iproc.c     | 14 +++-----------
 drivers/mmc/host/sdhci-of-arasan.c |  4 +++-
 drivers/mmc/host/sdhci-of-at91.c   |  2 +-
 drivers/mmc/host/sdhci-of-esdhc.c  |  2 +-
 drivers/mmc/host/sdhci-of-hlwd.c   |  4 ++--
 drivers/mmc/host/sdhci-of-sparx5.c | 17 ++++++-----------
 drivers/mmc/host/sdhci-pltfm.c     | 14 ++++++--------
 drivers/mmc/host/sdhci-pltfm.h     |  8 ++++----
 drivers/mmc/host/sdhci-pxav2.c     | 19 ++++++-------------
 drivers/mmc/host/sdhci-st.c        |  4 +++-
 drivers/mmc/host/sdhci_f_sdh30.c   |  2 +-
 15 files changed, 58 insertions(+), 87 deletions(-)

Regards
Adrian