Skip to content

Kbuild: warning options cleanup and more warnings

Arnd Bergmann linux-arch linux-kbuild llvm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9Kbuild: only pass -fno-inline-functions-called-once for gccMakefile+1 -12 replies
2/9Kbuild: consolidate warning flags in scripts/Makefile.extrawarnMakefile scripts/Makefile.extrawarn+90 -884 replies
3/9Kbuild: avoid duplicate warning optionsscripts/Makefile.extrawarn+26 -173 replies
4/9extrawarn: don't turn off -Wshift-negative-value for gcc-9scripts/Makefile.extrawarn+3 -11 reply
5/9extrawarn: enable format and stringop overflow warnings in W=1scripts/Makefile.extrawarn+6 -53 replies
6/9extrawarn: move -Wrestrict into W=1 warningsscripts/Makefile.extrawarn+2 -32 replies
7/9extrawarn: do not disable -Wmain at W=1 levelscripts/Makefile.extrawarn+2 -40 replies
8/9extrawarn: enable more warnings in W=2scripts/Makefile.extrawarn+8 -40 replies
9/9extrawarn: enable more W=1 warnings by defaultscripts/Makefile.extrawarn+9 -113 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] Kbuild: warning options cleanup and more warnings

From: Arnd Bergmann <[email protected]>

This is a series I've had in my randconfig test tree for a long time, and I'd like to get these patches applied in mainline so I can stop rebasing them on top of other changes, as well as get fewer regressions.

There are roughly three groups of changes in here:

1. Clean up the Makefile and Makefile.extrawarn to be organized more logically so we can see which warnings are actually enabled at which level

2. Enable some of the warnings that have traditionally been disabled at either the W=1 or W=2 levels where they arguably should have been to start with

3. Enable some of the W=1 warnings by default now that the warnings we got in the past have been addressed.

I sent the -Wmissing-prototypes enablement separately, since that is really the big one that probably found the most bugs but also still caused the most warnings until my recent cleanups.

Along the same lines as that other series, I would hope that we can get the first eight patches into the merge window, but should probably give the last patch another release in linux-next before any remaining output has been addressed and we can apply it.

Arnd

Arnd Bergmann (9):
Kbuild: only pass -fno-inline-functions-called-once for gcc
Kbuild: consolidate warning flags in scripts/Makefile.extrawarn
Kbuild: avoid duplicate warning options
extrawarn: don't turn off -Wshift-negative-value for gcc-9
extrawarn: enable format and stringop overflow warnings in W=1
extrawarn: move -Wrestrict into W=1 warnings
extrawarn: do not disable -Wmain at W=1 level
extrawarn: enable more warnings in W=2
[RFC] extrawarn: enable more W=1 warnings by default

 Makefile                   |  90 +------------------------
 scripts/Makefile.extrawarn | 133 ++++++++++++++++++++++++++++++++-----
 2 files changed, 118 insertions(+), 105 deletions(-)
Signature · 11 lines
2.39.2

Cc: Masahiro Yamada <[email protected]>
Cc: Nathan Chancellor <[email protected]>
Cc: Nick Desaulniers <[email protected]>
Cc: Nicolas Schier <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: Lee Jones <[email protected]>
Cc: Stephen Rothwell <[email protected]>
Cc: [email protected]
Cc: [email protected]