Skip to content

RFC ALSA/ASoC: hda: Address format selection limitations and ambiguity

Cezary Rojewski alsa-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest17 patches 35 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17ALSA: pcm: Introduce MSBITS subformat interfaceinclude/sound/pcm.h include/sound/pcm_params.h include/uapi/sound/asound.h +3 more+71 -226 replies
2/17ALSA: pcm: Honor subformat when configuring substreamsound/core/pcm_native.c+3 -20 replies
3/17ALSA: hda: Honor subformat when querying PCMsinclude/sound/hda_codec.h include/sound/hdaudio.h sound/hda/hdac_device.c +3 more+32 -230 replies
4/17ASoC: pcm: Honor subformat when configuring runtimeinclude/sound/soc.h sound/soc/soc-pcm.c+18 -00 replies
5/17ALSA: hda: Upgrade stream-format infrastructureinclude/sound/hdaudio.h sound/hda/hdac_device.c+129 -03 replies
6/17ALSA: hda: Switch to new stream-format interfacesound/pci/hda/hda_controller.c+4 -60 replies
7/17ALSA: hda/hdmi: Switch to new stream-format interfacesound/pci/hda/patch_hdmi.c+2 -30 replies
8/17ALSA: hda/ca0132: Switch to new stream-format interfacesound/pci/hda/patch_ca0132.c+1 -20 replies
9/17ASoC: codecs: hda: Switch to new stream-format interfacesound/soc/codecs/hda-dai.c sound/soc/codecs/hda.c+6 -20 replies
10/17ASoC: codecs: hdac_hda: Switch to new stream-format interfacesound/soc/codecs/hdac_hda.c+3 -50 replies
11/17ASoC: codecs: hdac_hdmi: Switch to new stream-format interfacesound/soc/codecs/hdac_hdmi.c+4 -30 replies
12/17ASoC: Intel Skylake: Switch to new stream-format interfacesound/soc/intel/skylake/skl-pcm.c+7 -40 replies
13/17ASoC: SOF: Intel: Switch to new stream-format interfacesound/soc/sof/intel/hda-dai-ops.c+3 -25 replies
14/17ASoC: Intel: avs: Switch to new stream-format interfacesound/soc/intel/avs/loader.c sound/soc/intel/avs/path.c sound/soc/intel/avs/pcm.c +1 more+18 -100 replies
15/17ALSA: hda: Drop snd_hdac_calc_stream_format()include/sound/hdaudio.h sound/hda/hdac_device.c+0 -660 replies
16/17ASoC: Intel: avs: Unhardcode HDAudio BE DAI drivers descriptionsound/soc/intel/avs/pcm.c+15 -220 replies
17/17ASoC: Intel: avs: Kill S24_LE in HDAudio streamingsound/soc/intel/avs/pcm.c sound/soc/intel/avs/topology.c+11 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 00/17] ALSA/ASoC: hda: Address format selection limitations and ambiguity

Patchset aims to address format selection restrictions present currently in the HDAudio library. Formats which we are concerned about are 20 and 24 valid bits per sample within 32 bit depth container. One may identify them as S20_LE and S24_LE except that those, according to comments found in include/uapi/sound/asound.h, are for LSB-aligned scenarios. HDAudio streams expect MSB-aligned data, no matter if we are speaking of HOST (SDxFMT) or LINK (PPLCxFMT) side - chapter 4.5.1 of the public HDAudio specification. In short, S20_LE and S24_LE are invalid options.

Right now, given the implementation of snd_hdac_query_supported_pcm() within sound/hda/hdac_device.c, even if a codec responds with: "I support all possible formats specified within HDAudio specification", there will be no option to open a 20/32 or 24/32 stream. The kernel will force the stream to be opened using the highest available bit depth.

After discussing subject initially with Jaroslav and Takashi, suggestion was made to utilize 'subformat' option to address the problem. The eye-opening discussion begun much earlier though, in 2019 [1].

Paired with PRs for alsa-utils [2] and alsa-lib [3].

Flow of changes:

The very first patch adds MSBITS subformat options to allow for granular 20/32, 24/32 and 32/32 format selection. The next three make sure subformat is actually honored during runtime. Most of that code is based on format-related API.

Follow up is upgrade to the hda stream-format interface - several functions are added to make the granular format selection simple in the HDAudio world. Core of the implementation is based on the existing snd_hdac_calc_stream_format(). The next ten patches are straightforward switch from one interface to another with cleanup of now-unsed function as a finishing touch.

Last but not least - the avs-driver, on which the problem analyzed and debugged, is updated to no longer acknowledge S24_LE as a valid format option.

Note: No testing done on other drivers yet. First results from snd_hda_intel and snd_soc_skl will be here on Monday. Will trigger SOF cycle through github PR.

[1]: https://lore.kernel.org/alsa-devel/[email protected]/
[2]: https://github.com/alsa-project/alsa-utils/pull/228
[3]: https://github.com/alsa-project/alsa-lib/pull/342

Cezary Rojewski (17):
ALSA: pcm: Introduce MSBITS subformat interface
ALSA: pcm: Honor subformat when configuring substream
ALSA: hda: Honor subformat when querying PCMs
ASoC: pcm: Honor subformat when configuring runtime
ALSA: hda: Upgrade stream-format infrastructure
ALSA: hda: Switch to new stream-format interface
ALSA: hda/hdmi: Switch to new stream-format interface
ALSA: hda/ca0132: Switch to new stream-format interface
ASoC: codecs: hda: Switch to new stream-format interface
ASoC: codecs: hdac_hda: Switch to new stream-format interface
ASoC: codecs: hdac_hdmi: Switch to new stream-format interface
ASoC: Intel Skylake: Switch to new stream-format interface
ASoC: SOF: Intel: Switch to new stream-format interface
ASoC: Intel: avs: Switch to new stream-format interface
ALSA: hda: Drop snd_hdac_calc_stream_format()
ASoC: Intel: avs: Unhardcode HDAudio BE DAI drivers description
ASoC: Intel: avs: Kill S24_LE in HDAudio streaming

 include/sound/hda_codec.h         |   5 +-
 include/sound/hdaudio.h           |  12 +--
 include/sound/pcm.h               |   8 ++
 include/sound/pcm_params.h        |   2 +
 include/sound/soc.h               |   1 +
 include/uapi/sound/asound.h       |   5 +-
 sound/core/pcm_lib.c              |  30 ++++++
 sound/core/pcm_misc.c             |  23 +++++
 sound/core/pcm_native.c           |   5 +-
 sound/hda/hdac_device.c           | 153 +++++++++++++++++++++---------
 sound/pci/hda/hda_codec.c         |   2 +
 sound/pci/hda/hda_controller.c    |  10 +-
 sound/pci/hda/patch_ca0132.c      |   3 +-
 sound/pci/hda/patch_hdmi.c        |   6 +-
 sound/soc/codecs/hda-dai.c        |   6 +-
 sound/soc/codecs/hda.c            |   2 +
 sound/soc/codecs/hdac_hda.c       |   8 +-
 sound/soc/codecs/hdac_hdmi.c      |  10 +-
 sound/soc/intel/avs/loader.c      |   4 +-
 sound/soc/intel/avs/path.c        |   2 +-
 sound/soc/intel/avs/pcm.c         |  60 ++++++------
 sound/soc/intel/avs/probes.c      |   3 +-
 sound/soc/intel/avs/topology.c    |   9 +-
 sound/soc/intel/skylake/skl-pcm.c |  11 ++-
 sound/soc/soc-pcm.c               |  17 ++++
 sound/soc/sof/intel/hda-dai-ops.c |   5 +-
 tools/include/uapi/sound/asound.h |   5 +-
 27 files changed, 290 insertions(+), 117 deletions(-)
Signature · 1 line
2.25.1