Skip to content

GPU workload hints for better performance

Arvind Yadav amd-gfx dri-devel lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 6 repliesIn review
  2. v27 patches 31 repliesSuperseded
  3. v13 patches 9 repliesSuperseded

Changes in v3 from the cover letter

- Addressed all review comment.
- Changed the function name from *_set() to *_get().
- Now clearing all the profile in work handler.
- Added *_clear_all function to clear all the power profile.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7drm/amdgpu: Added init/fini functions for workloaddrivers/gpu/drm/amd/amdgpu/Makefile drivers/gpu/drm/amd/amdgpu/amdgpu.h drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +2 more+105 -10 replies
2/7drm/amdgpu: Add new function to set GPU power profiledrivers/gpu/drm/amd/amdgpu/amdgpu_workload.c drivers/gpu/drm/amd/include/amdgpu_workload.h+62 -00 replies
3/7drm/amdgpu: Add new function to put GPU power profiledrivers/gpu/drm/amd/amdgpu/amdgpu_workload.c drivers/gpu/drm/amd/include/amdgpu_workload.h+120 -10 replies
4/7drm/amdgpu: Add suspend function to clear the GPU power profile.drivers/gpu/drm/amd/amdgpu/amdgpu_device.c drivers/gpu/drm/amd/amdgpu/amdgpu_workload.c drivers/gpu/drm/amd/include/amdgpu_workload.h+11 -00 replies
5/7drm/amdgpu: Set/Reset GPU workload profiledrivers/gpu/drm/amd/amdgpu/amdgpu_job.c+5 -01 reply
6/7drm/amdgpu: switch workload context to/from computedrivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c+5 -30 replies
7/7Revert "drm/amd/amdgpu: switch on/off vcn power profile mode"drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c+2 -120 replies

Reviews trailers per patch

4 of 7 patches have a Reviewed-by or Acked-by.

PatchShashank Sharma
1/7R-b
2/7
3/7
4/7
5/7R-b
6/7R-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/7] GPU workload hints for better performance

AMDGPU SOCs supports dynamic workload based power profiles, which can provide fine-tuned performance for a particular type of workload. This patch series adds an interface to set/reset these power profiles based on the submitted job. The driver can dynamically switch the power profiles based on submitted job. This can optimize the power performance when the particular workload is on.

v2:
- Splitting workload_profile_set and workload_profile_put into two separate patches.
- Addressed review comment.
- Added new suspend function.
- Added patch to switches the GPU workload mode for KFD.

v3:
- Addressed all review comment.
- Changed the function name from *_set() to *_get().
- Now clearing all the profile in work handler.
- Added *_clear_all function to clear all the power profile.

Arvind Yadav (7):
drm/amdgpu: Added init/fini functions for workload drm/amdgpu: Add new function to set GPU power profile drm/amdgpu: Add new function to put GPU power profile drm/amdgpu: Add suspend function to clear the GPU power profile. drm/amdgpu: Set/Reset GPU workload profile drm/amdgpu: switch workload context to/from compute Revert "drm/amd/amdgpu: switch on/off vcn power profile mode"

 drivers/gpu/drm/amd/amdgpu/Makefile           |   2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu.h           |   3 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c    |   8 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |   6 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_job.c       |   5 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c       |  14 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_workload.c  | 226 ++++++++++++++++++
 drivers/gpu/drm/amd/include/amdgpu_workload.h |  61 +++++
 8 files changed, 309 insertions(+), 16 deletions(-)
 create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_workload.c
 create mode 100644 drivers/gpu/drm/amd/include/amdgpu_workload.h
Signature · 1 line
2.34.1