Skip to content

bnxt_en: Update for net-next

Michael Chan netdev 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 posting 3/34 patches 2 repliesApplied 4/4
  2. v4 Latest9 patches 4 repliesIn review
  3. v39 patches 2 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v2 posting 2/39 patches8 repliesSuperseded
v2 posting 1/36 patches1 replyApplied 6/6
v112 patches10 repliesSuperseded

Changes in v4 from the cover letter

Simplify patch #9 based on feedback from Michal Swiatkowski.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9bnxt_en: add support for storing crash dump into host memorydrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h drivers/net/ethernet/broadcom/bnxt/bnxt_coredump.c +1 more+116 -50 replies
2/9bnxt_en: add support for retrieving crash dump using ethtooldrivers/net/ethernet/broadcom/bnxt/bnxt_coredump.c drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c+84 -91 reply
3/9bnxt_en: Support QOS and TPID settings for the SRIOV VLANdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c+15 -120 replies
4/9bnxt_en: Deprecate support for legacy INTX modedrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h+8 -360 replies
5/9bnxt_en: Remove BNXT_FLAG_USING_MSIX flagdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c+17 -880 replies
6/9bnxt_en: Remove register mapping to support INTXdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h+0 -210 replies
7/9bnxt_en: Replace deprecated PCI MSIX APIsdrivers/net/ethernet/broadcom/bnxt/bnxt.c+5 -160 replies
8/9bnxt_en: Allocate the max bp->irq_tbl size for dynamic msix allocationdrivers/net/ethernet/broadcom/bnxt/bnxt.c+5 -20 replies
9/9bnxt_en: Support dynamic MSIXdrivers/net/ethernet/broadcom/bnxt/bnxt.c+34 -32 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchSomnath KoturPavan ChebbiAndy GospodarekSimon HormanHongguang GaoKalesh APPrzemek KitszelMichal Swiatkowski
1/9R-b R-b R-b R-b
2/9R-b R-b R-b R-b
3/9R-b
4/9R-b R-b R-b R-b
5/9R-b R-b R-b R-b
6/9R-b R-b R-b
7/9R-b R-b R-b R-b
8/9R-b R-b R-b R-b
9/9R-b R-b R-b R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v4 thread

Cover letter [PATCH net-next v4 0/9] bnxt_en: Update for net-next

This series starts with 2 patches to support firmware crash dump. The driver allocates the required DMA memory ahead of time for firmware to store the crash dump if and when it crashes. Patch 3 adds priority and TPID for the .ndo_set_vf_vlan() callback. Note that this was rejected and reverted last year and it is being re-submitted after recent changes in the guidelines. The remaining patches are MSIX related. Legacy interrupt is no longer supported by firmware so we remove the support in the driver. We then convert to use the newer kernel APIs to allocate and enable MSIX vectors. The last patch adds support for dynamic MSIX.

v4:
Simplify patch #9 based on feedback from Michal Swiatkowski.

Link to v3:
https://lore.kernel.org/netdev/[email protected]/

v3:
Some changes to patch #1, #2, and #8 based on feedback from Przemek Kitszel and internal review. I'm keeping Simon's Reviewed-by tags since the changes are small.

Link to v2:
https://lore.kernel.org/netdev/[email protected]/

v2:
Only patch #4 is updated to fix a memory leakage reported by Simon. The changelog of some of the MSIX patches have been updated based on feedback from Bjorn Helgaas.

Link to v1:
https://lore.kernel.org/netdev/[email protected]/

Michael Chan (6):
bnxt_en: Deprecate support for legacy INTX mode
bnxt_en: Remove BNXT_FLAG_USING_MSIX flag
bnxt_en: Remove register mapping to support INTX
bnxt_en: Replace deprecated PCI MSIX APIs
bnxt_en: Allocate the max bp->irq_tbl size for dynamic msix allocation
bnxt_en: Support dynamic MSIX

Sreekanth Reddy (1):
bnxt_en: Support QOS and TPID settings for the SRIOV VLAN

Vikas Gupta (2):
bnxt_en: add support for storing crash dump into host memory
bnxt_en: add support for retrieving crash dump using ethtool

 drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 310 +++++++++---------
 drivers/net/ethernet/broadcom/bnxt/bnxt.h     |   8 +-
 .../ethernet/broadcom/bnxt/bnxt_coredump.c    |  98 +++++-
 .../ethernet/broadcom/bnxt/bnxt_coredump.h    |   8 +
 .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c |  13 +-
 .../net/ethernet/broadcom/bnxt/bnxt_sriov.c   |  29 +-
 6 files changed, 279 insertions(+), 187 deletions(-)
Signature · 1 line
2.30.1