Skip to content

kiocb_{start,end}_write() helpers

Amir Goldstein linux-fsdevel 3 versions – Applied

Status from this message: Applied to the vfs.misc branch of the vfs/vfs.git tree.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 12 repliesApplied
  2. v21 patch 5 repliesSuperseded
  3. v11 patch 6 repliesSuperseded

Changes in v3 from the cover letter

- Split patches to helpers and use helpers per caller (Jens)
- Drop IOCB_WRITE_STARTED flag

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/7io_uring: rename kiocb_end_write() local helperio_uring/rw.c+5 -51 reply
2/7fs: add kerneldoc to file_{start,end}_write() helpersinclude/linux/fs.h+14 -11 reply
3/7fs: create kiocb_{start,end}_write() helpersinclude/linux/fs.h+36 -01 reply
4/7io_uring: use kiocb_{start,end}_write() helpersio_uring/rw.c+4 -191 reply
5/7aio: use kiocb_{start,end}_write() helpersfs/aio.c+3 -171 reply
6/7ovl: use kiocb_{start,end}_write() helpersfs/overlayfs/file.c+2 -81 reply
7/7cachefiles: use kiocb_{start,end}_write() helpersfs/cachefiles/io.c+3 -131 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJan KaraJens Axboe
SeriesR-b
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/7] kiocb_{start,end}_write() helpers

Christian,

This is an attempt to consolidate the open coded lockdep fooling in all those async io submitters into a single helper.
The idea to do that consolidation was suggested by Jan.

This re-factoring is part of a larger vfs cleanup I am doing for fanotify permission events. The complete series is not ready for prime time yet, but this one patch is independent and I would love to get it reviewed/merged a head of the rest.

This v3 series addresses the review comments of Jens on v2 [1].

Thanks,
Amir.

Changes since v2:
- Split patches to helpers and use helpers per caller (Jens)
- Drop IOCB_WRITE_STARTED flag

Changes since v1:
- Leave ISREG checks in callers (Jens)
- Leave setting IOCB_WRITE flag in callers

[1] https://lore.kernel.org/linux-fsdevel/[email protected]/

Amir Goldstein (7):
io_uring: rename kiocb_end_write() local helper
fs: add kerneldoc to file_{start,end}_write() helpers
fs: create kiocb_{start,end}_write() helpers
io_uring: use kiocb_{start,end}_write() helpers
aio: use kiocb_{start,end}_write() helpers
ovl: use kiocb_{start,end}_write() helpers
cachefiles: use kiocb_{start,end}_write() helpers

 fs/aio.c            | 20 +++---------------
 fs/cachefiles/io.c  | 16 +++-----------
 fs/overlayfs/file.c | 10 ++-------
 include/linux/fs.h  | 51 ++++++++++++++++++++++++++++++++++++++++++++-
 io_uring/rw.c       | 33 ++++++++---------------------
 5 files changed, 67 insertions(+), 63 deletions(-)
Signature · 1 line
2.34.1