Skip to content

ice: refactor PTP feature flags

Jacob Keller intel-wired-lan oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ice: remove ICE_F_PTP_EXTTS feature flagdrivers/net/ethernet/intel/ice/ice.h drivers/net/ethernet/intel/ice/ice_lib.c drivers/net/ethernet/intel/ice/ice_ptp.c+1 -50 replies
1/4ice: remove ICE_F_PTP_EXTTS feature flagdrivers/net/ethernet/intel/ice/ice.h drivers/net/ethernet/intel/ice/ice_lib.c drivers/net/ethernet/intel/ice/ice_ptp.c+1 -50 replies
2/4ice: don't enable PTP related capabilities on non-owner PFsdrivers/net/ethernet/intel/ice/ice_lib.c+3 -00 replies
2/4ice: don't enable PTP related capabilities on non-owner PFsdrivers/net/ethernet/intel/ice/ice_lib.c+3 -00 replies
3/4ice: check the netlist before enabling ICE_F_SMA_CTRLdrivers/net/ethernet/intel/ice/ice_adminq_cmd.h drivers/net/ethernet/intel/ice/ice_common.c drivers/net/ethernet/intel/ice/ice_common.h +3 more+72 -35 replies
3/4ice: check the netlist before enabling ICE_F_SMA_CTRLdrivers/net/ethernet/intel/ice/ice_adminq_cmd.h drivers/net/ethernet/intel/ice/ice_common.c drivers/net/ethernet/intel/ice/ice_common.h +3 more+72 -30 replies
4/4ice: check netlist before enabling ICE_F_GNSSdrivers/net/ethernet/intel/ice/ice_adminq_cmd.h drivers/net/ethernet/intel/ice/ice_lib.c drivers/net/ethernet/intel/ice/ice_ptp_hw.c +1 more+21 -41 reply
4/4ice: check netlist before enabling ICE_F_GNSSdrivers/net/ethernet/intel/ice/ice_adminq_cmd.h drivers/net/ethernet/intel/ice/ice_lib.c drivers/net/ethernet/intel/ice/ice_ptp_hw.c +1 more+21 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Intel-wired-lan] [PATCH iwl-next 0/4] ice: refactor PTP feature flags

This series refactors and extends the feature flag detection for a couple of PTP feature flags. This includes ICE_F_GNSS and ICE_F_SMA_CTRL. Instead of blindly assuming the feature is enabled on all E810-T devices, check the netlist to confirm that the feature is supported on that device and platform.

For SMA control, this allows the driver to fallback to the fixed pin configuration that is supported by default E810 configurations when the SMA control is not accessible.

For GNSS, this ensures that we do not attempt to read the GNSS portion of the device if its not present, avoiding some unnecessary warning messages.

For ICE_F_SMA_CTRL this could be seen as a fix, but given the scope of the code I decided that its next material. I think of it more as extending the feature capability to support pins on more platforms.

Jacob Keller (4):
ice: remove ICE_F_PTP_EXTTS feature flag
ice: don't enable PTP related capabilities on non-owner PFs
ice: check the netlist before enabling ICE_F_SMA_CTRL
ice: check netlist before enabling ICE_F_GNSS

 drivers/net/ethernet/intel/ice/ice.h          |  1 -
 .../net/ethernet/intel/ice/ice_adminq_cmd.h   |  8 +++-
 drivers/net/ethernet/intel/ice/ice_common.c   | 46 +++++++++++++++++++
 drivers/net/ethernet/intel/ice/ice_common.h   |  3 ++
 drivers/net/ethernet/intel/ice/ice_lib.c      | 12 +++--
 drivers/net/ethernet/intel/ice/ice_ptp.c      |  4 +-
 drivers/net/ethernet/intel/ice/ice_ptp_hw.c   | 31 +++++++++++++
 drivers/net/ethernet/intel/ice/ice_ptp_hw.h   |  2 +
 8 files changed, 96 insertions(+), 11 deletions(-)

base-commit: 361b86237e1afbf2c3be7cb604b6aac6f8b8c38c

Signature · 6 lines
2.41.0.1.g9857a21e0017.dirty

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan