Skip to content

tty: n_tty: cleanup

Jiri Slaby (SUSE) linux-serial lkml 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest14 patches 0 repliesNew
  2. v114 patches 3 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14tty: n_tty: make flow of n_tty_receive_buf_common() a booldrivers/tty/n_tty.c+3 -30 replies
2/14tty: n_tty: use output character directlydrivers/tty/n_tty.c+1 -20 replies
3/14tty: n_tty: use 'num' for writes' countsdrivers/tty/n_tty.c+8 -90 replies
4/14tty: n_tty: use time_is_before_jiffies() in n_tty_receive_overrun()drivers/tty/n_tty.c+1 -20 replies
5/14tty: n_tty: make n_tty_data::num_overrun unsigneddrivers/tty/n_tty.c+2 -20 replies
6/14tty: n_tty: use MASK() for masking out size bitsdrivers/tty/n_tty.c+11 -120 replies
7/14tty: n_tty: move canon handling to a separate functiondrivers/tty/n_tty.c+87 -710 replies
8/14tty: n_tty: move newline handling to a separate functiondrivers/tty/n_tty.c+19 -80 replies
9/14tty: n_tty: remove unsigned char casts from character constantsdrivers/tty/n_tty.c+3 -30 replies
10/14tty: n_tty: simplify chars_in_buffer()drivers/tty/n_tty.c+2 -60 replies
11/14tty: n_tty: use u8 for chars and flagsdrivers/tty/n_tty.c+36 -360 replies
12/14tty: n_tty: unify counts to size_tdrivers/tty/n_tty.c+15 -170 replies
13/14tty: n_tty: extract ECHO_OP processing to a separate functiondrivers/tty/n_tty.c+98 -960 replies
14/14tty: n_tty: deduplicate copy code in n_tty_receive_buf_real_raw()drivers/tty/n_tty.c+12 -130 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/14] tty: n_tty: cleanup

This is another part (say part III.) of the previous type unification across the tty layer[1]. This time, in n_tty line discipline. Apart from type changes, this series contains a larger set of refactoring of the code. Namely, separating hairy code into single functions for better readability.

[1] https://lore.kernel.org/all/[email protected]/

Note this is completely independent on "part II." (tty_buffer cleanup), so those two can be applied in any order.

[v2]
* resend as I intertwined the series with and older one
* use better name for variable in 03/14

Jiri Slaby (SUSE) (14):
tty: n_tty: make flow of n_tty_receive_buf_common() a bool
tty: n_tty: use output character directly
tty: n_tty: use 'num' for writes' counts
tty: n_tty: use time_is_before_jiffies() in n_tty_receive_overrun()
tty: n_tty: make n_tty_data::num_overrun unsigned
tty: n_tty: use MASK() for masking out size bits
tty: n_tty: move canon handling to a separate function
tty: n_tty: move newline handling to a separate function
tty: n_tty: remove unsigned char casts from character constants
tty: n_tty: simplify chars_in_buffer()
tty: n_tty: use u8 for chars and flags
tty: n_tty: unify counts to size_t
tty: n_tty: extract ECHO_OP processing to a separate function
tty: n_tty: deduplicate copy code in n_tty_receive_buf_real_raw()

 drivers/tty/n_tty.c | 538 +++++++++++++++++++++++---------------------
 1 file changed, 278 insertions(+), 260 deletions(-)
Signature · 1 line
2.42.0