Skip to content

drm/amd/display: Enable writeback for amdgpu

Alex Hung amd-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18drm/amd/display: Skip entire amdgpu_dm build if !CONFIG_DRM_AMD_DCdrivers/gpu/drm/amd/display/amdgpu_dm/Makefile+8 -51 reply
2/18drm/amd/display: Create one virtual connector in DCdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hwseq.c+11 -33 replies
3/18drm/amd/display: Initialize writeback connectordrivers/gpu/drm/amd/display/amdgpu_dm/Makefile drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c +1 more+265 -20 replies
4/18drm/amd/display: Skip writeback connector when we get amdgpu_dm_connectordrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c+76 -111 reply
5/18drm/amd/display: Return drm_connector from find_first_crtc_matching_connectordrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c+9 -51 reply
6/18drm/amd/display: Use drm_connector in create_stream_for_sinkdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c+37 -281 reply
7/18drm/amd/display: Use drm_connector in create_validate_stream_for_sinkdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c+19 -111 reply
8/18drm/amd/display: Create amdgpu_dm_wb_connectordrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c +1 more+24 -81 reply
9/18drm/amd/display: Create fake sink and stream for writeback connectordrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c+22 -111 reply
10/18drm/amd/display: Hande writeback request from userspacedrivers/gpu/drm/amd/amdgpu/amdgpu_mode.h drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c+162 -00 replies
11/18drm/amd/display: Add writeback enable/disable in dcdrivers/gpu/drm/amd/display/dc/core/dc_stream.c drivers/gpu/drm/amd/display/dc/dcn30/dcn30_hwseq.c+37 -00 replies
12/18drm/amd/display: Fix writeback_info never got updateddrivers/gpu/drm/amd/display/dc/core/dc_stream.c+4 -90 replies
13/18drm/amd/display: Validate hw_points_num before using itdrivers/gpu/drm/amd/display/dc/dcn30/dcn30_dwb_cm.c+3 -00 replies
14/18drm/amd/display: Fix writeback_info is not removeddrivers/gpu/drm/amd/display/dc/core/dc_stream.c+4 -30 replies
15/18drm/amd/display: Add writeback enable field (wb_enabled)drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c+9 -00 replies
16/18drm/amd/display: Setup for mmhubbub3_warmup_mcif with big bufferdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c+6 -00 replies
17/18drm/amd/display: Add new set_fc_enable to struct dwbc_funcsdrivers/gpu/drm/amd/display/dc/dcn30/dcn30_dwb.c drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dwb.h drivers/gpu/drm/amd/display/dc/inc/hw/dwb.h+29 -00 replies
18/18drm/amd/display: Disable DWB frame capture to emulate oneshotdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c drivers/gpu/drm/amd/display/dc/core/dc_stream.c drivers/gpu/drm/amd/display/dc/dc_stream.h+44 -10 replies

Reviews trailers per patch

8 of 18 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHarry WentlandAlex Hung
SeriesR-b
1/18R-b
2/18R-b
3/18
4/18R-b
5/18R-b
6/18R-b
7/18R-b
8/18R-b
9/18R-b
10/18
11/18
12/18
13/18
14/18
15/18
16/18
17/18
18/18

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/18] drm/amd/display: Enable writeback for amdgpu

This patchset adds drm_writeback connector supports and enables display writeback block (DWB) in AMD hardware.

The function can be tested by IGT's kms_writeback test which also requires a number of patches to enable 10bit (DRM_FORMAT_XRGB2101010). Patches are available @ https://patchwork.freedesktop.org/series/122536/

Alex Hung (10):
drm/amd/display: Initialize writeback connector drm/amd/display: Hande writeback request from userspace drm/amd/display: Add writeback enable/disable in dc drm/amd/display: Fix writeback_info never got updated drm/amd/display: Validate hw_points_num before using it drm/amd/display: Fix writeback_info is not removed drm/amd/display: Add writeback enable field (wb_enabled) drm/amd/display: Setup for mmhubbub3_warmup_mcif with big buffer drm/amd/display: Add new set_fc_enable to struct dwbc_funcs drm/amd/display: Disable DWB frame capture to emulate oneshot

Harry Wentland (8):
drm/amd/display: Skip entire amdgpu_dm build if !CONFIG_DRM_AMD_DC drm/amd/display: Create one virtual connector in DC drm/amd/display: Skip writeback connector when we get
amdgpu_dm_connector
drm/amd/display: Return drm_connector from
find_first_crtc_matching_connector
drm/amd/display: Use drm_connector in create_stream_for_sink drm/amd/display: Use drm_connector in create_validate_stream_for_sink drm/amd/display: Create amdgpu_dm_wb_connector drm/amd/display: Create fake sink and stream for writeback connector

 drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h      |   4 +
 .../gpu/drm/amd/display/amdgpu_dm/Makefile    |  14 +-
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 375 ++++++++++++++++--
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h |  12 +-
 .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c |   3 +
 .../drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c |  22 +-
 .../display/amdgpu_dm/amdgpu_dm_mst_types.c   |   8 +-
 .../drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c  | 215 ++++++++++
 .../drm/amd/display/amdgpu_dm/amdgpu_dm_wb.h  |  36 ++
 .../gpu/drm/amd/display/dc/core/dc_stream.c   |  80 +++-
 drivers/gpu/drm/amd/display/dc/dc_stream.h    |   4 +
 .../gpu/drm/amd/display/dc/dcn30/dcn30_dwb.c  |  23 ++
 .../gpu/drm/amd/display/dc/dcn30/dcn30_dwb.h  |   2 +
 .../drm/amd/display/dc/dcn30/dcn30_dwb_cm.c   |   3 +
 .../drm/amd/display/dc/dcn30/dcn30_hwseq.c    |   4 +
 .../drm/amd/display/dc/dcn31/dcn31_hwseq.c    |   3 +-
 drivers/gpu/drm/amd/display/dc/inc/hw/dwb.h   |   4 +
 17 files changed, 742 insertions(+), 70 deletions(-)
 create mode 100644 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c
 create mode 100644 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.h
Signature · 1 line
2.41.0