Skip to content

RFC net: page_pool: add netlink-based introspection

Jakub Kicinski netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest13 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13net: page_pool: split the page_pool_params into fast and slowinclude/net/page_pool/types.h net/core/page_pool.c+23 -153 replies
2/13net: page_pool: avoid touching slow on the fastpathinclude/net/page_pool/types.h net/core/page_pool.c+5 -13 replies
3/13net: page_pool: factor out uninitnet/core/page_pool.c+13 -83 replies
4/13net: page_pool: id the page poolsinclude/net/page_pool/types.h net/core/Makefile net/core/page_pool.c +2 more+66 -62 replies
5/13net: page_pool: record pools per netdevinclude/linux/list.h include/linux/netdevice.h include/net/page_pool/types.h +1 more+114 -02 replies
6/13net: page_pool: stash the NAPI ID for easier accessinclude/net/page_pool/types.h net/core/page_pool_user.c+4 -10 replies
7/13eth: link netdev to ppdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/mellanox/mlx5/core/en_main.c drivers/net/ethernet/microsoft/mana/mana_en.c+3 -00 replies
8/13net: page_pool: add nlspec for basic access to page poolsDocumentation/netlink/specs/netdev.yaml+41 -00 replies
9/13net: page_pool: implement GET in the netlink APIinclude/uapi/linux/netdev.h net/core/netdev-genl-gen.c net/core/netdev-genl-gen.h +1 more+158 -00 replies
10/13net: page_pool: add netlink notifications for state changesDocumentation/netlink/specs/netdev.yaml include/uapi/linux/netdev.h net/core/netdev-genl-gen.c +2 more+59 -00 replies
11/13net: page_pool: report when page pool was destroyedDocumentation/netlink/specs/netdev.yaml include/net/page_pool/types.h include/uapi/linux/netdev.h +3 more+40 -10 replies
12/13net: page_pool: expose page pool stats via netlinkDocumentation/netlink/specs/netdev.yaml Documentation/networking/page_pool.rst include/net/page_pool/helpers.h +5 more+246 -90 replies
13/13tools: netdev: regen after page pool changestools/include/uapi/linux/netdev.h tools/net/ynl/generated/netdev-user.c tools/net/ynl/generated/netdev-user.h+621 -00 replies

Reviews trailers per patch

3 of 13 patches have a Reviewed-by or Acked-by.

PatchJesper Dangaard BrouerIlias ApalodimasMina Almasry
1/13A-b A-b R-b
2/13A-b A-b R-b
3/13R-b
4/13
5/13
6/13
7/13
8/13
9/13
10/13
11/13
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [RFC net-next 00/13] net: page_pool: add netlink-based introspection

As the page pool functionality grows we will be increasingly constrained by the lack of any uAPI. This series is a first step towards such a uAPI, it creates a way for users to query information about page pools and associated statistics.

I'm purposefully exposing only the information which I'd find useful when monitoring production workloads.

For the SET part (which to be clear isn't addressed by this series at all) I think we'll need to turn to something more along the lines of "netdev-level policy". Instead of configuring page pools, which are somewhat ephemeral, and hard to change at runtime, we should set the "expected page pool parameters" at the netdev level, and have the driver consult those when instantiating pools. My ramblings from yesterday about Queue API may make this more or less clear...
https://lore.kernel.org/all/[email protected]/

Jakub Kicinski (13):
net: page_pool: split the page_pool_params into fast and slow
net: page_pool: avoid touching slow on the fastpath
net: page_pool: factor out uninit
net: page_pool: id the page pools
net: page_pool: record pools per netdev
net: page_pool: stash the NAPI ID for easier access
eth: link netdev to pp
net: page_pool: add nlspec for basic access to page pools
net: page_pool: implement GET in the netlink API
net: page_pool: add netlink notifications for state changes
net: page_pool: report when page pool was destroyed
net: page_pool: expose page pool stats via netlink
tools: netdev: regen after page pool changes

 Documentation/netlink/specs/netdev.yaml       | 158 +++++++
 Documentation/networking/page_pool.rst        |   5 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt.c     |   1 +
 .../net/ethernet/mellanox/mlx5/core/en_main.c |   1 +
 drivers/net/ethernet/microsoft/mana/mana_en.c |   1 +
 include/linux/list.h                          |  20 +
 include/linux/netdevice.h                     |   4 +
 include/net/page_pool/helpers.h               |   8 +-
 include/net/page_pool/types.h                 |  43 +-
 include/uapi/linux/netdev.h                   |  37 ++
 net/core/Makefile                             |   2 +-
 net/core/netdev-genl-gen.c                    |  41 ++
 net/core/netdev-genl-gen.h                    |  11 +
 net/core/page_pool.c                          |  56 ++-
 net/core/page_pool_priv.h                     |  12 +
 net/core/page_pool_user.c                     | 409 +++++++++++++++++
 tools/include/uapi/linux/netdev.h             |  37 ++
 tools/net/ynl/generated/netdev-user.c         | 415 ++++++++++++++++++
 tools/net/ynl/generated/netdev-user.h         | 169 +++++++
 19 files changed, 1391 insertions(+), 39 deletions(-)
 create mode 100644 net/core/page_pool_priv.h
 create mode 100644 net/core/page_pool_user.c
Signature · 1 line
2.41.0