smartpqi updates
Status from this message: Applied to 6.6/scsi-staging, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest8 patches 2 repliesApplied
- v19 patches 1 replySuperseded
Changes in v2 from the cover letter
Removed patch smartpqi-reformat-to-align-with-oob-driver based on a review by:
"Martin K. Petersen" <[email protected]>
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | smartpqi: add abort handlerdrivers/ drivers/ | +149 | 0 replies | |
| 2/8 | smartpqi: refactor rename MACRO to clarify purposedrivers/ drivers/ | +2 | 0 replies | |
| 3/8 | smartpqi: refactor rename pciinfo to pci_infodrivers/ | +6 | 0 replies | |
| 4/8 | smartpqi: simplify lun_number assignmentdrivers/ | +2 | 0 replies | |
| 5/8 | smartpqi: enhance shutdown notificationdrivers/ | +1 | 0 replies | |
| 6/8 | smartpqi: enhance controller offline notificationdrivers/ | +49 | 0 replies | |
| 7/8 | smartpqi: enhance error messagesdrivers/ | +9 | 0 replies | |
| 8/8 | smartpqi: change driver version to 2.1.24-046drivers/ | +3 | 0 replies |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Mahesh Rajashekhara | Scott Teel | Scott Benesh | Mike McGowen | Kevin Barnett | Gerry Morong |
|---|---|---|---|---|---|---|
| 1/8 | R-b | R-b | R-b | R-b | ||
| 2/8 | R-b | R-b | R-b | R-b | ||
| 3/8 | R-b | R-b | ||||
| 4/8 | R-b | R-b | R-b | |||
| 5/8 | R-b | R-b | R-b | R-b | R-b | |
| 6/8 | R-b | R-b | R-b | |||
| 7/8 | R-b | R-b | R-b | |||
| 8/8 | R-b | R-b | R-b | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.
Cover letter [PATCH v2 0/8] smartpqi updates
cat smartpqi_6.6_cover_letter
These patches are based on Martin Petersen's 6.6/scsi-queue tree
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git
6.6/scsi-queue
The biggest functional change to smartpqi is the addition of an abort handler. Some customers were complaining about I/O stalls to all devices when only one device is reset. Adding an abort handler helps to prevent I/O stalls to all devices.
All of the reset of the patches are small changes to logging messages, MACRO and variable name changes, and one minor change for LUN assignments.
This set of changes consists of:
* smartpqi-add-abort-handler
When a device reset occurs, the SML pauses I/O to all devices presented by a controller instance causing some performance issues.
To only affect device with a problematic request, we added an abort handler. The abort handler is implemented by using a device reset, but I/O to the other devices is no longer affected.
* smartpqi-refactor-rename-MACRO-to-clarify-purpose
The MACRO SOP_RC_INCORRECT_LOGICAL_UNIT was used to check for a condition where a TMF was sent an incorrect LUN. We renamed this MACRO to SOP_TMF_INCORRECT_LOGICAL_UNIT for clarity.
* smartpqi-refactor-rename-pciinfo-to-pci_info
Change the pciinfo variable to pci_info to make more readable code. No functional changes.
* smartpqi-simplify-lun_number-assignment
We simplified the conditional expression used to populate LUN numbers for requests.
* smartpqi-enhance-shutdown-notification
Clarify controller cache flush errors. We added in more precise information to the cache flush informational message.
No functional changes.
* smartpqi-enhance-controller-offline-notification
The driver can offline a controller for multiple reasons. We added a description of why these rare offline actions are taken. And a function to provide the specific details of the shutdown.
* smartpqi-enhance-error-messages
We added host:bus:target:lun to messages emitted in our reset/abort handlers. No functional changes.
* smartpqi-change-driver-version-to-2.1.24-046
Changes since v1:
Removed patch smartpqi-reformat-to-align-with-oob-driver based on a review by:
"Martin K. Petersen" <[email protected]>
David Strahan (3):
smartpqi: simplify lun_number assignment
smartpqi: enhance shutdown notification
smartpqi: enhance controller offline notification
Don Brace (1):
smartpqi: change driver version to 2.1.24-046
Kevin Barnett (3):
smartpqi: add abort handler
smartpqi: refactor rename MACRO to clarify purpose
smartpqi: refactor rename pciinfo to pci_info
Mahesh Rajashekhara (1):
smartpqi: enhance error messages
drivers/scsi/smartpqi/smartpqi.h | 16 +- drivers/scsi/smartpqi/smartpqi_init.c | 254 ++++++++++++++++++++------ 2 files changed, 215 insertions(+), 55 deletions(-)
Signature · 1 line
2.42.0