Skip to content

wifi: cfg80211: Annotate with __counted_by

Kees Cook linux-hardening linux-wireless lkml llvm netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7wifi: cfg80211: Annotate struct cfg80211_acl_data with __counted_byinclude/net/cfg80211.h net/wireless/nl80211.c+2 -33 replies
2/7wifi: cfg80211: Annotate struct cfg80211_cqm_config with __counted_bynet/wireless/core.h+1 -12 replies
3/7wifi: cfg80211: Annotate struct cfg80211_mbssid_elems with __counted_byinclude/net/cfg80211.h net/wireless/nl80211.c+2 -22 replies
4/7wifi: cfg80211: Annotate struct cfg80211_pmsr_request with __counted_byinclude/net/cfg80211.h net/wireless/pmsr.c+2 -32 replies
5/7wifi: cfg80211: Annotate struct cfg80211_rnr_elems with __counted_byinclude/net/cfg80211.h net/wireless/nl80211.c+2 -22 replies
6/7wifi: cfg80211: Annotate struct cfg80211_scan_request with __counted_byinclude/net/cfg80211.h+1 -12 replies
7/7wifi: cfg80211: Annotate struct cfg80211_tid_config with __counted_byinclude/net/cfg80211.h+1 -12 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchJustin StittGustavo A. R. SilvaJeff Johnson
1/7R-b R-b R-b
2/7R-b R-b
3/7R-b R-b
4/7R-b R-b
5/7R-b R-b
6/7R-b R-b
7/7R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/7] wifi: cfg80211: Annotate with __counted_by

Hi,

This annotates several structures with the coming __counted_by attribute for bounds checking of flexible arrays at run-time. As a note toward applicability, had this mitigation been available already, the flaw fixed in commit 6311071a0562 ("wifi: nl80211: fix integer overflow in nl80211_parse_mbssid_elems()") would have already been unexploitable (i.e. writes through an out-of-bounds index would have been blocked).

Thanks!

-Kees

Kees Cook (7):
wifi: cfg80211: Annotate struct cfg80211_acl_data with __counted_by
wifi: cfg80211: Annotate struct cfg80211_cqm_config with __counted_by
wifi: cfg80211: Annotate struct cfg80211_mbssid_elems with
__counted_by
wifi: cfg80211: Annotate struct cfg80211_pmsr_request with
__counted_by
wifi: cfg80211: Annotate struct cfg80211_rnr_elems with __counted_by
wifi: cfg80211: Annotate struct cfg80211_scan_request with
__counted_by
wifi: cfg80211: Annotate struct cfg80211_tid_config with __counted_by

 include/net/cfg80211.h | 12 ++++++------
 net/wireless/core.h    |  2 +-
 net/wireless/nl80211.c |  7 +++----
 net/wireless/pmsr.c    |  3 +--
 4 files changed, 11 insertions(+), 13 deletions(-)
Signature · 1 line
2.34.1

Read the cover letter in its thread