Skip to content

Replace us of term abort

Stephen Hemminger dpdk-dev 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 5 repliesIn review
  2. v114 patches 3 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13jobstats: change jobstats_abort to jobstats_cancelexamples/l2fwd-jobstats/main.c lib/jobstats/rte_jobstats.c lib/jobstats/rte_jobstats.h +1 more+11 -40 replies
2/13all: remove use of word abortapp/test-compress-perf/comp_perf_test_cyclecount.c app/test-compress-perf/comp_perf_test_throughput.c app/test-compress-perf/comp_perf_test_verify.c +18 more+49 -490 replies
3/13pipeline: remove use of term abortexamples/pipeline/cli.c lib/pipeline/rte_swx_ctl.c lib/pipeline/rte_swx_ctl.h +1 more+30 -290 replies
4/13net/vmxnet3: replace abort() with rte_panic()drivers/net/vmxnet3/vmxnet3_rxtx.c+3 -30 replies
5/13event/dlb2: remove word abort in commentsdrivers/event/dlb2/dlb2.c drivers/event/dlb2/pf/base/dlb2_resource.c+2 -20 replies
6/13net/vdev_netvsc: replace use of term abortdrivers/net/vdev_netvsc/vdev_netvsc.c+2 -20 replies
7/13net/netvsc: replace abort with canceldrivers/net/netvsc/rndis.h+1 -11 reply
8/13net/ionic: remove word abortingdrivers/net/ionic/ionic_dev_pci.c drivers/net/ionic/ionic_ethdev.c drivers/net/ionic/ionic_lif.c+13 -130 replies
9/13net/bnx2x: replace abort with canceldrivers/net/bnx2x/bnx2x.c drivers/net/bnx2x/bnx2x_vfpf.c drivers/net/bnx2x/ecore_hsi.h +1 more+24 -240 replies
10/13net/mlx5: replace abort with canceldrivers/common/mlx5/mlx5_common_mr.c drivers/common/mlx5/mlx5_prm.h drivers/net/mlx5/hws/mlx5dr_rule.c +4 more+14 -140 replies
11/13net/softnic: replace abort with canceldrivers/net/softnic/rte_eth_softnic_cli.c+6 -60 replies
12/13net/mlx4: remove word abortdrivers/net/mlx4/mlx4_mr.c+3 -30 replies
13/13net/axgbe: replace word abortdrivers/net/axgbe/axgbe_common.h drivers/net/axgbe/axgbe_ethdev.h drivers/net/axgbe/axgbe_i2c.c+16 -160 replies

Reviews trailers per patch

1 of 13 patches has a Reviewed-by or Acked-by.

PatchLong Li
1/13
2/13
3/13
4/13
5/13
6/13
7/13A-b
8/13
9/13
10/13
11/13
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/13] Replace us of term abort

The term 'abort' is on the inclusive namin Tier 1 word list as replace when possible. It is possible to do this across DPDK except the few places that directly call the lib C abort() function.

v2 - drop changes to sfc since requires changes to base driver
- cleanup some checkpatch and missing spots

Rationale (from https://inclusivenaming.org/word-lists/tier-1/abort/)

The term “abort” frequently appeared in Inclusive Language Initiative surveys and standards reviews. Multiple organizations felt that usage of the word posed an issue worth addressing in their individual companies and projects. Given this widespread interest, the INI has decided to offer its own guidance.

INI recommends replacing “abort” wherever possible. In accordance with the INI’s language framework, the term does not necessarily constitute a first-order concern. However, because it is such a charged term outside of computing, “abort” fails to provide a clear description of the action being taken, and serves primarily to distract. There are numerous other words in the English language that can serve the same purpose in computing without invoking the emotionally charged cultural context of “abort.”

Although the INI debated whether the word “abort” itself or the procedure commonly associated with it (“abortion”) caused the aforementioned distractions, the etymology of the word has a direct and unambiguous link to the termination of a pregnancy. Alternative uses of the word “abort” are in use today, such as in rocketry. However, the INI concluded that the term itself was insufficiently distanced from its original meaning for those alternative definitions to be its primary association.

All this being said, the INI does not advocate for a blanket replacement of the term. “Abort” appears in many standards organization documents, and is deeply embedded in some operating systems. As such, the INI acknowledges that the term may need to be retained in certain contexts to remain in compliance with those standards, or to preserve accurate documentation for bedrock functions and processes that are too fundamental to be changed.

Some organizations have noted that using “abort” in contexts other than the medical or political serves to de-stigmatize the term, thereby promoting reproductive rights and bodily autonomy. Conversely, discouraging the term could be interpreted as accepting a framing that denies a pregnant person’s right to control their body. The judgment of the INI is that the term causes discomfort or offense without providing a necessary degree of technical clarity, and therefore it should be avoided. At some future point, because language changes over time, “abort” may become a less contentious term; at that juncture, the appropriateness of the term may be revisited.

Stephen Hemminger (13):
jobstats: change jobstats_abort to jobstats_cancel
all: remove use of word abort
pipeline: remove use of term abort net/vmxnet3: replace abort() with rte_panic() event/dlb2: remove word abort in comments net/vdev_netvsc: replace use of term abort net/netvsc: replace abort with cancel net/ionic: remove word aborting
net/bnx2x: replace abort with cancel net/mlx5: replace abort with cancel net/softnic: replace abort with cancel net/mlx4: remove word abort
net/axgbe: replace word abort

 .../comp_perf_test_cyclecount.c               |  2 +-
 .../comp_perf_test_throughput.c               |  2 +-
 .../comp_perf_test_verify.c                   |  2 +-
 app/test/test_dmadev.c                        |  2 +-
 doc/guides/prog_guide/bpf_lib.rst             |  2 +-
 doc/guides/prog_guide/traffic_management.rst  |  2 +-
 drivers/common/mlx5/mlx5_common_mr.c          |  6 ++--
 drivers/common/mlx5/mlx5_prm.h                |  4 +--
 drivers/dma/hisilicon/hisi_dmadev.c           |  4 +--
 drivers/dma/hisilicon/hisi_dmadev.h           |  2 +-
 drivers/event/dlb2/dlb2.c                     |  2 +-
 drivers/event/dlb2/pf/base/dlb2_resource.c    |  2 +-
 drivers/net/af_xdp/rte_eth_af_xdp.c           |  2 +-
 drivers/net/axgbe/axgbe_common.h              |  4 +--
 drivers/net/axgbe/axgbe_ethdev.h              |  2 +-
 drivers/net/axgbe/axgbe_i2c.c                 | 26 ++++++++---------
 drivers/net/bnx2x/bnx2x.c                     | 18 ++++++------
 drivers/net/bnx2x/bnx2x_vfpf.c                |  4 +--
 drivers/net/bnx2x/ecore_hsi.h                 |  6 ++--
 drivers/net/bnx2x/ecore_reg.h                 | 20 ++++++-------
 drivers/net/ionic/ionic_dev_pci.c             |  6 ++--
 drivers/net/ionic/ionic_ethdev.c              | 18 ++++++------
 drivers/net/ionic/ionic_lif.c                 |  2 +-
 drivers/net/mlx4/mlx4_mr.c                    |  6 ++--
 drivers/net/mlx5/hws/mlx5dr_rule.c            |  8 ++---
 drivers/net/mlx5/hws/mlx5dr_send.c            |  2 +-
 drivers/net/mlx5/hws/mlx5dr_send.h            |  2 +-
 drivers/net/mlx5/linux/mlx5_os.c              |  4 +--
 drivers/net/mlx5/mlx5_rx.c                    |  2 +-
 drivers/net/netvsc/rndis.h                    |  2 +-
 drivers/net/softnic/rte_eth_softnic_cli.c     | 12 ++++----
 drivers/net/vdev_netvsc/vdev_netvsc.c         |  4 +--
 drivers/net/vmxnet3/vmxnet3_rxtx.c            |  6 ++--
 examples/ipsec-secgw/rt.c                     |  4 +--
 examples/l2fwd-jobstats/main.c                |  2 +-
 examples/pipeline/cli.c                       | 20 ++++++-------
 lib/dmadev/rte_dmadev.h                       |  6 ++--
 .../include/generic/rte_power_intrinsics.h    | 10 +++----
 lib/eal/include/generic/rte_rwlock.h          |  4 +--
 lib/eal/include/generic/rte_spinlock.h        |  8 ++---
 lib/eal/include/rte_seqlock.h                 |  2 +-
 lib/eal/x86/include/rte_rtm.h                 | 16 +++++-----
 lib/eal/x86/include/rte_spinlock.h            | 12 ++++----
 lib/eal/x86/rte_power_intrinsics.c            |  8 ++---
 lib/ethdev/rte_tm.h                           |  2 +-
 lib/hash/rte_cuckoo_hash.h                    |  2 +-
 lib/jobstats/rte_jobstats.c                   |  2 +-
 lib/jobstats/rte_jobstats.h                   |  9 +++++-
 lib/jobstats/version.map                      |  2 +-
 lib/pipeline/rte_swx_ctl.c                    | 29 ++++++++++---------
 lib/pipeline/rte_swx_ctl.h                    |  8 ++---
 lib/pipeline/version.map                      |  2 +-
 lib/ring/rte_ring_peek_elem_pvt.h             |  4 +--
 53 files changed, 174 insertions(+), 166 deletions(-)
Signature · 1 line
2.39.2