Skip to content

Introduce nvmet target setup/cleanup helpers

Daniel Wagner linux-block linux-nvme lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 4 repliesIn review
  2. v33 patches 22 repliesSuperseded
  3. v20 of 1 patch 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch1 replySuperseded

Changes in v4 from the cover letter

- introduced _cleanup_blkdev helper
- fixed --blkdev arguments passing
- added unknown argument warning to _nvmet_target_setup argument parser
- added rb tag

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3nvme/{033,034,035,036}: use default subsysnqn variable directlytests/nvme/033 tests/nvme/034 tests/nvme/035 +1 more+17 -210 replies
2/3nvme/{033,034,035,036,37}: drop port handle between passthru target setup and cleanuptests/nvme/033 tests/nvme/034 tests/nvme/035 +3 more+34 -210 replies
3/3nvme: introduce nvmet_target_{setup/cleanup} common codetests/nvme/003 tests/nvme/004 tests/nvme/005 +31 more+145 -5192 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchChaitanya Kulkarni
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH blktests v4 0/3] Introduce nvmet target setup/cleanup helpers

Updated the series according the last round of feedback and retested it. In order to pass the 'make check' check this version depends on the upcoming revert of 26664dff17b6 ("Do not suppress any shellcheck warnings") as discussed in the v3 thread.

original cover letter:

Introduce helpers to setup nvmet targets. This is spin off from the refactoring patches and the allowed_host patches [1].

Sagi suggested to record all resources allocated by nvmet_target_setup and then later clean them up in nvmet_target_cleanup. I opted to figure out in nvmet_target_cleanup what was allocated via the newly introdcuded _get_nvmet_ports helper. The reason being, Hannes told me offline that he would like to add ANA tests which will add some more ports to the subsystem. I hope with this the code is more future proof.

BTW, while looking at this I saw that the passthru code is using the awkward return value port when calling nvmet_passthru_target_setup. It seems some more refactoring is in order...

[1] https://lore.kernel.org/linux-nvme/5h333eqhtw252sjw6axjewlb5bbb5ze7awekczxe3kie2lnhw6@manyer42khct/

changes

v4:
- introduced _cleanup_blkdev helper
- fixed --blkdev arguments passing
- added unknown argument warning to _nvmet_target_setup argument parser
- added rb tag

v3:
- rebased/retested
- use the default with _nvmet_target_setup
- https://lore.kernel.org/linux-nvme/[email protected]/

v2:
- drop local subsys variable in passthru tests
- do not use port as handle in passthru tests
- free port after unregistering from subsys
- https://lore.kernel.org/linux-nvme/[email protected]/

v1:
- https://lore.kernel.org/linux-nvme/[email protected]/

Daniel Wagner (3):
nvme/{033,034,035,036}: use default subsysnqn variable directly nvme/{033,034,035,036,37}: drop port handle between passthru target
setup and cleanup
nvme: introduce nvmet_target_{setup/cleanup} common code

 tests/nvme/003 |  14 ++-----
 tests/nvme/004 |  21 ++--------
 tests/nvme/005 |  20 +---------
 tests/nvme/006 |  19 +--------
 tests/nvme/007 |  14 +------
 tests/nvme/008 |  21 +---------
 tests/nvme/009 |  16 +-------
 tests/nvme/010 |  21 +---------
 tests/nvme/011 |  16 +-------
 tests/nvme/012 |  21 +---------
 tests/nvme/013 |  16 +-------
 tests/nvme/014 |  21 +---------
 tests/nvme/015 |  16 +-------
 tests/nvme/018 |  16 +-------
 tests/nvme/019 |  21 +---------
 tests/nvme/020 |  16 +-------
 tests/nvme/021 |  16 +-------
 tests/nvme/022 |  16 +-------
 tests/nvme/023 |  21 +---------
 tests/nvme/024 |  16 +-------
 tests/nvme/025 |  16 +-------
 tests/nvme/026 |  16 +-------
 tests/nvme/027 |  17 ++------
 tests/nvme/028 |  17 ++------
 tests/nvme/029 |  21 +---------
 tests/nvme/033 |  10 ++---
 tests/nvme/034 |  10 ++---
 tests/nvme/035 |  10 ++---
 tests/nvme/036 |  12 +++---
 tests/nvme/037 |   5 +--
 tests/nvme/040 |  19 +--------
 tests/nvme/041 |  18 +--------
 tests/nvme/042 |  17 +-------
 tests/nvme/043 |  17 +-------
 tests/nvme/044 |  19 ++-------
 tests/nvme/045 |  18 ++-------
 tests/nvme/047 |  21 +---------
 tests/nvme/048 |  17 +-------
 tests/nvme/rc  | 103 ++++++++++++++++++++++++++++++++++++++++++++++---
 39 files changed, 188 insertions(+), 553 deletions(-)
Signature · 1 line
2.41.0