Skip to content

Fix missing caps, fix unnecessary casting/checking

Ian Rogers linux-arm-kernel linux-perf-users lkml 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 0 repliesNew
  2. v11 patch 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6perf header: Fix missing PMU capstools/perf/util/header.c+16 -150 replies
2/6perf pmu: Remove logic for PMU name being NULLtools/perf/arch/arm64/util/mem-events.c tools/perf/arch/powerpc/util/mem-events.c tools/perf/arch/x86/util/mem-events.c +12 more+51 -620 replies
3/6perf parse-events: Make term's config consttools/perf/tests/pmu.c tools/perf/util/parse-events.c tools/perf/util/parse-events.h +1 more+17 -170 replies
4/6perf pmu: Make id const and add missing freetools/perf/tests/pmu-events.c tools/perf/util/pmu.c tools/perf/util/pmu.h+4 -30 replies
5/6perf build-id: Simplify build_id_cache__cachedirtools/perf/util/build-id.c+2 -40 replies
6/6perf tui slang: Tidy caststools/perf/ui/Build tools/perf/ui/browser.c tools/perf/ui/browsers/Build +4 more+15 -340 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/6] Fix missing caps, fix unnecessary casting/checking

Wei Li <[email protected]> reported an issue where writing PMU caps for ARM was broken. Patch 1 addresses this issue.

Patch 2 removes unnecessary checks on a PMU's name by ensuring the fake PMU has a name. Types are updated to have a const as a consequence and a cleanup of the use of types is done for struct pmu's variable name. This was motivated by the discussion:
https://lore.kernel.org/lkml/[email protected]/

Patches 3-5 repeat the const cleanup on struct pmu's name with the variables id and config in struct pmu and struct parse_events_term respectively. This is done for consistency with patch 2.

Patch 6 tidies casts around libslang and removes workarounds for libslang support needed for a libslang older than 15 years - let's say nobody cares about a libslang that is this old.

Ian Rogers (6):
perf header: Fix missing PMU caps
perf pmu: Remove logic for PMU name being NULL perf parse-events: Make term's config const perf pmu: Make id const and add missing free perf build-id: Simplify build_id_cache__cachedir perf tui slang: Tidy casts

 tools/perf/arch/arm64/util/mem-events.c   |  2 +-
 tools/perf/arch/powerpc/util/mem-events.c |  6 ++--
 tools/perf/arch/x86/util/mem-events.c     |  8 ++---
 tools/perf/arch/x86/util/pmu.c            | 10 +++---
 tools/perf/builtin-list.c                 |  2 +-
 tools/perf/tests/pmu-events.c             | 20 ++++++------
 tools/perf/tests/pmu.c                    | 18 +++++------
 tools/perf/ui/Build                       |  2 --
 tools/perf/ui/browser.c                   |  6 ++--
 tools/perf/ui/browsers/Build              |  5 ---
 tools/perf/ui/libslang.h                  | 20 +++---------
 tools/perf/ui/tui/helpline.c              |  2 +-
 tools/perf/ui/tui/setup.c                 |  2 +-
 tools/perf/ui/tui/util.c                  | 12 +++----
 tools/perf/util/build-id.c                |  6 ++--
 tools/perf/util/env.c                     |  8 ++---
 tools/perf/util/header.c                  | 39 ++++++++++-------------
 tools/perf/util/mem-events.c              | 16 +++++-----
 tools/perf/util/mem-events.h              |  2 +-
 tools/perf/util/parse-events.c            | 17 ++++------
 tools/perf/util/parse-events.h            |  6 ++--
 tools/perf/util/parse-events.y            |  2 +-
 tools/perf/util/pmu.c                     | 19 ++++++-----
 tools/perf/util/pmu.h                     | 10 +++---
 24 files changed, 105 insertions(+), 135 deletions(-)
Signature · 7 lines
2.42.0.rc2.253.gd59a3bf2b4-goog


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel