Skip to content

Implement the mmap system call for FreeBSD.

Karim Taha qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 56 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22Implement struct target_ipc_permbsd-user/syscall_defs.h+17 -02 replies
2/22Implement struct target_shmid_dsbsd-user/syscall_defs.h+20 -02 replies
3/22Declarations for ipc_perm and shmid_ds conversion functionsbsd-user/qemu-bsd.h+45 -02 replies
4/22Introduce freebsd/os-misc.h to the source treebsd-user/freebsd/os-misc.h+28 -02 replies
5/22Implement shm_open2(2) system callbsd-user/freebsd/os-misc.h bsd-user/freebsd/os-syscall.c+65 -02 replies
6/22Implement shm_rename(2) system callbsd-user/freebsd/os-misc.h bsd-user/freebsd/os-syscall.c+30 -02 replies
7/22Add bsd-mem.c to meson.buildbsd-user/bsd-mem.c bsd-user/meson.build+1 -02 replies
8/22Implement target_set_brk function in bsd-mem.c instead of os-syscall.cbsd-user/bsd-mem.c bsd-user/freebsd/os-syscall.c+38 -42 replies
9/22Implement ipc_perm conversion between host and target.bsd-user/bsd-mem.c+41 -02 replies
10/22Implement shmid_ds conversion between host and target.bsd-user/bsd-mem.c+46 -04 replies
11/22Introduce bsd-mem.h to the source treebsd-user/bsd-mem.h bsd-user/freebsd/os-syscall.c+66 -02 replies
12/22Implement mmap(2) and munmap(2)bsd-user/bsd-mem.h bsd-user/freebsd/os-syscall.c+29 -02 replies
13/22Implement mprotect(2)bsd-user/bsd-mem.h bsd-user/freebsd/os-syscall.c+11 -02 replies
14/22Implement msync(2)bsd-user/bsd-mem.h bsd-user/freebsd/os-syscall.c+15 -02 replies
15/22Implement mlock(2), munlock(2), mlockall(2), munlockall(2), madvise(2), minherit(2)bsd-user/bsd-mem.h bsd-user/freebsd/os-syscall.c+68 -03 replies
16/22Implement mincore(2)bsd-user/bsd-mem.h bsd-user/freebsd/os-syscall.c+27 -02 replies
17/22Implement do_obreak functionbsd-user/bsd-mem.h bsd-user/freebsd/os-syscall.c+92 -02 replies
18/22Implement shm_open(2)bsd-user/bsd-mem.h bsd-user/freebsd/os-syscall.c+31 -03 replies
19/22Implement shm_unlink(2) and shmget(2)bsd-user/bsd-mem.h bsd-user/freebsd/os-syscall.c+31 -03 replies
20/22Implement shmctl(2)bsd-user/bsd-mem.h bsd-user/freebsd/os-syscall.c+37 -04 replies
21/22Implement shmat(2) and shmdt(2)bsd-user/bsd-mem.h bsd-user/freebsd/os-syscall.c+80 -06 replies
22/22Add stubs for vadvise(), sbrk() and sstk()bsd-user/bsd-mem.h bsd-user/freebsd/os-syscall.c+33 -03 replies

Reviews trailers per patch

19 of 22 patches have a Reviewed-by or Acked-by.

PatchKyle EvansMikaël UrankarRichard HendersonWarner Losh
1/22R-b R-b
2/22R-b R-b
3/22R-b R-b
4/22R-b R-b
5/22
6/22R-b R-b
7/22R-b R-b
8/22Co-authored-by R-b R-b
9/22R-b R-b
10/22R-b R-b
11/22R-b R-b
12/22R-b R-b
13/22R-b R-b
14/22Co-authored-by R-b R-b
15/22R-b
16/22R-b
17/22Co-authored-by
18/22Co-authored-by R-b
19/22R-b R-b R-b
20/22R-b
21/22
22/22R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 00/22] Implement the mmap system call for FreeBSD.

Upstream the implementation of the following mmap system calls, from the qemu-bsd-user fork:
mmap(2), munmap(2), mprotect(2), msync(2), mlock(2), munlock(2), mlockall(2) munlockall(2), madvise(2), minherit(2), mincore(2), shm_open(2),shm_open2(2), shm_rename2(2), shm_unlink(2), shmget(2), shmctl(2), shmat(2), shmdt(2)

Karim Taha (1):
Add bsd-mem.c to meson.build

Kyle Evans (2):
Implement shm_open2(2) system call
Implement shm_rename(2) system call

Stacey Son (19):
Implement struct target_ipc_perm
Implement struct target_shmid_ds
Declarations for ipc_perm and shmid_ds conversion functions Introduce freebsd/os-misc.h to the source tree
Implement target_set_brk function in bsd-mem.c instead of os-syscall.c Implement ipc_perm conversion between host and target. Implement shmid_ds conversion between host and target. Introduce bsd-mem.h to the source tree
Implement mmap(2) and munmap(2)
Implement mprotect(2)
Implement msync(2)
Implement mlock(2), munlock(2), mlockall(2), munlockall(2),

    madvise(2), minherit(2)

Implement mincore(2)
Implement do_obreak function
Implement shm_open(2)
Implement shm_unlink(2) and shmget(2)
Implement shmctl(2)
Implement shmat(2) and shmdt(2)
Add stubs for vadvise(), sbrk() and sstk()

 bsd-user/bsd-mem.c            | 125 ++++++++++
 bsd-user/bsd-mem.h            | 431 ++++++++++++++++++++++++++++++++++
 bsd-user/freebsd/os-misc.h    | 104 ++++++++
 bsd-user/freebsd/os-syscall.c | 112 ++++++++-
 bsd-user/meson.build          |   1 +
 bsd-user/qemu-bsd.h           |  45 ++++
 bsd-user/syscall_defs.h       |  37 +++
 7 files changed, 851 insertions(+), 4 deletions(-)
 create mode 100644 bsd-user/bsd-mem.c
 create mode 100644 bsd-user/bsd-mem.h
 create mode 100644 bsd-user/freebsd/os-misc.h
 create mode 100644 bsd-user/qemu-bsd.h
Signature · 1 line
2.40.0