Skip to content

Reduce cost of accessing tg->load_avg

Aaron Lu lkml oe-lkp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 12 repliesIn review

Changes in v1 from the cover letter

- drop RFC;
- move cfs_rq->last_update_tg_load_avg before cfs_rq->tg_load_avg_contrib;
- add Vincent's reviewed-by tag.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1sched/fair: ratelimit update to tg->load_avgkernel/sched/fair.c kernel/sched/sched.h+13 -110 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchVincent GuittotMathieu DesnoyersDavid VernetSwapnil Sapkal
SeriesT-b
1/1R-b R-b T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/1] Reduce cost of accessing tg->load_avg

RFC v2 -> v1:
- drop RFC;
- move cfs_rq->last_update_tg_load_avg before cfs_rq->tg_load_avg_contrib;
- add Vincent's reviewed-by tag.

RFC v2:
Nitin Tekchandani noticed some scheduler functions have high cost according to perf/cycles while running postgres_sysbench workload. I perf/annotated the high cost functions: update_cfs_group() and update_load_avg() and found the costs were ~90% due to accessing to tg->load_avg. This series is an attempt to reduce the overhead of the two functions.

Thanks to Vincent's suggestion from v1, this revision used a simpler way to solve the overhead problem by limiting updates to tg->load_avg to at most once per ms. Benchmark shows that it has good results and with the rate limit in place, other optimizations in v1 don't improve performance further so they are dropped from this revision.

Aaron Lu (1):
sched/fair: ratelimit update to tg->load_avg

 kernel/sched/fair.c  | 13 ++++++++++++-
 kernel/sched/sched.h |  1 +
 2 files changed, 13 insertions(+), 1 deletion(-)
Signature · 1 line
2.41.0