Skip to content

Lazily load PMU data

Ian Rogers linux-perf-users lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest18 patches 20 repliesIn review
  2. v125 patches 6 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18perf pmu: Make the loading of formats lazytools/perf/tests/pmu.c tools/perf/util/pmu.c tools/perf/util/pmu.h +1 more+106 -650 replies
2/18perf pmu: Abstract alias/event structtools/perf/bench/pmu-scan.c tools/perf/tests/pmu-events.c tools/perf/util/parse-events.c +3 more+366 -3230 replies
3/18perf pmu-events: Add extra underscore to function namestools/perf/pmu-events/empty-pmu-events.c tools/perf/pmu-events/jevents.py tools/perf/pmu-events/pmu-events.h +4 more+22 -220 replies
4/18perf jevents: Group events by PMUtools/perf/pmu-events/jevents.py tools/perf/tests/pmu-events.c+154 -572 replies
5/18perf parse-events: Improve error message for double settingtools/perf/util/parse-events.c tools/perf/util/pmu.c tools/perf/util/pmu.h+29 -90 replies
6/18perf s390 s390_cpumcfdg_dump: Don't scan all PMUstools/perf/util/s390-sample-raw.c+26 -2416 replies
7/18perf pmu-events: Reduce processed events by passing PMUtools/perf/pmu-events/empty-pmu-events.c tools/perf/pmu-events/jevents.py tools/perf/pmu-events/pmu-events.h +3 more+41 -380 replies
8/18perf pmu-events: Add pmu_events_table__find_eventtools/perf/pmu-events/empty-pmu-events.c tools/perf/pmu-events/jevents.py tools/perf/pmu-events/pmu-events.h +1 more+90 -00 replies
9/18perf pmu: Parse sysfs events directly from a filetools/perf/arch/x86/util/intel-pt.c tools/perf/tests/parse-events.c tools/perf/util/parse-events.c +2 more+33 -400 replies
10/18perf pmu: Prefer passing pmu to aliases listtools/perf/util/pmu.c+16 -280 replies
11/18perf pmu: Merge json events with sysfs at load timetools/perf/util/pmu.c+88 -890 replies
12/18perf pmu: Cache json events tabletools/perf/pmu-events/jevents.py tools/perf/tests/pmu-events.c tools/perf/util/pmu.c +1 more+25 -110 replies
13/18perf pmu: Lazily add json eventstools/perf/pmu-events/empty-pmu-events.c tools/perf/pmu-events/jevents.py tools/perf/pmu-events/pmu-events.h +3 more+85 -150 replies
14/18perf pmu: Scan type early to fail an invalid PMU quicklytools/perf/util/pmu.c+12 -70 replies
15/18perf pmu: Be lazy about loading event info files from sysfstools/perf/util/pmu.c+83 -450 replies
16/18perf pmu: Lazily load sysfs aliasestools/perf/tests/pmu-events.c tools/perf/util/pmu.c tools/perf/util/pmu.h+46 -390 replies
17/18perf jevents: Sort strings in the big C string to reduce faultstools/perf/pmu-events/jevents.py+23 -80 replies
18/18perf jevents: Don't append Unit to desctools/perf/builtin-list.c tools/perf/pmu-events/jevents.py+12 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/18] Lazily load PMU data

Lazily load PMU data both from sysfs and json files. Reorganize json data to be more PMU oriented to facilitate this, for example, json data is now sorted into arrays for their PMU.

In refactoring the code some changes were made to get rid of maximum encoding sizes for events (256 bytes), with input files being directly passed to the lex generated code. There is also a small event parse error message improvement.

Some results from an Intel tigerlake laptop running Debian:

Binary size reduction of 5.3% or 552,864 bytes because the PMU name no longer appears in the string or desc field.

stat -e cpu/cycles/ minor faults reduced from 1733 to 1667, open calls reduced from 171 to 94.

stat default minor faults reduced from 1805 to 1717, open calls reduced from 654 to 343.

Average PMU scanning reduced from 4720.641usec to 2927.293usec. Average core PMU scanning reduced from 1004.658usec to 232.668usec (4.3x faster).

v2: Add error path for failing strdup when allocating a format,
suggested by Arnaldo. Rebased on top of tmp.perf-tools-next removing 8 patches. Added "perf jevents: Don't append Unit to desc" to save yet more encoding json event space.

Ian Rogers (18):
perf pmu: Make the loading of formats lazy
perf pmu: Abstract alias/event struct
perf pmu-events: Add extra underscore to function names perf jevents: Group events by PMU
perf parse-events: Improve error message for double setting perf s390 s390_cpumcfdg_dump: Don't scan all PMUs perf pmu-events: Reduce processed events by passing PMU perf pmu-events: Add pmu_events_table__find_event perf pmu: Parse sysfs events directly from a file perf pmu: Prefer passing pmu to aliases list
perf pmu: Merge json events with sysfs at load time perf pmu: Cache json events table
perf pmu: Lazily add json events
perf pmu: Scan type early to fail an invalid PMU quickly perf pmu: Be lazy about loading event info files from sysfs perf pmu: Lazily load sysfs aliases
perf jevents: Sort strings in the big C string to reduce faults perf jevents: Don't append Unit to desc

 tools/perf/arch/x86/util/intel-pt.c      |   2 +-
 tools/perf/bench/pmu-scan.c              |   8 +-
 tools/perf/builtin-list.c                |  13 +-
 tools/perf/pmu-events/empty-pmu-events.c |  49 +-
 tools/perf/pmu-events/jevents.py         | 312 +++++++--
 tools/perf/pmu-events/pmu-events.h       |  15 +-
 tools/perf/tests/parse-events.c          |   2 +-
 tools/perf/tests/pmu-events.c            | 148 +++--
 tools/perf/tests/pmu.c                   |   2 +-
 tools/perf/util/metricgroup.c            |  10 +-
 tools/perf/util/parse-events.c           |  87 ++-
 tools/perf/util/parse-events.h           |   3 +-
 tools/perf/util/pmu.c                    | 806 +++++++++++++++--------
 tools/perf/util/pmu.h                    |  96 ++-
 tools/perf/util/pmu.y                    |  20 +-
 tools/perf/util/pmus.c                   | 230 +++----
 tools/perf/util/s390-sample-raw.c        |  50 +-
 17 files changed, 1141 insertions(+), 712 deletions(-)
Signature · 1 line
2.42.0.rc1.204.g551eb34607-goog