Skip to content

cleanup base includes and add <nft.h> header

Thomas Haller netfilter-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 1 replyIn review
  2. v16 patches 3 repliesSuperseded

Changes to v1 from the cover letter

- rename <nftdefault.h> to <nft.h>
- move AC_USE_SYSTEM_EXTENSIONS earlier in configure.ac. It must be called before other compiler steps.
- reword commit messages.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6meta: define _GNU_SOURCE to get strptime() from <time.h>src/meta.c+3 -40 replies
2/6src: add <nft.h> header and include it as firstinclude/Makefile.am include/cli.h include/gmputil.h +51 more+108 -130 replies
3/6include: don't define _GNU_SOURCE in public headerinclude/nftables/libnftables.h+0 -10 replies
4/6configure: use AC_USE_SYSTEM_EXTENSIONS to get _GNU_SOURCEconfigure.ac include/nft.h+3 -20 replies
5/6include: include <std{bool,int}.h> via <nft.h>include/datatype.h include/dccpopt.h include/expression.h +21 more+3 -240 replies
6/6configure: drop AM_PROG_CC_C_O autoconf checkconfigure.ac+0 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH nft v2 0/6] cleanup base includes and add <nft.h> header

Changes to v1:
- rename <nftdefault.h> to <nft.h>
- move AC_USE_SYSTEM_EXTENSIONS earlier in configure.ac. It must be called before other compiler steps.
- reword commit messages.

Thomas Haller (6):
meta: define _GNU_SOURCE to get strptime() from <time.h>
src: add <nft.h> header and include it as first
include: don't define _GNU_SOURCE in public header
configure: use AC_USE_SYSTEM_EXTENSIONS to get _GNU_SOURCE
include: include <std{bool,int}.h> via <nft.h>
configure: drop AM_PROG_CC_C_O autoconf check

 configure.ac                   |  4 +++-
 include/Makefile.am            |  3 ++-
 include/cli.h                  |  1 -
 include/datatype.h             |  1 -
 include/dccpopt.h              |  1 -
 include/expression.h           |  1 -
 include/gmputil.h              |  2 --
 include/nft.h                  | 10 ++++++++++
 include/nftables.h             |  1 -
 include/nftables/libnftables.h |  1 -
 include/rule.h                 |  1 -
 include/utils.h                |  3 ---
 src/cache.c                    |  2 ++
 src/cli.c                      |  3 ++-
 src/cmd.c                      |  2 ++
 src/ct.c                       |  2 ++
 src/datatype.c                 |  2 ++
 src/dccpopt.c                  |  3 ++-
 src/erec.c                     |  4 ++--
 src/evaluate.c                 |  3 ++-
 src/expression.c               |  3 ++-
 src/exthdr.c                   |  3 ++-
 src/fib.c                      |  2 ++
 src/gmputil.c                  |  2 ++
 src/hash.c                     |  2 ++
 src/iface.c                    |  2 ++
 src/intervals.c                |  2 ++
 src/ipopt.c                    |  3 ++-
 src/json.c                     |  3 ++-
 src/libnftables.c              |  3 +++
 src/main.c                     |  2 ++
 src/mergesort.c                |  3 ++-
 src/meta.c                     |  8 +++-----
 src/mini-gmp.c                 |  2 ++
 src/misspell.c                 |  2 ++
 src/mnl.c                      |  2 ++
 src/monitor.c                  |  2 ++
 src/netlink.c                  |  2 ++
 src/netlink_delinearize.c      |  3 ++-
 src/netlink_linearize.c        |  2 ++
 src/nfnl_osf.c                 |  2 ++
 src/nftutils.c                 |  3 +--
 src/nftutils.h                 |  1 -
 src/numgen.c                   |  2 ++
 src/optimize.c                 |  3 ++-
 src/osf.c                      |  2 ++
 src/owner.c                    |  2 ++
 src/parser_json.c              |  4 ++--
 src/payload.c                  |  3 ++-
 src/print.c                    |  2 ++
 src/proto.c                    |  3 ++-
 src/rt.c                       |  3 ++-
 src/rule.c                     |  3 ++-
 src/scanner.l                  |  2 ++
 src/sctp_chunk.c               |  2 ++
 src/segtree.c                  |  2 ++
 src/socket.c                   |  2 ++
 src/statement.c                |  3 ++-
 src/tcpopt.c                   |  3 ++-
 src/utils.c                    |  2 ++
 src/xfrm.c                     |  2 ++
 src/xt.c                       |  2 ++
 62 files changed, 114 insertions(+), 42 deletions(-)
 create mode 100644 include/nft.h
Signature · 1 line
2.41.0