Skip to content

docs tests: Fix use of migrate_set_parameter

Markus Armbruster qemu-devel qemu-trivial 1 version Applied

Status from this message: Applied to my trivial-patches tree. Thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2docs tests: Fix use of migrate_set_parameterdocs/multi-thread-compression.txt docs/rdma.txt tests/qemu-iotests/181 +1 more+11 -111 reply
2/2tests/qtest/test-hmp: Fix migrate_set_parameter xbzrle-cache-size testtests/qtest/test-hmp.c+1 -11 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchThomas Huth
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] docs tests: Fix use of migrate_set_parameter

I spotted a bad use of migrate_set_parameter in test-hmp.c, and looked for more.

I also looked for more failing HMP commands in test-hmp.c. I found some, but they fail only on some machines, which feels okay. They are:

* device_add usb-mouse,id=mouse1
device_del mouse1

Fail when the device is not compiled in, and when the machine doesn't provide USB.

* memsave 0 4096 "/dev/null"

Fails when the machine doesn't have memory there.

* screendump /dev/null

Fails when there is no console.

* dump-guest-memory /dev/null 0 4096

Fails for targets that don't support dumping, and when the machine doesn't have memory there.

* nmi

Fails when the machine doesn't provide NMIs.

Markus Armbruster (2):
docs tests: Fix use of migrate_set_parameter tests/qtest/test-hmp: Fix migrate_set_parameter xbzrle-cache-size test

 docs/multi-thread-compression.txt | 12 ++++++------
 docs/rdma.txt                     |  2 +-
 tests/qtest/test-hmp.c            |  6 +++---
 tests/qemu-iotests/181            |  2 +-
 4 files changed, 11 insertions(+), 11 deletions(-)
Signature · 1 line
2.41.0