Skip to content

nvme-tcp: always set valid seq_num in dhchap reply

Mark O'Donovan linux-nvme lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 3 repliesIn review
  2. v23 patches 7 repliesSuperseded
  3. v12 patches 5 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3nvme-auth: auth success1 msg always includes respdrivers/nvme/host/auth.c include/linux/nvme.h+2 -50 replies
2/3nvme-auth: add flag for bi-directional authdrivers/nvme/host/auth.c+4 -11 reply
3/3nvme-auth: always set valid seq_num in dhchap replydrivers/nvme/host/auth.c drivers/nvme/target/fabrics-cmd-auth.c+2 -31 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigHannes ReineckeSagi Grimberg
1/3R-b R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/3] nvme-tcp: always set valid seq_num in dhchap reply

The first patch is a small unrelated fix which makes it clear that the response data section of the Success1 message is not optional.

The second patch removes use of the host sequence number (S2) as an indicator of bi-directional authentication.

The third patch causes us to always set the host sequence number (S2) to a non-zero value instead of the 0 value reserved for the secure channel feature.

v1: original submission
v2: rebased + added dedicated variable for bi-directional auth
v3: nvme-target code now reads seq-num

Mark O'Donovan (3):
nvme-auth: auth success1 msg always includes resp
nvme-auth: add flag for bi-directional auth
nvme-auth: always set valid seq_num in dhchap reply

 drivers/nvme/host/auth.c               | 13 ++++++-------
 drivers/nvme/target/fabrics-cmd-auth.c |  2 +-
 include/linux/nvme.h                   |  2 +-
 3 files changed, 8 insertions(+), 9 deletions(-)

base-commit: 4f82870119a46b0d04d91ef4697ac4977a255a9d

Signature · 1 line
2.39.2