Skip to content

ocfs2: Replace strlcpy with strscpy

Azeem Shaikh linux-hardening lkml ocfs2-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ocfs2: Replace module_param_call with module_param_cbfs/ocfs2/dlmfs/dlmfs.c+5 -21 reply
2/2ocfs2: Replace strlcpy with strscpyfs/ocfs2/dlmfs/dlmfs.c+1 -14 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] ocfs2: Replace strlcpy with strscpy

Hi,

The main patch this series is targeting is [PATCH 2] which replaces strlcpy() call with strscpy(). However, while I was tinkering through the code I noticed that module_param_call is marked obsolete and module_param_cb is preferred instead. So I have included [PATCH 1] which does that.

A crucial thing in [PATCH 2] I would like to bring to reviewer's attention is that it changes behavior for the case where sizeof(@buffer) < DLMFS_CAPABILITIES. Currently, this is silently ignored but with the current change it returns -errno.

Thanks,
Azeem

Azeem Shaikh (2):
Replace module_param_call with module_param_cb
Replace strlcpy with strscpy

 fs/ocfs2/dlmfs/dlmfs.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

--
2.42.0.283.g2d96d420d3-goog