Skip to content

perf: strcmp_cpuid_str() expression fixups

James Clark linux-arm-kernel linux-perf-users lkml 3 versions – Applied

Status from this message: Applied to perf-tools-next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 7 repliesApplied
  2. v27 patches 0 repliesSuperseded
  3. v17 patches 6 repliesSuperseded

Changes in v3 from the cover letter

* Drop patches that were already applied (which makes the cover letter mostly redundant)
* Avoid generating the compiler warning reported here [2]

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3perf pmu: Move pmu__find_core_pmu() to pmus.ctools/perf/arch/arm64/util/pmu.c tools/perf/tests/expr.c tools/perf/util/expr.c +3 more+25 -242 replies
2/3perf pmus: Simplify perf_pmus__find_core_pmu()tools/perf/arch/arm64/util/pmu.c tools/perf/util/pmus.c+8 -142 replies
3/3perf pmu: Remove unused functiontools/perf/arch/arm64/util/pmu.c tools/perf/util/pmu.c tools/perf/util/pmu.h+0 -162 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchIan RogersJohn Garry
1/3R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] perf: strcmp_cpuid_str() expression fixups

Set of fixes related to the comments here [1]. Mainly cleanups, additional tests and refactoring since adding the new strcmp_cpuid_str() metric expression.

I added the string replace function to the perf utils rather than tools/lib/string.c because it didn't seem easy to add tests for tools/lib.

[1]: https://lore.kernel.org/linux-arm-kernel/CAP-5=fVnUx0BnJC7X1rrm42OD7Bk=ZsHWNwAZMBYyB7yWhBfhQ@mail.gmail.com/
[2]: https://lore.kernel.org/linux-perf-users/[email protected]/

---
Changes since v2:
* Drop patches that were already applied (which makes the cover letter mostly redundant)
* Avoid generating the compiler warning reported here [2]

Changes since v1:
* s -> haystack
* find -> needle

James Clark (3):
perf pmu: Move pmu__find_core_pmu() to pmus.c
perf pmus: Simplify perf_pmus__find_core_pmu()
perf pmu: Remove unused function

 tools/perf/arch/arm64/util/pmu.c | 20 ++++++++------------
 tools/perf/tests/expr.c          |  2 +-
 tools/perf/util/expr.c           |  2 +-
 tools/perf/util/pmu.c            | 22 ----------------------
 tools/perf/util/pmu.h            |  3 +--
 tools/perf/util/pmus.c           |  8 +++++++-
 6 files changed, 18 insertions(+), 39 deletions(-)
Signature · 1 line
2.34.1