perf: strcmp_cpuid_str() expression fixups
Status from this message: Applied to perf-tools-next, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest3 patches 7 repliesApplied
- v27 patches 0 repliesSuperseded
- v17 patches 6 repliesSuperseded
Changes in v3 from the cover letter
* Drop patches that were already applied (which makes the cover letter mostly redundant)
* Avoid generating the compiler warning reported here [2]
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | perf pmu: Move pmu__find_core_pmu() to pmus.ctools/ tools/ tools/ +3 more | +25 | 2 replies | |
| 2/3 | perf pmus: Simplify perf_pmus__find_core_pmu()tools/ tools/ | +8 | 2 replies | |
| 3/3 | perf pmu: Remove unused functiontools/ tools/ tools/ | +0 | 2 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Ian Rogers | John Garry |
|---|---|---|
| 1/3 | R-b | R-b |
| 2/3 | R-b | R-b |
| 3/3 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/3] perf: strcmp_cpuid_str() expression fixups
Set of fixes related to the comments here [1]. Mainly cleanups, additional tests and refactoring since adding the new strcmp_cpuid_str() metric expression.
I added the string replace function to the perf utils rather than tools/lib/string.c because it didn't seem easy to add tests for tools/lib.
[1]: https://lore.kernel.org/linux-arm-kernel/CAP-5=fVnUx0BnJC7X1rrm42OD7Bk=ZsHWNwAZMBYyB7yWhBfhQ@mail.gmail.com/
[2]: https://lore.kernel.org/linux-perf-users/[email protected]/
---
Changes since v2:
* Drop patches that were already applied (which makes the cover letter mostly redundant)
* Avoid generating the compiler warning reported here [2]
Changes since v1:
* s -> haystack
* find -> needle
James Clark (3):
perf pmu: Move pmu__find_core_pmu() to pmus.c
perf pmus: Simplify perf_pmus__find_core_pmu()
perf pmu: Remove unused function
tools/perf/arch/arm64/util/pmu.c | 20 ++++++++------------ tools/perf/tests/expr.c | 2 +- tools/perf/util/expr.c | 2 +- tools/perf/util/pmu.c | 22 ---------------------- tools/perf/util/pmu.h | 3 +-- tools/perf/util/pmus.c | 8 +++++++- 6 files changed, 18 insertions(+), 39 deletions(-)
Signature · 1 line
2.34.1