Skip to content

target/mips: Convert Loongson LEXT opcodes to decodetree

Philippe Mathieu-Daudé qemu-devel 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 3 repliesIn review
  2. v11 patch 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7target/mips: Simplify Loongson MULTU.G opcodetarget/mips/tcg/translate.c+0 -21 reply
2/7target/mips: Re-introduce OPC_ADDUH_QB_DSP and OPC_MUL_PH_DSPtarget/mips/tcg/translate.c+5 -130 replies
3/7target/mips: Convert Loongson DDIV.G opcodes to decodetreetarget/mips/tcg/godson2.decode target/mips/tcg/loong-ext.decode target/mips/tcg/loong_translate.c +3 more+125 -230 replies
4/7target/mips: Convert Loongson DIV.G opcodes to decodetreetarget/mips/tcg/godson2.decode target/mips/tcg/loong-ext.decode target/mips/tcg/loong_translate.c +1 more+24 -320 replies
5/7target/mips: Convert Loongson [D]DIVU.G opcodes to decodetreetarget/mips/tcg/godson2.decode target/mips/tcg/loong-ext.decode target/mips/tcg/loong_translate.c +1 more+58 -370 replies
6/7target/mips: Convert Loongson [D]MOD[U].G opcodes to decodetreetarget/mips/tcg/godson2.decode target/mips/tcg/loong-ext.decode target/mips/tcg/loong_translate.c +1 more+121 -820 replies
7/7target/mips: Convert Loongson [D]MULT[U].G opcodes to decodetreetarget/mips/tcg/godson2.decode target/mips/tcg/loong-ext.decode target/mips/tcg/loong_translate.c +1 more+49 -712 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchRichard HendersonJiaxun Yang
1/7R-b
2/7R-b R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] target/mips: Convert Loongson LEXT opcodes to decodetree

Respin of old series...

Since v1 [*]:
- Fixed '!is_double' check (rth)
- Rebased (removing tcg_temp_free calls)
- Simplified MULT[U].G (rth)
- Added R-b

Cover from v1:

Loongson is next step in the "MIPS decodetree conversion" epic. Start with the simplest extension.

The diffstat addition comes from the TCG functions expanded. The code is easier to review now.
IMO this is also a good template to show how easy a decodetree conversion can be (and how nice the .decode file is to review) :P

Please review,

Phil.

Based-on: <[email protected]>
"target/mips: Simplify Loongson MULTU.G opcode"

[*] https://lore.kernel.org/qemu-devel/[email protected]/

Philippe Mathieu-Daudé (7):
target/mips: Simplify Loongson MULTU.G opcode target/mips: Re-introduce OPC_ADDUH_QB_DSP and OPC_MUL_PH_DSP target/mips: Convert Loongson DDIV.G opcodes to decodetree target/mips: Convert Loongson DIV.G opcodes to decodetree target/mips: Convert Loongson [D]DIVU.G opcodes to decodetree target/mips: Convert Loongson [D]MOD[U].G opcodes to decodetree target/mips: Convert Loongson [D]MULT[U].G opcodes to decodetree

 target/mips/tcg/translate.h       |   1 +
 target/mips/tcg/godson2.decode    |  27 +++
 target/mips/tcg/loong-ext.decode  |  28 +++
 target/mips/tcg/loong_translate.c | 307 ++++++++++++++++++++++++++++++
 target/mips/tcg/translate.c       | 264 +------------------------
 target/mips/tcg/meson.build       |   3 +
 6 files changed, 376 insertions(+), 254 deletions(-)
 create mode 100644 target/mips/tcg/godson2.decode
 create mode 100644 target/mips/tcg/loong-ext.decode
 create mode 100644 target/mips/tcg/loong_translate.c
Signature · 1 line
2.41.0