Skip to content

irqchip/gic-v3: Enable non-coherent GIC designs probing

Lorenzo Pieralisi acpica-devel linux-acpi linux-arm-kernel lkml 6 versions – Applied

Status from this message: The following commit has been merged into the irq/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest1 patch 0 repliesApplied
  2. v51 patch 6 repliesSuperseded
  3. v43 patches 12 repliesApplied
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v35 patches7 repliesApplied
v22 patches5 repliesSuperseded
v12 patches17 repliesSuperseded

Changes in v6 from the cover letter

- Rebased against v6.10-rc1
- Added Marc Zyngier's ACK

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/1irqchip/gic-v3: Enable non-coherent redistributors/ITSes ACPI probingdrivers/acpi/processor_core.c drivers/irqchip/irq-gic-v3-its.c drivers/irqchip/irq-gic-v3.c +1 more+31 -04 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchRobin MurphyMarc Zyngier
1/1R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/1] irqchip/gic-v3: Enable non-coherent GIC designs probing

This series is v6 of previous series:

v5: https://lore.kernel.org/all/[email protected]
v4: https://lore.kernel.org/all/[email protected]
v3: https://lore.kernel.org/all/[email protected]
v2: https://lore.kernel.org/all/[email protected]
v1: https://lore.kernel.org/all/[email protected]

v5 -> v6
- Rebased against v6.10-rc1
- Added Marc Zyngier's ACK

v4 -> v5
- ACPICA patches merged for v6.8
- Refactored ACPI parsing code according to review
- Rebased against v6.8-rc1

v3 -> v4:
- Dropped patches [1-3], already merged
- Added Linuxized ACPICA changes accepted upstream
- Rebased against v6.7-rc3

v2 -> v3:
- Added ACPICA temporary changes and ACPI changes to implement ECR https://bugzilla.tianocore.org/show_bug.cgi?id=4557
- ACPI changes are for testing purposes - subject to ECR code first approval

v1 -> v2:
- Updated DT bindings as per feedback
- Updated patch[2] to use GIC quirks infrastructure

Original cover letter
---
The GICv3 architecture specifications provide a means for the system programmer to set the shareability and cacheability attributes the GIC components (redistributors and ITSes) use to drive memory transactions.

Albeit the architecture give control over shareability/cacheability memory transactions attributes (and barriers), it is allowed to connect the GIC interconnect ports to non-coherent memory ports on the interconnect, basically tying off shareability/cacheability "wires" and de-facto making the redistributors and ITSes non-coherent memory observers.

This series aims at starting a discussion over a possible solution to this problem, by adding to the GIC device tree bindings the standard dma-noncoherent property. The GIC driver uses the property to force the redistributors and ITSes shareability attributes to non-shareable, which consequently forces the driver to use CMOs on GIC memory tables.

On ARM DT DMA is default non-coherent, so the GIC driver can't rely on the generic DT dma-coherent/non-coherent property management layer (of_dma_is_coherent()) which would default all GIC designs in the field as non-coherent; it has to rely on ad-hoc dma-noncoherent property handling.

When a consistent approach is agreed upon for DT an equivalent binding will be put forward for ACPI based systems.

Lorenzo Pieralisi (1):
irqchip/gic-v3: Enable non-coherent redistributors/ITSes ACPI probing

 drivers/acpi/processor_core.c    | 15 +++++++++++++++
 drivers/irqchip/irq-gic-v3-its.c |  4 ++++
 drivers/irqchip/irq-gic-v3.c     |  9 +++++++++
 include/linux/acpi.h             |  3 +++
 4 files changed, 31 insertions(+)
Signature · 1 line
2.34.1