Skip to content

Improve ioctl02.c

Marius Kittler ltp 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest4 patches 7 repliesIn review
  2. v84 patches 10 repliesSuperseded
  3. v75 patches 4 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v64 patches2 repliesSuperseded
v54 patches0 repliesSuperseded
v42 patches3 repliesSuperseded
v34 patches1 replySuperseded
v23 patches0 repliesSuperseded
v12 patches2 repliesSuperseded

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Refactor ioctl02.c to use the new test APItestcases/kernel/syscalls/ioctl/ioctl02.c+88 -3261 reply
2/4Make checks for termio flags more stricttestcases/kernel/syscalls/ioctl/ioctl02.c+5 -81 reply
3/4Remove disabled code in ioctl02.ctestcases/kernel/syscalls/ioctl/ioctl02.c+0 -142 replies
4/4Extend ioctl02 to test termio and termiostestcases/kernel/syscalls/ioctl/ioctl02.c+119 -723 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchPetr Vorel
1/4R-b
2/4R-b
3/4R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [LTP] [PATCH v9 0/4] Improve ioctl02.c

I fixed the closing of parentfd but only in the last patch because in the first patch the cleanup function already takes care of it sufficiently.

I also used TCIOFLUSH as suggested in the review.

I also fixed the spelling of one of the macros.

Marius Kittler (4):
Refactor ioctl02.c to use the new test API
Make checks for termio flags more strict
Remove disabled code in ioctl02.c
Extend ioctl02 to test termio and termios

 testcases/kernel/syscalls/ioctl/ioctl02.c | 552 +++++++---------------
 1 file changed, 172 insertions(+), 380 deletions(-)
Signature · 5 lines
2.42.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp