Skip to content

cxl, EINJ: Update EINJ for CXL error types

Ben Cheatham linux-acpi linux-cxl oe-kbuild-all 13 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v15 Latest4 patches 8 repliesIn review
  2. v144 patches 17 repliesSuperseded
  3. v134 patches 14 repliesSuperseded
Earlier versions · 10
VersionPostedPatchesRepliesStatus
v123 patches14 repliesSuperseded
v114 patches16 repliesSuperseded
v105 patches3 repliesSuperseded
v95 patches8 repliesSuperseded
v85 patches13 repliesSuperseded
v75 patches10 repliesSuperseded
v65 patches1 replySuperseded
v53 patches16 repliesSuperseded
v43 patches6 repliesSuperseded
v33 patches0 repliesSuperseded

Changes in v15 from the cover letter

- Update commit messages for patches 2/4 & 3/4 (Tony)
- Add line to cover letter about CXL 2.0+ errors being available under legacy EINJ interface
- Add einj_cxl_rch_error_inject() for CXL 1.0/1.1 error injections in einj-core.c
- Remove checks for einj_initialized in einj_cxl_*_inject functions in einj-cxl.c (Dan)
- Update commit message for patch 1/4 from recommending checking einj_is_initialized() to a more generic "safegaurd against EINJ not being initialized"
- Use more specific headers in einj-cxl.c and einj-cxl.h (Jonathan)
- Use ACPI_APEI_EINJ_CXL_* defines in place of BIT() macros in einj_cxl_error_type_string struct (Jonathan)
- Move error_type_get() above einj_validate_error_type() to cleanup diff (Jonathan)

Patches in v15 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4EINJ: Migrate to a platform driverdrivers/acpi/apei/einj.c+44 -40 replies
2/4EINJ: Add CXL error type supportMAINTAINERS drivers/acpi/apei/Kconfig drivers/acpi/apei/Makefile +4 more+252 -186 replies
3/4cxl/core: Add CXL EINJ debugfs filesDocumentation/ABI/testing/debugfs-cxl drivers/cxl/core/port.c+72 -02 replies
4/4EINJ, Documentation: Update EINJ kernel docDocumentation/firmware-guide/acpi/apei/einj.rst+34 -00 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchJonathan CameronDan Williams
1/4R-b R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v15 thread

Cover letter [PATCH v15 0/4] cxl, EINJ: Update EINJ for CXL error types

v15 Changes:
- Update commit messages for patches 2/4 & 3/4 (Tony)
- Add line to cover letter about CXL 2.0+ errors being available under legacy EINJ interface
- Add einj_cxl_rch_error_inject() for CXL 1.0/1.1 error injections in einj-core.c
- Remove checks for einj_initialized in einj_cxl_*_inject functions in einj-cxl.c (Dan)
- Update commit message for patch 1/4 from recommending checking einj_is_initialized() to a more generic "safegaurd against EINJ not being initialized"
- Use more specific headers in einj-cxl.c and einj-cxl.h (Jonathan)
- Use ACPI_APEI_EINJ_CXL_* defines in place of BIT() macros in einj_cxl_error_type_string struct (Jonathan)
- Move error_type_get() above einj_validate_error_type() to cleanup diff (Jonathan)

v14 Changes:
- Remove einj-cxl module and instead compile as part of EINJ module (Dan)
- Change CONFIG_ACPI_APEI_EINJ_CXL from tristate to bool (Dan)
- Fix CONFIG_ACPI_APEI_EINJ_CXL/CONFIG_CXL_BUS dependencies
- Remove EINJ function exports (Dan)
- Organizational changes for CXL content in EINJ kernel documentation (Dan)
- Demote "EINJ table not found." print to pr_debug() from pr_info() (Dan)

The new CXL error types will use the Memory Address field in the SET_ERROR_TYPE_WITH_ADDRESS structure in order to target a CXL 1.1 compliant memory-mapped downstream port. The value of the memory address will be in the port's MMIO range, and it will not represent physical (normal or persistent) memory.

Add the functionality for injecting CXL 1.1/2.0+ errors to the EINJ module, but not through the EINJ legacy interface under /sys/kernel/debug/apei/einj. Instead, make the error types available under /sys/kernel/debug/cxl. This allows for validating the MMIO address for a CXL 1.1 error type while also not making the user responsible for finding it. CXL 2.0+ error types will be available through the legacy EINJ interface and under the new debug/cxl interface since they target the SBDF of the CXL downstream port instead of a MMIO address.

Ben Cheatham (4):
EINJ: Migrate to a platform driver
EINJ: Add CXL error type support
cxl/core: Add CXL EINJ debugfs files
EINJ, Documentation: Update EINJ kernel doc

 Documentation/ABI/testing/debugfs-cxl         |  30 +++++
 .../firmware-guide/acpi/apei/einj.rst         |  34 +++++
 MAINTAINERS                                   |   1 +
 drivers/acpi/apei/Kconfig                     |  12 ++
 drivers/acpi/apei/Makefile                    |   2 +
 drivers/acpi/apei/apei-internal.h             |  18 +++
 drivers/acpi/apei/{einj.c => einj-core.c}     | 123 +++++++++++++++---
 drivers/acpi/apei/einj-cxl.c                  | 116 +++++++++++++++++
 drivers/cxl/core/port.c                       |  42 ++++++
 include/linux/einj-cxl.h                      |  44 +++++++
 10 files changed, 401 insertions(+), 21 deletions(-)
 rename drivers/acpi/apei/{einj.c => einj-core.c} (90%)
 create mode 100644 drivers/acpi/apei/einj-cxl.c
 create mode 100644 include/linux/einj-cxl.h
Signature · 1 line
2.34.1