Skip to content

RFC benchmarks/gem_wsim: added basic xe support

Marcin Bernatowicz igt-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest8 patches 12 repliesIn review

v2 from the cover letter

- splitted patches to easy review (Kamil),
all benchmarks/gem_wsim patches before [RFC] one
contain fixes (for scale duration option), cleanups (checkpatch.pl), refactors (some code moved to functions),
not related to xe and ready to be applied
- lib/xe_spin is under review in other thread https://patchwork.freedesktop.org/series/122624/

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8lib/xe_spin: xe_spin_opts for xe_spin initializationlib/xe/xe_spin.c lib/xe/xe_spin.h tests/intel/xe_dma_buf_sync.c +4 more+57 -432 replies
2/8lib/xe_spin: fixed duration xe_spin capabilitylib/xe/xe_spin.c lib/xe/xe_spin.h+103 -20 replies
3/8lib/igt_device_scan: Xe get integrated/discrete card functionslib/igt_device_scan.c lib/igt_device_scan.h+27 -90 replies
4/8benchmarks/gem_wsim: scale duration option fixesbenchmarks/gem_wsim.c+61 -481 reply
5/8benchmarks/gem_wsim: cleanupsbenchmarks/gem_wsim.c+34 -220 replies
6/8benchmarks/gem_wsim: allow comments in workload description filesbenchmarks/gem_wsim.c benchmarks/wsim/README+34 -95 replies
7/8benchmarks/gem_wsim: extract prepare_ctxs function, add w_syncbenchmarks/gem_wsim.c+82 -630 replies
8/8benchmarks/gem_wsim: added basic xe supportbenchmarks/gem_wsim.c benchmarks/wsim/README benchmarks/wsim/xe_cloud-gaming-60fps.wsim +4 more+722 -553 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [igt-dev] [PATCH i-g-t 0/8] [RFC] benchmarks/gem_wsim: added basic xe support

Added basic xe support with few examples.
Single binary handles both i915 and Xe devices,
but workload definitions differs between i915 and xe.
Xe does not use context abstraction, introduces new VM and Exec Queue steps and BATCH step references exec queue.
For more details see wsim/README.
Some functionality is still missing: working sets,
load balancing (need some input if/how to do it in Xe - exec queues width?).

The tool is handy for scheduling tests, we find it useful to verify vGPU profiles defining different execution quantum/preemption timeout settings.

There is also some rationale for the tool in following thread:
https://lore.kernel.org/dri-devel/[email protected]/

With this patch it should be possible to run following on xe device:

gem_wsim -w benchmarks/wsim/xe_media_load_balance_fhd26u7.wsim -c 36 -r 600

Best with drm debug logs disabled:

echo 0 > /sys/module/drm/parameters/debug

lib/xe_spin: fixed duration xe_spin capability - is already
under review https://patchwork.freedesktop.org/series/122624/

v2:
- splitted patches to easy review (Kamil),
all benchmarks/gem_wsim patches before [RFC] one
contain fixes (for scale duration option), cleanups (checkpatch.pl), refactors (some code moved to functions),
not related to xe and ready to be applied
- lib/xe_spin is under review in other thread https://patchwork.freedesktop.org/series/122624/

Marcin Bernatowicz (8):
lib/xe_spin: xe_spin_opts for xe_spin initialization lib/xe_spin: fixed duration xe_spin capability lib/igt_device_scan: Xe get integrated/discrete card functions benchmarks/gem_wsim: scale duration option fixes benchmarks/gem_wsim: cleanups
benchmarks/gem_wsim: allow comments in workload description files benchmarks/gem_wsim: extract prepare_ctxs function, add w_sync [RFC] benchmarks/gem_wsim: added basic xe support

 benchmarks/gem_wsim.c                         | 875 ++++++++++++++----
 benchmarks/wsim/README                        |  87 +-
 benchmarks/wsim/xe_cloud-gaming-60fps.wsim    |  25 +
 benchmarks/wsim/xe_example.wsim               |  28 +
 benchmarks/wsim/xe_example01.wsim             |  19 +
 benchmarks/wsim/xe_example_fence.wsim         |  23 +
 .../wsim/xe_media_load_balance_fhd26u7.wsim   |  63 ++
 lib/igt_device_scan.c                         |  34 +-
 lib/igt_device_scan.h                         |   2 +
 lib/xe/xe_spin.c                              | 123 ++-
 lib/xe/xe_spin.h                              |  27 +-
 tests/intel/xe_dma_buf_sync.c                 |   6 +-
 tests/intel/xe_exec_balancer.c                |   9 +-
 tests/intel/xe_exec_reset.c                   |  24 +-
 tests/intel/xe_exec_threads.c                 |   7 +-
 tests/intel/xe_vm.c                           |   7 +-
 16 files changed, 1114 insertions(+), 245 deletions(-)
 create mode 100644 benchmarks/wsim/xe_cloud-gaming-60fps.wsim
 create mode 100644 benchmarks/wsim/xe_example.wsim
 create mode 100644 benchmarks/wsim/xe_example01.wsim
 create mode 100644 benchmarks/wsim/xe_example_fence.wsim
 create mode 100644 benchmarks/wsim/xe_media_load_balance_fhd26u7.wsim
Signature · 1 line
2.30.2