Skip to content

tracing: Fixes for 6.6

Steven Rostedt linux-kselftest lkml stable 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15tracefs: Add missing lockdown check to tracefs_create_dir()fs/tracefs/inode.c+3 -00 replies
2/15tracefs/eventfs: Add missing lockdown checksfs/tracefs/event_inode.c+15 -00 replies
3/15tracefs/eventfs: Use dput to free the toplevel events directoryfs/tracefs/event_inode.c fs/tracefs/inode.c fs/tracefs/internal.h+16 -80 replies
4/15tracing: Increase trace array ref count on enable and filter fileskernel/trace/trace.c kernel/trace/trace.h kernel/trace/trace_events.c+33 -20 replies
5/15tracing: Have tracing_max_latency inc the trace array ref countkernel/trace/trace.c+10 -50 replies
6/15tracing: Have current_trace inc the trace array ref countkernel/trace/trace.c+2 -10 replies
7/15tracing: Have option files inc the trace array ref countkernel/trace/trace.c+22 -10 replies
8/15tracing: Have event inject files inc the trace array ref countkernel/trace/trace_events_inject.c+2 -10 replies
9/15ring-buffer: Avoid softlockup in ring_buffer_resize()kernel/trace/ring_buffer.c+2 -00 replies
10/15tracefs/eventfs: Free top level files on removalfs/tracefs/event_inode.c+26 -40 replies
11/15ring-buffer: Do not attempt to read past "commit"kernel/trace/ring_buffer.c+5 -00 replies
12/15tracing: Use the new eventfs descriptor for print triggerkernel/trace/trace.c+2 -20 replies
13/15tracing: Remove unused trace_event_file dir fieldinclude/linux/trace_events.h kernel/trace/trace_events.c+0 -140 replies
14/15selftests/ftrace: Fix dependencies for some of the synthetic event teststools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-event-dynstring.tc tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic_event_syntax_errors.tc+2 -20 replies
15/15tracing/synthetic: Fix order of struct trace_dynamic_infoinclude/linux/trace_events.h+3 -30 replies

Reviews trailers per patch

1 of 15 patches has a Reviewed-by or Acked-by.

PatchLinux Kernel Functional TestingNaresh KambojuMasami Hiramatsu (Google)
1/15
2/15
3/15T-b T-b
4/15T-b T-b
5/15T-b T-b
6/15T-b T-b
7/15T-b T-b
8/15T-b T-b
9/15
10/15R-b
11/15
12/15
13/15
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [for-linus][PATCH 00/15] tracing: Fixes for 6.6

Tracing fixes for 6.6:

- Add missing LOCKDOWN checks for eventfs callers
When LOCKDOWN is active for tracing, it causes inconsistent state when some functions succeed and others fail.

- Use dput() to free the top level eventfs descriptor There was a race between accesses and freeing it.

- Fix a long standing bug that eventfs exposed due to changing timings by dynamically creating files. That is, If a event file is opened for an instance, there's nothing preventing the instance from being removed which will make accessing the files cause use-after-free bugs.

- Fix a ring buffer race that happens when iterating over the ring buffer while writers are active. Check to make sure not to read the event meta data if it's beyond the end of the ring buffer sub buffer.

- Fix the print trigger that disappeared because the test to create it was looking for the event dir field being filled, but now it has the "ef" field filled for the eventfs structure.

- Remove the unused "dir" field from the event structure.

- Fix the order of the trace_dynamic_info as it had it backwards for the offset and len fields for which one was for which endianess.

git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git
trace/urgent

Head SHA1: 595efe1079cd38a5b7d2762bf6d3bd94105bae0f

Naveen N Rao (1):
selftests/ftrace: Fix dependencies for some of the synthetic event tests

Steven Rostedt (Google) (13):
tracefs: Add missing lockdown check to tracefs_create_dir() tracefs/eventfs: Add missing lockdown checks tracefs/eventfs: Use dput to free the toplevel events directory
tracing: Increase trace array ref count on enable and filter files
tracing: Have tracing_max_latency inc the trace array ref count
tracing: Have current_trace inc the trace array ref count
tracing: Have option files inc the trace array ref count
tracing: Have event inject files inc the trace array ref count tracefs/eventfs: Free top level files on removal
ring-buffer: Do not attempt to read past "commit"
tracing: Use the new eventfs descriptor for print trigger
tracing: Remove unused trace_event_file dir field tracing/synthetic: Fix order of struct trace_dynamic_info

Zheng Yejian (1):
ring-buffer: Avoid softlockup in ring_buffer_resize()

----

 fs/tracefs/event_inode.c                           | 56 +++++++++++++++--
 fs/tracefs/inode.c                                 |  5 +-
 fs/tracefs/internal.h                              |  5 +-
 include/linux/trace_events.h                       |  7 +--
 kernel/trace/ring_buffer.c                         |  7 +++
 kernel/trace/trace.c                               | 72 +++++++++++++++++++---
 kernel/trace/trace.h                               |  2 +
 kernel/trace/trace_events.c                        | 19 ++----
 kernel/trace/trace_events_inject.c                 |  3 +-
 .../trigger-synthetic-event-dynstring.tc           |  2 +-
 .../trigger-synthetic_event_syntax_errors.tc       |  2 +-
 11 files changed, 140 insertions(+), 40 deletions(-)